)]}'
{"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"19075de87ba38492359e10750f7af68ec6bc608d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":253,"context_line":"    def test_boot_server_from_encrypted_volume_luks(self):"},{"line_number":254,"context_line":"        # Create an encrypted volume"},{"line_number":255,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027luks\u0027,"},{"line_number":256,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        self.volumes_client.set_bootable_volume(volume[\u0027id\u0027], bootable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_1cacdc32","line":255,"range":{"start_line":255,"start_character":47,"end_line":255,"end_character":51},"updated":"2020-05-14 02:32:18.000000000","message":"LEGACY_PROVIDER_CLASS_TO_FORMAT_MAP \u003d {\n    \"nova.volume.encryptors.luks.LuksEncryptor\": LUKS,\n    \"nova.volume.encryptors.cryptsetup.CryptsetupEncryptor\": PLAIN,\n    \"nova.volume.encryptors.nop.NoopEncryptor\": None,\n    \"LuksEncryptor\": LUKS,\n    \"CryptsetupEncryptor\": PLAIN,\n    \"NoOpEncryptor\": None,\n}\n\nSo, LGTM.\n\nBut as an aside, this becomes redundant with volume_type\u003d\u0027luks\u0027. Maybe it is possible to refactor the method itself later, but for backwards compatibility this is fine.","commit_id":"06e1ba95650fbf3510186dc52b3d81f344e64f45"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b17808de15dae18b2fa3f0b389e566b09a4aa2fe","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":253,"context_line":"    def test_boot_server_from_encrypted_volume_luks(self):"},{"line_number":254,"context_line":"        # Create an encrypted volume"},{"line_number":255,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027luks\u0027,"},{"line_number":256,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        self.volumes_client.set_bootable_volume(volume[\u0027id\u0027], bootable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a76dd433","line":255,"range":{"start_line":255,"start_character":47,"end_line":255,"end_character":51},"in_reply_to":"ff570b3c_1cacdc32","updated":"2020-05-14 07:45:36.000000000","message":"volume_type just sets the name of the volume type, which is otherwise created randomly from the class name. I guess its removal is orthogonal to the present issue, and it does not need a refector of create_encrypted_volume.","commit_id":"06e1ba95650fbf3510186dc52b3d81f344e64f45"}]}