)]}'
{"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"d4b4ba3e9e127a9716d75a74bb5197e767edab55","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":121,"context_line":"    def test_volume_type_encryption_create_get(self):"},{"line_number":122,"context_line":"        # Create/get encryption_type"},{"line_number":123,"context_line":"        body \u003d {}"},{"line_number":124,"context_line":"        name \u003d data_utils.rand_name(\"volume-type-\")"},{"line_number":125,"context_line":"        resp, body \u003d self.client.create_volume_type(name)"},{"line_number":126,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Ft1k%3D","line":123,"updated":"2014-02-11 09:15:42.000000000","message":"\"body \u003d {}\" could be removed.","commit_id":"efd505814418ccf42d53f807a0c07d0cb4a50d00"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"56df3cec679c2fba68eda9977387374d67085a14","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":121,"context_line":"    def test_volume_type_encryption_create_get(self):"},{"line_number":122,"context_line":"        # Create/get encryption_type"},{"line_number":123,"context_line":"        body \u003d {}"},{"line_number":124,"context_line":"        name \u003d data_utils.rand_name(\"volume-type-\")"},{"line_number":125,"context_line":"        resp, body \u003d self.client.create_volume_type(name)"},{"line_number":126,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Ftt4%3D","line":123,"in_reply_to":"AAAAUX%2F%2Ft1k%3D","updated":"2014-02-11 09:29:28.000000000","message":"ok, thanks","commit_id":"efd505814418ccf42d53f807a0c07d0cb4a50d00"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"20a3d56e4685c66edc956f200c893fae949ce25e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                         \u0027from the created encryption_type\u0027)"},{"line_number":139,"context_line":"        self.assertEqual(encryption_type[\u0027control_location\u0027],"},{"line_number":140,"context_line":"                         fetched_encryption_type[\u0027control_location\u0027],"},{"line_number":141,"context_line":"                         \u0027The fetched encryption_type is different \u0027"},{"line_number":142,"context_line":"                         \u0027from the created encryption_type\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BYlQ%3D","line":141,"updated":"2014-02-21 14:01:01.000000000","message":"Bad copy/paste. The warning message is the same here and in the previous assertEqual.","commit_id":"4b8fc7c77a1096d79bbc1a6a9d36432e350bd024"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"629f2f5d8bacf66468df9f78a43244fa7d93de37","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                         \u0027from the created encryption_type\u0027)"},{"line_number":139,"context_line":"        self.assertEqual(encryption_type[\u0027control_location\u0027],"},{"line_number":140,"context_line":"                         fetched_encryption_type[\u0027control_location\u0027],"},{"line_number":141,"context_line":"                         \u0027The fetched encryption_type is different \u0027"},{"line_number":142,"context_line":"                         \u0027from the created encryption_type\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2F7X0%3D","line":141,"in_reply_to":"AAAAUX%2F%2BYlQ%3D","updated":"2014-02-24 01:57:59.000000000","message":"Hi, Jordan, The warning message can be same, we do not need too detailed messages here, both \u0027provider\u0027 and \u0027control_location\u0027 difference can mean \u0027The fetched encryption_type is different from the created encryption_type\u0027, you can see warning message in function test_volume_type_create_get_delete too. thanks","commit_id":"4b8fc7c77a1096d79bbc1a6a9d36432e350bd024"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d2513dfc989971a866dd45a7236ee0c72c1a3ae6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":135,"context_line":"        self.assertEqual(encryption_type[\u0027provider\u0027],"},{"line_number":136,"context_line":"                         fetched_encryption_type[\u0027provider\u0027],"},{"line_number":137,"context_line":"                         \u0027The fetched encryption_type is different \u0027"},{"line_number":138,"context_line":"                         \u0027from the created encryption_type\u0027)"},{"line_number":139,"context_line":"        self.assertEqual(encryption_type[\u0027control_location\u0027],"},{"line_number":140,"context_line":"                         fetched_encryption_type[\u0027control_location\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2ByZ4%3D","line":137,"updated":"2014-03-12 06:14:48.000000000","message":"s/\"encryption_type\"/\"encryption_type provider\"/ for clarifying the difference from the above assertEqual.","commit_id":"419891dce4a1d0a743c6669bc46e08df0ccd6e63"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"9b0f6846b498f343d4f368484b2b32acbe10d9be","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":135,"context_line":"        self.assertEqual(encryption_type[\u0027provider\u0027],"},{"line_number":136,"context_line":"                         fetched_encryption_type[\u0027provider\u0027],"},{"line_number":137,"context_line":"                         \u0027The fetched encryption_type is different \u0027"},{"line_number":138,"context_line":"                         \u0027from the created encryption_type\u0027)"},{"line_number":139,"context_line":"        self.assertEqual(encryption_type[\u0027control_location\u0027],"},{"line_number":140,"context_line":"                         fetched_encryption_type[\u0027control_location\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F5B0%3D","line":137,"in_reply_to":"AAAAVn%2F%2ByZ4%3D","updated":"2014-03-13 07:27:06.000000000","message":"ok, done","commit_id":"419891dce4a1d0a743c6669bc46e08df0ccd6e63"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d2513dfc989971a866dd45a7236ee0c72c1a3ae6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                         \u0027from the created encryption_type\u0027)"},{"line_number":139,"context_line":"        self.assertEqual(encryption_type[\u0027control_location\u0027],"},{"line_number":140,"context_line":"                         fetched_encryption_type[\u0027control_location\u0027],"},{"line_number":141,"context_line":"                         \u0027The fetched encryption_type is different \u0027"},{"line_number":142,"context_line":"                         \u0027from the created encryption_type\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2ByZw%3D","line":141,"updated":"2014-03-12 06:14:48.000000000","message":"s/\"encryption_type\"/\"encryption_type control_location\"/","commit_id":"419891dce4a1d0a743c6669bc46e08df0ccd6e63"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"9b0f6846b498f343d4f368484b2b32acbe10d9be","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                         \u0027from the created encryption_type\u0027)"},{"line_number":139,"context_line":"        self.assertEqual(encryption_type[\u0027control_location\u0027],"},{"line_number":140,"context_line":"                         fetched_encryption_type[\u0027control_location\u0027],"},{"line_number":141,"context_line":"                         \u0027The fetched encryption_type is different \u0027"},{"line_number":142,"context_line":"                         \u0027from the created encryption_type\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F5Bw%3D","line":141,"in_reply_to":"AAAAVn%2F%2ByZw%3D","updated":"2014-03-13 07:27:06.000000000","message":"ok, done","commit_id":"419891dce4a1d0a743c6669bc46e08df0ccd6e63"}],"tempest/services/volume/json/admin/volume_types_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2084ef9317447bba198ff0db4bb72e712786cfff","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        post_body \u003d {}"},{"line_number":148,"context_line":"        post_body.update(kwargs)"},{"line_number":149,"context_line":"        post_body \u003d json.dumps({\u0027encryption\u0027: post_body})"},{"line_number":150,"context_line":"        resp, body \u003d self.post(url, post_body, self.headers)"},{"line_number":151,"context_line":"        body \u003d json.loads(body)"},{"line_number":152,"context_line":"        return resp, body[\u0027encryption\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B2AU%3D","line":150,"updated":"2014-02-18 17:04:06.000000000","message":"As per Ie43d10affc981d3446b1296cf05ef595154276a9 and I28981738a9e7f39343cf530c2642315f0a5b22f2 I believe self.header is useless now.","commit_id":"7195c315f7fc22f5432efff444433b95d4411e02"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"2b7016011e0571a4a0a835e3dad0057eec74681a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        post_body \u003d {}"},{"line_number":148,"context_line":"        post_body.update(kwargs)"},{"line_number":149,"context_line":"        post_body \u003d json.dumps({\u0027encryption\u0027: post_body})"},{"line_number":150,"context_line":"        resp, body \u003d self.post(url, post_body, self.headers)"},{"line_number":151,"context_line":"        body \u003d json.loads(body)"},{"line_number":152,"context_line":"        return resp, body[\u0027encryption\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2BpAQ%3D","line":150,"in_reply_to":"AAAAUX%2F%2B2AU%3D","updated":"2014-02-20 02:42:45.000000000","message":"Good, I do not know rest client had changed when I submitted this patch, I will remove it, thanks, Jordan","commit_id":"7195c315f7fc22f5432efff444433b95d4411e02"}]}