)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2ba0cd94caac760f8baf7086bcd8fed44cef3adf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"snapshot image as the rescue image. Such images contain no actual image"},{"line_number":11,"context_line":"data and are just used to store metadata such as the"},{"line_number":12,"context_line":"block_device_mapping that is in turn used when creating new instances"},{"line_number":13,"context_line":"from the backing volume snapshots."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This wasn\u0027t initially noticed as the tests pass on the default file"},{"line_number":16,"context_line":"based imagebackend in Nova that allows zero length sparse files to be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_52d38dd5","line":13,"updated":"2020-05-18 19:56:42.000000000","message":"Not related to this patch, but I\u0027m curious what happens on the nova side if a user attempts to use a volume based image as the rescue image? Do we fail fast or no?","commit_id":"2fd745f97e84f3438d556a480e2674b69af47e18"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"211e770d34cb34c0d577417f33518bcb8c72f022","unresolved":false,"context_lines":[{"line_number":10,"context_line":"snapshot image as the rescue image. Such images contain no actual image"},{"line_number":11,"context_line":"data and are just used to store metadata such as the"},{"line_number":12,"context_line":"block_device_mapping that is in turn used when creating new instances"},{"line_number":13,"context_line":"from the backing volume snapshots."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This wasn\u0027t initially noticed as the tests pass on the default file"},{"line_number":16,"context_line":"based imagebackend in Nova that allows zero length sparse files to be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_00436db0","line":13,"in_reply_to":"ff570b3c_52d38dd5","updated":"2020-05-19 13:44:40.000000000","message":"Yup great catch, I\u0027ve just pushed I87253c518bd60a3e7cd08af68da9ade96f4a40db","commit_id":"2fd745f97e84f3438d556a480e2674b69af47e18"}],"tempest/api/compute/servers/test_server_rescue.py":[{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"ef0ef98f733b280b72da9bdd1334077d761eeb0b","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if block_device_mapping_v2:"},{"line_number":132,"context_line":"            server_id \u003d self.create_test_server("},{"line_number":133,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":134,"context_line":"                block_device_mapping_v2\u003dblock_device_mapping_v2)[\u0027id\u0027]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if hw_rescue_bus:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_3de73015","line":133,"updated":"2020-05-13 10:12:45.000000000","message":"I think we don\u0027t really get here server_id when we are not even attaching the [\u0027id\u0027] for self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)?","commit_id":"c2d51bcbe6777db41d93c41d20db5e28a30bd704"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dea9f611539c60402a37f47a99b7763e9cdc2511","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if block_device_mapping_v2:"},{"line_number":132,"context_line":"            server_id \u003d self.create_test_server("},{"line_number":133,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":134,"context_line":"                block_device_mapping_v2\u003dblock_device_mapping_v2)[\u0027id\u0027]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if hw_rescue_bus:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_dfa701a7","line":133,"in_reply_to":"ff570b3c_3de73015","updated":"2020-05-13 16:23:28.000000000","message":"did not get your question. so in case of block_device_mapping_v2 (l194 ServerBootFromVolumeStableRescueTest), we will be creating the bfv server to be rescue and store its id as server_id.","commit_id":"c2d51bcbe6777db41d93c41d20db5e28a30bd704"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f48d6d3fee134991f5647610a7b0a74a1b2a7d8b","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if block_device_mapping_v2:"},{"line_number":132,"context_line":"            server_id \u003d self.create_test_server("},{"line_number":133,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":134,"context_line":"                block_device_mapping_v2\u003dblock_device_mapping_v2)[\u0027id\u0027]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if hw_rescue_bus:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_f9547300","line":133,"in_reply_to":"ff570b3c_a7bbfbc1","updated":"2020-05-15 15:43:06.000000000","message":"\u003e If we look at line no. 126, server_id has been created by server_id\n \u003e \u003d self.create_test_server(\n \u003e wait_until\u003d\u0027ACTIVE\u0027)[\u0027id\u0027]\n \u003e then why is it different at line 132, why can\u0027t we create server_id\n \u003e same as above?\n\nI think that you\u0027re missing that L132-134 are the same line and will return a new server_id for the actual test when block_device_mapping_v2 is provided, overwriting the original server_id from L126-127 that is used to create the image based instance snapshot.\n\nThere\u0027s more detail in the commit message as to why we have to do this and can\u0027t simply snapshot the volume backed instance created when block_device_mapping_v2 is provided.","commit_id":"c2d51bcbe6777db41d93c41d20db5e28a30bd704"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"0d6f50c2f086725c52481b0acd820d566062ab8f","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if block_device_mapping_v2:"},{"line_number":132,"context_line":"            server_id \u003d self.create_test_server("},{"line_number":133,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":134,"context_line":"                block_device_mapping_v2\u003dblock_device_mapping_v2)[\u0027id\u0027]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if hw_rescue_bus:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a7bbfbc1","line":133,"in_reply_to":"ff570b3c_dfa701a7","updated":"2020-05-15 08:31:09.000000000","message":"If we look at line no. 126, server_id has been created by server_id \u003d self.create_test_server(\n            wait_until\u003d\u0027ACTIVE\u0027)[\u0027id\u0027]\nthen why is it different at line 132, why can\u0027t we create server_id same as above?","commit_id":"c2d51bcbe6777db41d93c41d20db5e28a30bd704"}]}