)]}'
{"tempest/api/network/test_networks.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"d29f91ca4ac59ec7949120f36c69edb541086750","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # Verify that creating a port with argument of fixed_ips works"},{"line_number":205,"context_line":"        fixed_ips_value \u003d [{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027]}]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        resp, body \u003d self.client.create_port_with_fixed_ips("},{"line_number":208,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":209,"context_line":"            fixed_ips_value)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2Fcr0%3D","line":207,"updated":"2014-02-13 05:53:23.000000000","message":"don\u0027t need to add a new method to create such port.\n\ncreat_port could do that.\n\nresp, body \u003d self.client.create_port(\n            network_id\u003dself.network[\u0027id\u0027],\n            fixed_ips\u003dfixed_ips_value)","commit_id":"c8db987437bdde9563f1c97e6cd95df314df1d99"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"304f0f74b3a320efecc03e5099b4ba3575276f41","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # Verify that creating a port with argument of fixed_ips works"},{"line_number":205,"context_line":"        fixed_ips_value \u003d [{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027]}]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        resp, body \u003d self.client.create_port_with_fixed_ips("},{"line_number":208,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":209,"context_line":"            fixed_ips_value)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FcjI%3D","line":207,"in_reply_to":"AAAAUX%2F%2Fcr0%3D","updated":"2014-02-13 06:04:25.000000000","message":"thanks,zhikun. i tried that before, create_port() cannot be used directly here. because of the format of the fixed_ips_value here.. and xml serialization can not serialize it correctly.","commit_id":"c8db987437bdde9563f1c97e6cd95df314df1d99"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"59945844f3a0abf4d5bec16521dd669af8eb3ab5","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        resp, body \u003d self.client.create_port_with_fixed_ips("},{"line_number":208,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":209,"context_line":"            fixed_ips_value)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":212,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2Fcvs%3D","line":209,"updated":"2014-02-13 05:34:37.000000000","message":"Instead of deleting port in the end of test, using addCleanup here could make sure the port is deleted when the following assert fail.","commit_id":"c8db987437bdde9563f1c97e6cd95df314df1d99"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"304f0f74b3a320efecc03e5099b4ba3575276f41","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        resp, body \u003d self.client.create_port_with_fixed_ips("},{"line_number":208,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":209,"context_line":"            fixed_ips_value)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":212,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FcpU%3D","line":209,"in_reply_to":"AAAAUX%2F%2Fcvs%3D","updated":"2014-02-13 06:04:25.000000000","message":"yes.u r right. thanks.","commit_id":"c8db987437bdde9563f1c97e6cd95df314df1d99"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a45da926a7fbc3e14f79ebfe4ff6da86f62a3551","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        resp, body \u003d self.client.create_port_with_fixed_ips("},{"line_number":208,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":209,"context_line":"            fixed_ips_value)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":212,"context_line":"        self.addCleanup(self.client.delete_port, port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FbE4%3D","line":209,"updated":"2014-02-13 10:18:09.000000000","message":"I have to create port with fixed ips in one of my \n changes(https://review.openstack.org/71251),\n this is looked like\n\n    fixed_ips \u003d [{\u0027ip_address\u0027: first_ip}, \n                      {\u0027ip_address\u0027: second_ip}]\n    resp, body \u003d self.client.create_port(\n                                network_id\u003dself.network[\u0027id\u0027],                                             \n                                fixed_ips\u003dfixed_ips)\n\nPlease do like this, then you will avoid adding  \n unnecessary create_port_with_fixed_ips in json/xml clients.","commit_id":"f23faaf609af3fa31ef5ad39441bab245c5e7dc1"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a45da926a7fbc3e14f79ebfe4ff6da86f62a3551","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":212,"context_line":"        self.addCleanup(self.client.delete_port, port[\u0027id\u0027])"},{"line_number":213,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":214,"context_line":"        self.assertEqual("},{"line_number":215,"context_line":"            self.subnet[\u0027id\u0027],"},{"line_number":216,"context_line":"            port[\"fixed_ips\"][0][\"subnet_id\"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FbGs%3D","line":213,"updated":"2014-02-13 10:18:09.000000000","message":"You should check status just after creation.","commit_id":"f23faaf609af3fa31ef5ad39441bab245c5e7dc1"}]}