)]}'
{"tempest/api/compute/v3/servers/test_instance_actions.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"63d9e394a3befd689e4ef334b871c79453b78c19","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            cls.request_id \u003d resp[\u0027x-compute-request-id\u0027]"},{"line_number":31,"context_line":"        except KeyError:"},{"line_number":32,"context_line":"            msg \u003d \u0027Skipped since x-compute-request-id header is going away\u0027"},{"line_number":33,"context_line":"            raise exceptions.TestCase.skipException(msg)"},{"line_number":34,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2B0Os%3D","line":33,"updated":"2014-02-18 20:49:19.000000000","message":"Instead of skipping why not change this to:\n\ncls.request_id \u003d resp[\u0027x-openstack-request-id\u0027]\n\nAnd then once the nova patch lands drop the try except block","commit_id":"6c02aefda04cba27fb0f9af2724ff5abcf1e96f7"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"07c4a794c6116c5add303cbffbfb852518698a14","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            cls.request_id \u003d resp[\u0027x-compute-request-id\u0027]"},{"line_number":31,"context_line":"        except KeyError:"},{"line_number":32,"context_line":"            msg \u003d \u0027Skipped since x-compute-request-id header is going away\u0027"},{"line_number":33,"context_line":"            raise exceptions.TestCase.skipException(msg)"},{"line_number":34,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2B0DQ%3D","line":33,"in_reply_to":"AAAAUX%2F%2B0Os%3D","updated":"2014-02-18 21:16:23.000000000","message":"No that is the wrong way to do it, a skip is correct see the comments on the follow up patch. Additionally this is the wrong way to skip it, look at the skip_because decorator. We need to be able to track the skip.\n\nAlso you only need to skip one test the request id is only used in test_get_instance_action() I would make this a 2 patch series one to fix the tests so the request_id is only saved where it\u0027s needed, and the second adds the skip properly on the one test.","commit_id":"6c02aefda04cba27fb0f9af2724ff5abcf1e96f7"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"baee3c92c2724cff8442e3d535c27a402b30f511","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        resp, server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":29,"context_line":"        try:"},{"line_number":30,"context_line":"            cls.request_id \u003d resp[\u0027x-compute-request-id\u0027]"},{"line_number":31,"context_line":"        except KeyError:"},{"line_number":32,"context_line":"            cls.request_id \u003d resp[\u0027x-openstack-request-id\u0027]"},{"line_number":33,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B0Dw%3D","line":31,"updated":"2014-02-18 21:16:19.000000000","message":"So it should be one or the other not both here.\n\nBased on your nova patch v3 will be moving to only x-openstack-request-id so moving forward there is no need to check for x-compute-request-id. You can\u0027t avoid the 2 patch approach by doing this instead of the skip, because after your nova patch merges we don\u0027t want x-compute-request-id to pass so you\u0027ll have to remove it.\n\nThe reason I suggested you do a skip originally is because this approach opens up the risk that we start passing the test with the incorrect header. While with a skip we have a tracked bug that says why this test isn\u0027t run. So if for some reason you didn\u0027t submit the follow up patch it\u0027s clear what needs to be done. With this it\u0027s not at all clear and we could have a regression and no one would know.","commit_id":"d60a832cbbda3b6c4a4087d610893055957d549b"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"cca855d93fe1d8dc0d152e7223b0ac21b53c21e2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @skip_because(bug\u003d\"1281915\")"},{"line_number":47,"context_line":"    def test_get_instance_action(self):"},{"line_number":48,"context_line":"        # Get the action details of the provided server"},{"line_number":49,"context_line":"        request_id \u003d self.resp[\u0027x-compute-request-id\u0027]"},{"line_number":50,"context_line":"        resp, body \u003d self.client.get_instance_action(self.server_id,"},{"line_number":51,"context_line":"                                                     request_id)"},{"line_number":52,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Bw6o%3D","line":49,"updated":"2014-02-19 07:51:07.000000000","message":"It\u0027s better to use \u0027x-openstack-request-id\u0027 here.","commit_id":"58bfa52d474dda59fe6bcc465bcfd02a38191005"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"6b703f0f976eb067e5b74ba9248e40da15e0292c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @skip_because(bug\u003d\"1281915\")"},{"line_number":47,"context_line":"    def test_get_instance_action(self):"},{"line_number":48,"context_line":"        # Get the action details of the provided server"},{"line_number":49,"context_line":"        request_id \u003d self.resp[\u0027x-compute-request-id\u0027]"},{"line_number":50,"context_line":"        resp, body \u003d self.client.get_instance_action(self.server_id,"},{"line_number":51,"context_line":"                                                     request_id)"},{"line_number":52,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BomI%3D","line":49,"in_reply_to":"AAAAUX%2F%2BpWo%3D","updated":"2014-02-20 03:57:00.000000000","message":"Read the comments on patch set 1","commit_id":"58bfa52d474dda59fe6bcc465bcfd02a38191005"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"27cd3977d00def11509a0405cd9e0af3feafb133","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @skip_because(bug\u003d\"1281915\")"},{"line_number":47,"context_line":"    def test_get_instance_action(self):"},{"line_number":48,"context_line":"        # Get the action details of the provided server"},{"line_number":49,"context_line":"        request_id \u003d self.resp[\u0027x-compute-request-id\u0027]"},{"line_number":50,"context_line":"        resp, body \u003d self.client.get_instance_action(self.server_id,"},{"line_number":51,"context_line":"                                                     request_id)"},{"line_number":52,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BpWo%3D","line":49,"in_reply_to":"AAAAUX%2F%2Bt%2Bw%3D","updated":"2014-02-20 01:36:57.000000000","message":"Test method is skipped due to the header \u0027x-openstack-request-id\u0027.It should be more reasonable to use that header.  And we don\u0027t need to update the header when nova patch getting merged. The only action is to remove the skip statement. This can avoid extra confusion.","commit_id":"58bfa52d474dda59fe6bcc465bcfd02a38191005"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"3ef7e21b82d7de5611a9c6f034b470d8614dcbba","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @skip_because(bug\u003d\"1281915\")"},{"line_number":47,"context_line":"    def test_get_instance_action(self):"},{"line_number":48,"context_line":"        # Get the action details of the provided server"},{"line_number":49,"context_line":"        request_id \u003d self.resp[\u0027x-compute-request-id\u0027]"},{"line_number":50,"context_line":"        resp, body \u003d self.client.get_instance_action(self.server_id,"},{"line_number":51,"context_line":"                                                     request_id)"},{"line_number":52,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Bt%2Bw%3D","line":49,"in_reply_to":"AAAAUX%2F%2Bw6o%3D","updated":"2014-02-19 15:57:00.000000000","message":"No, because nova is currently sending x-compute-request-id. https://review.openstack.org/#/c/66903/ will change the header to x-openstack-request-id. Once that change is merged, this test can be updated to use the new header.","commit_id":"58bfa52d474dda59fe6bcc465bcfd02a38191005"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"c9a233958e71e2d4ec57a79113868a134b922d32","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertTrue(any([i for i in body if i[\u0027action\u0027] \u003d\u003d \u0027reboot\u0027]))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":46,"context_line":"    @skip_because(bug\u003d\"1281915\")"},{"line_number":47,"context_line":"    def test_get_instance_action(self):"},{"line_number":48,"context_line":"        # Get the action details of the provided server"},{"line_number":49,"context_line":"        request_id \u003d self.resp[\u0027x-compute-request-id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2BXKQ%3D","line":46,"updated":"2014-02-21 16:24:20.000000000","message":"please do from tempest import test and use test.skip_because instead.\nit\u0027s a small style nit, but better to catch it before goes in the code base.","commit_id":"e73a3523b9d5b348a1be88c9a6e7e66236c9b928"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"48b01c450347ef0d927636212147d89cca37c5c3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertTrue(any([i for i in body if i[\u0027action\u0027] \u003d\u003d \u0027reboot\u0027]))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":46,"context_line":"    @skip_because(bug\u003d\"1281915\")"},{"line_number":47,"context_line":"    def test_get_instance_action(self):"},{"line_number":48,"context_line":"        # Get the action details of the provided server"},{"line_number":49,"context_line":"        request_id \u003d self.resp[\u0027x-compute-request-id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2BTnY%3D","line":46,"in_reply_to":"AAAAUX%2F%2BXKQ%3D","updated":"2014-02-22 00:40:07.000000000","message":"Done","commit_id":"e73a3523b9d5b348a1be88c9a6e7e66236c9b928"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"4beba9c7f2c93f5cd6fae98584ba932a7efa28ad","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tempest.api.compute import base"},{"line_number":17,"context_line":"from tempest import exceptions"},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":"from tempest.test import attr"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class InstanceActionsV3Test(base.BaseV3ComputeTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2F58Y%3D","line":19,"updated":"2014-02-24 06:18:05.000000000","message":"line 19 is not necessary.  (attr -\u003e test.attr)","commit_id":"40a3872611ca193945408f5e4d38eccc7257614e"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"7e5d27d8635bc5e244697bea5aa8d56c5327258e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tempest.api.compute import base"},{"line_number":17,"context_line":"from tempest import exceptions"},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":"from tempest.test import attr"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class InstanceActionsV3Test(base.BaseV3ComputeTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F%2FK0%3D","line":19,"in_reply_to":"AAAAU3%2F%2F58Y%3D","updated":"2014-02-27 00:30:03.000000000","message":"Done","commit_id":"40a3872611ca193945408f5e4d38eccc7257614e"}]}