)]}'
{"tempest/api/volume/admin/test_volume_types_negative.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b059c9225cd3ca096984b5b5e551a8f3443b1146","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":45,"context_line":"                          self.admin_volume_types_client.update_volume_type,"},{"line_number":46,"context_line":"                          data_utils.rand_uuid(),"},{"line_number":47,"context_line":"                          name\u003ddata_utils.rand_name(\u0027update\u0027),"},{"line_number":48,"context_line":"                          is_public\u003dTrue,"},{"line_number":49,"context_line":"                          description\u003ddata_utils.rand_name(\u0027updatedesc\u0027))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002795c7a4a4-36aa-42cc-bfc5-d26c8c58c9cd\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_5fbf3fa9","line":49,"range":{"start_line":47,"start_character":26,"end_line":49,"end_character":73},"updated":"2020-05-30 13:28:56.000000000","message":"nit: I think we can test this just using 1 parameter to update. Not all 3 have to be used.","commit_id":"908bd67d30fd20f8fd05adc94b9cba15cae6504d"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"50426c777d0d82116cbc4854bf7542536eda6bb9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":45,"context_line":"                          self.admin_volume_types_client.update_volume_type,"},{"line_number":46,"context_line":"                          data_utils.rand_uuid(),"},{"line_number":47,"context_line":"                          name\u003ddata_utils.rand_name(\u0027update\u0027),"},{"line_number":48,"context_line":"                          is_public\u003dTrue,"},{"line_number":49,"context_line":"                          description\u003ddata_utils.rand_name(\u0027updatedesc\u0027))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002795c7a4a4-36aa-42cc-bfc5-d26c8c58c9cd\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_00b8bfe2","line":49,"range":{"start_line":47,"start_character":26,"end_line":49,"end_character":73},"in_reply_to":"ff570b3c_5fbf3fa9","updated":"2020-06-01 00:47:33.000000000","message":"Done","commit_id":"908bd67d30fd20f8fd05adc94b9cba15cae6504d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b059c9225cd3ca096984b5b5e551a8f3443b1146","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          is_public\u003dTrue,"},{"line_number":49,"context_line":"                          description\u003ddata_utils.rand_name(\u0027updatedesc\u0027))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002795c7a4a4-36aa-42cc-bfc5-d26c8c58c9cd\u0027)"},{"line_number":53,"context_line":"    def test_update_with_invalid_type_id(self):"},{"line_number":54,"context_line":"        # Should not be able to update volume type with invalid type id."}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_bfddbb15","line":51,"updated":"2020-05-30 13:28:56.000000000","message":"My opinion is that these 2 tests below aren\u0027t necessary. I think just one test for \"test_update_with_nonexistent_type_id\" is sufficient. The rest feels redundant.","commit_id":"908bd67d30fd20f8fd05adc94b9cba15cae6504d"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"50426c777d0d82116cbc4854bf7542536eda6bb9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          is_public\u003dTrue,"},{"line_number":49,"context_line":"                          description\u003ddata_utils.rand_name(\u0027updatedesc\u0027))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002795c7a4a4-36aa-42cc-bfc5-d26c8c58c9cd\u0027)"},{"line_number":53,"context_line":"    def test_update_with_invalid_type_id(self):"},{"line_number":54,"context_line":"        # Should not be able to update volume type with invalid type id."}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_60d09b20","line":51,"in_reply_to":"ff570b3c_bfddbb15","updated":"2020-06-01 00:47:33.000000000","message":"Done","commit_id":"908bd67d30fd20f8fd05adc94b9cba15cae6504d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b059c9225cd3ca096984b5b5e551a8f3443b1146","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                          description\u003ddata_utils.rand_name(\u0027updatedesc\u0027))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":73,"context_line":"    @decorators.idempotent_id(\u0027085d3526-490b-4cfc-a996-ca2438400859\u0027)"},{"line_number":74,"context_line":"    def test_delete_nonexistent_type_id(self):"},{"line_number":75,"context_line":"        # Should not be able to delete volume type with nonexistent type id."},{"line_number":76,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_dfb34fe8","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":68},"updated":"2020-05-30 13:28:56.000000000","message":"This ID should remain unchanged. It should still be \u00276b3926d2-7d73-4896-bc3d-e42dfd11a9f6\u0027.","commit_id":"908bd67d30fd20f8fd05adc94b9cba15cae6504d"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"50426c777d0d82116cbc4854bf7542536eda6bb9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                          description\u003ddata_utils.rand_name(\u0027updatedesc\u0027))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":73,"context_line":"    @decorators.idempotent_id(\u0027085d3526-490b-4cfc-a996-ca2438400859\u0027)"},{"line_number":74,"context_line":"    def test_delete_nonexistent_type_id(self):"},{"line_number":75,"context_line":"        # Should not be able to delete volume type with nonexistent type id."},{"line_number":76,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_40cd9783","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":68},"in_reply_to":"ff570b3c_dfb34fe8","updated":"2020-06-01 00:47:33.000000000","message":"Done","commit_id":"908bd67d30fd20f8fd05adc94b9cba15cae6504d"}]}