)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe25a0efb932af7882509c4881439aff5c42847f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"97252eb7_19f3fe1a","updated":"2021-12-10 02:13:28.000000000","message":"let\u0027s add tests to verify the schema and update microversion doc also","commit_id":"82f67d08f86c344e157064d242d2120882e691e9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"211d309c916e67f3b0a5d4266b0483d02c53ab43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6c65c3d5_7484fc62","updated":"2022-03-04 07:05:31.000000000","message":"lgtm","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"094a5a8e0dc8ea2ff04f1a222315f7e447ecb7a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5d760b9c_d3383501","updated":"2021-12-19 18:30:48.000000000","message":"recheck","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1cdaca1b1a0eaff89db14d9eb5314ad2fe26571","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9159ca54_355f9818","updated":"2021-12-17 15:40:09.000000000","message":"recheck","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b0aca4bc399674b007ce4694c4097e04d831a923","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"658ed1fd_44778347","updated":"2022-03-04 07:04:36.000000000","message":"recheck (it\u0027s been more than 2 months since the check jobs were executed)","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"}],"tempest/api/compute/admin/test_quotas.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"311438641d4f00f369eb2c526412e7733cdaf774","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        self._get_updated_quotas()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"class QuotasAdminTestV257(QuotasAdminTestBase):"},{"line_number":190,"context_line":"    \"\"\"Test compute quotas with microversion greater than 2.56"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    # NOTE(gmann): This test tests the Quota APIs response schema"}],"source_content_type":"text/x-python","patch_set":6,"id":"0963973c_691ac645","line":189,"range":{"start_line":189,"start_character":6,"end_line":189,"end_character":47},"updated":"2022-03-03 23:29:36.000000000","message":"isn\u0027t this class basically a subset of the new one? The new inherits from QuotaClassesAdminTestJSON which inherits from QuotasAdminTestBase - the same class this one (QuotasAdminTestV257) inherits from","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f67ec669583382b45f8368f96484c4062cbc4732","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        self._get_updated_quotas()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"class QuotasAdminTestV257(QuotasAdminTestBase):"},{"line_number":190,"context_line":"    \"\"\"Test compute quotas with microversion greater than 2.56"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    # NOTE(gmann): This test tests the Quota APIs response schema"}],"source_content_type":"text/x-python","patch_set":6,"id":"6aea3b95_2bc77f79","line":189,"range":{"start_line":189,"start_character":6,"end_line":189,"end_character":47},"in_reply_to":"0963973c_691ac645","updated":"2022-03-04 01:50:26.000000000","message":"no, QuotaClassesAdminTestJSON is inherit from BaseV2ComputeAdminTest @L208. both are different, one is for \u0027Quota set\u0027 and another is for \u0027Quota Class Set\u0027 APIs","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b0aca4bc399674b007ce4694c4097e04d831a923","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self._get_updated_quotas()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"class QuotasAdminTestV257(QuotasAdminTestBase):"},{"line_number":190,"context_line":"    \"\"\"Test compute quotas with microversion greater than 2.56"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    # NOTE(gmann): This test tests the Quota APIs response schema"}],"source_content_type":"text/x-python","patch_set":6,"id":"4aff3732_7e5025dc","line":189,"range":{"start_line":189,"start_character":6,"end_line":189,"end_character":47},"in_reply_to":"6aea3b95_2bc77f79","updated":"2022-03-04 07:04:36.000000000","message":"ah, right, i misread, thanks","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"}],"tempest/lib/api_schema/response/compute/v2_50/quota_classes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6463bc003e18c502a7283e14acdf099eb806b5ed","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 IBM Corporation."},{"line_number":2,"context_line":"# All rights reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ca30ad1_39fb9088","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":33},"updated":"2021-06-14 22:17:44.000000000","message":"you need to remove this or update with correct info","commit_id":"82f67d08f86c344e157064d242d2120882e691e9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"311438641d4f00f369eb2c526412e7733cdaf774","unresolved":true,"context_lines":[{"line_number":28,"context_line":"get_quota_class_set \u003d copy.deepcopy(quota_classesv21.get_quota_class_set)"},{"line_number":29,"context_line":"update_quota_class_set \u003d copy.deepcopy(quota_classesv21.update_quota_class_set)"},{"line_number":30,"context_line":"for field in [\u0027fixed_ips\u0027, \u0027floating_ips\u0027, \u0027security_group_rules\u0027,"},{"line_number":31,"context_line":"              \u0027security_groups\u0027]:"},{"line_number":32,"context_line":"    get_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["},{"line_number":33,"context_line":"        \u0027properties\u0027].pop(field, None)"},{"line_number":34,"context_line":"    get_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["}],"source_content_type":"text/x-python","patch_set":6,"id":"162ac687_53faf9d0","line":31,"range":{"start_line":31,"start_character":30,"end_line":31,"end_character":33},"updated":"2022-03-03 23:29:36.000000000","message":"isn\u0027t \"networks\" missing here? it\u0027s mentioned in the list here: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id46","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f67ec669583382b45f8368f96484c4062cbc4732","unresolved":true,"context_lines":[{"line_number":28,"context_line":"get_quota_class_set \u003d copy.deepcopy(quota_classesv21.get_quota_class_set)"},{"line_number":29,"context_line":"update_quota_class_set \u003d copy.deepcopy(quota_classesv21.update_quota_class_set)"},{"line_number":30,"context_line":"for field in [\u0027fixed_ips\u0027, \u0027floating_ips\u0027, \u0027security_group_rules\u0027,"},{"line_number":31,"context_line":"              \u0027security_groups\u0027]:"},{"line_number":32,"context_line":"    get_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["},{"line_number":33,"context_line":"        \u0027properties\u0027].pop(field, None)"},{"line_number":34,"context_line":"    get_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["}],"source_content_type":"text/x-python","patch_set":6,"id":"ccab5a5e_78e90ec6","line":31,"range":{"start_line":31,"start_character":30,"end_line":31,"end_character":33},"in_reply_to":"162ac687_53faf9d0","updated":"2022-03-04 01:50:26.000000000","message":"Actually network things were removed once nova-network gone. so it was in remove for 2.50 as mentioned in the doc but later when we removed the nova-netowork then it is gone from everywhere. We are adding this schema late ohterwise we need to update here if network was included for 2.50 and after nova-network removal\n\nhttps://github.com/openstack/nova/commit/6fe31d97542467656cdecd90c2e0a9057a4f7480","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b0aca4bc399674b007ce4694c4097e04d831a923","unresolved":false,"context_lines":[{"line_number":28,"context_line":"get_quota_class_set \u003d copy.deepcopy(quota_classesv21.get_quota_class_set)"},{"line_number":29,"context_line":"update_quota_class_set \u003d copy.deepcopy(quota_classesv21.update_quota_class_set)"},{"line_number":30,"context_line":"for field in [\u0027fixed_ips\u0027, \u0027floating_ips\u0027, \u0027security_group_rules\u0027,"},{"line_number":31,"context_line":"              \u0027security_groups\u0027]:"},{"line_number":32,"context_line":"    get_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["},{"line_number":33,"context_line":"        \u0027properties\u0027].pop(field, None)"},{"line_number":34,"context_line":"    get_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["}],"source_content_type":"text/x-python","patch_set":6,"id":"8f8a6d53_ac27eab8","line":31,"range":{"start_line":31,"start_character":30,"end_line":31,"end_character":33},"in_reply_to":"ccab5a5e_78e90ec6","updated":"2022-03-04 07:04:36.000000000","message":"i see, thanks for the explanation.","commit_id":"dc517e0a1cae0d46862a16175379d5a6587c1935"}],"tempest/lib/api_schema/response/compute/v2_57/quota_classes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6463bc003e18c502a7283e14acdf099eb806b5ed","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.api_schema.response.compute.v2_50 import quota_classes \\"},{"line_number":19,"context_line":"    as quota_classesv250"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Compute microversion 2.57:"},{"line_number":22,"context_line":"# 1. injected_file_content_bytes, injected_file_path_bytes, injected_files"},{"line_number":23,"context_line":"#    are removed from:"},{"line_number":24,"context_line":"#      * GET /os-quota-class-sets/{id}"},{"line_number":25,"context_line":"#      * PUT /os-quota-class-sets/{id}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"get_quota_class_set \u003d copy.deepcopy(quota_classesv250.get_quota_class_set)"},{"line_number":28,"context_line":"update_quota_class_set \u003d copy.deepcopy("},{"line_number":29,"context_line":"    quota_classesv250.update_quota_class_set)"},{"line_number":30,"context_line":"for field in [\u0027injected_file_content_bytes\u0027, \u0027injected_file_path_bytes\u0027,"},{"line_number":31,"context_line":"              \u0027injected_files\u0027]:"},{"line_number":32,"context_line":"    get_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["},{"line_number":33,"context_line":"        \u0027properties\u0027].pop(field, None)"},{"line_number":34,"context_line":"    get_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["},{"line_number":35,"context_line":"        \u0027required\u0027].remove(field)"},{"line_number":36,"context_line":"    update_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_class_set\u0027]["},{"line_number":37,"context_line":"        \u0027properties\u0027].pop(field, None)"},{"line_number":38,"context_line":"    update_quota_class_set[\u0027response_body\u0027][\u0027properties\u0027]["},{"line_number":39,"context_line":"        \u0027quota_class_set\u0027][\u0027required\u0027].remove(field)"}],"source_content_type":"text/x-python","patch_set":2,"id":"add9360d_20246827","line":39,"range":{"start_line":21,"start_character":0,"end_line":39,"end_character":52},"updated":"2021-06-14 22:17:44.000000000","message":"these are covered in this right? https://github.com/openstack/tempest/blob/master/tempest/lib/api_schema/response/compute/v2_57/quotas.py","commit_id":"82f67d08f86c344e157064d242d2120882e691e9"}]}