)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f0b84e865a848176158238ddbef195b2c7b28989","unresolved":false,"context_lines":[{"line_number":7,"context_line":"object storage: fix and cleanup header checks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As explained in [1] it is not legitimate to require a Transfer-Encoding"},{"line_number":10,"context_line":"header in Swift responses. That prevents running some tests"},{"line_number":11,"context_line":"successfully in the case where Swift is behind a proxy/load-balancer"},{"line_number":12,"context_line":"that does not use any Transfer-Encoding in its responses."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change hence removes the checks for the presence of a"},{"line_number":15,"context_line":"\"Transfer-Encoding\" header, and replaces them by the use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_8b77aba0","line":12,"range":{"start_line":10,"start_character":26,"end_line":12,"end_character":57},"updated":"2020-06-24 09:38:38.000000000","message":"agree","commit_id":"f8a487f86f24caa3fea68adb78fae64381bb3d09"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f0b84e865a848176158238ddbef195b2c7b28989","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"Transfer-Encoding\" header, and replaces them by the use"},{"line_number":16,"context_line":"of the existing check methods, after modifying the"},{"line_number":17,"context_line":"custom_matcher checks on which these methods rely on to accept"},{"line_number":18,"context_line":"either a Content-Length or a Transfer-Encoding header."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some adaptation was also required to avoid trying to process \u0027etag\u0027"},{"line_number":21,"context_line":"for DELETE requests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_8b9ccbc0","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":46},"updated":"2020-06-24 09:38:38.000000000","message":"is it required?","commit_id":"f8a487f86f24caa3fea68adb78fae64381bb3d09"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"1943b8f024b6299d3c8913f1e215715e25d8d0a0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"Transfer-Encoding\" header, and replaces them by the use"},{"line_number":16,"context_line":"of the existing check methods, after modifying the"},{"line_number":17,"context_line":"custom_matcher checks on which these methods rely on to accept"},{"line_number":18,"context_line":"either a Content-Length or a Transfer-Encoding header."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some adaptation was also required to avoid trying to process \u0027etag\u0027"},{"line_number":21,"context_line":"for DELETE requests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_2b7bffbd","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":46},"in_reply_to":"bf51134e_8b9ccbc0","updated":"2020-06-24 10:13:35.000000000","message":"From a protocol standpoint, a response is valid if it contains either, so this is what the generic checks need to do once we unify them to support their existing callers (case where they check for content-length) and the new callers (that exercise swift code that responds with transfer-encoding only).\n\nWe could be stricter and mandate either Content-Length or Transfer-Encoding but prevent having both, but the HTTP specs seems to not really ban this, and this would I think be too zealous.","commit_id":"f8a487f86f24caa3fea68adb78fae64381bb3d09"}],"tempest/api/object_storage/test_object_slo.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8feba69de7909386a0f8d761156fb92ce9434c9","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            object_name,"},{"line_number":162,"context_line":"            params\u003dparams_del)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self._assertHeadersSLO(resp, \u0027DELETE\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        resp, body \u003d self.container_client.list_container_objects("},{"line_number":167,"context_line":"            self.container_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_b93d62c5","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":46},"updated":"2020-06-29 16:46:13.000000000","message":"let\u0027s use assertHeaders as you are making _assertHeadersSLO same as assertHeaders for delete request.","commit_id":"f8a487f86f24caa3fea68adb78fae64381bb3d09"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"75af4cd457cc70b843c03151415250bef86ddf3d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            object_name,"},{"line_number":162,"context_line":"            params\u003dparams_del)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self._assertHeadersSLO(resp, \u0027DELETE\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        resp, body \u003d self.container_client.list_container_objects("},{"line_number":167,"context_line":"            self.container_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_2a8c5234","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":46},"in_reply_to":"bf51134e_b93d62c5","updated":"2020-06-29 21:28:24.000000000","message":"Very good suggestion, thanks.\n\n(fixed in PS7)","commit_id":"f8a487f86f24caa3fea68adb78fae64381bb3d09"}]}