)]}'
{"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"13e3c9546c0e331c982fe377a6f976b2d4a4c25d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            self._live_migrate(server_id, source_host, state, volume_backed)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @decorators.idempotent_id(\u00271dce86b8-eb04-4c03-a9d8-9c1dc3ee0c7b\u0027)"},{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":127,"context_line":"                      block_migration_for_live_migration,"},{"line_number":128,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":129,"context_line":"    def test_live_block_migration(self):"},{"line_number":130,"context_line":"        \"\"\"Test live migrating an active server\"\"\""},{"line_number":131,"context_line":"        self._test_live_migration()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.idempotent_id(\u00271e107f21-61b2-4988-8f22-b196e938ab88\u0027)"},{"line_number":134,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":135,"context_line":"                      block_migration_for_live_migration,"},{"line_number":136,"context_line":"                      \u0027Block Live migration not available\u0027)   "},{"line_number":137,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"},{"line_number":138,"context_line":"                          \u0027Pause is not available.\u0027)"},{"line_number":139,"context_line":"    def test_live_block_migration_paused(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_70f049fe","line":136,"range":{"start_line":126,"start_character":0,"end_line":136,"end_character":62},"updated":"2020-06-23 21:28:57.000000000","message":"we do not need these as this test is already capped with max_version 2.24 L90\n\nand for microversion \u003e2.24, it run with block_migration\u003dauto in LiveAutoBlockMigrationV225Test L251","commit_id":"850e72387945c25662384c03a39f05a3d0e293a4"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"f539e05df69c1072109b45552f550adc707f764f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            self._live_migrate(server_id, source_host, state, volume_backed)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @decorators.idempotent_id(\u00271dce86b8-eb04-4c03-a9d8-9c1dc3ee0c7b\u0027)"},{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":127,"context_line":"                      block_migration_for_live_migration,"},{"line_number":128,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":129,"context_line":"    def test_live_block_migration(self):"},{"line_number":130,"context_line":"        \"\"\"Test live migrating an active server\"\"\""},{"line_number":131,"context_line":"        self._test_live_migration()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.idempotent_id(\u00271e107f21-61b2-4988-8f22-b196e938ab88\u0027)"},{"line_number":134,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":135,"context_line":"                      block_migration_for_live_migration,"},{"line_number":136,"context_line":"                      \u0027Block Live migration not available\u0027)   "},{"line_number":137,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"},{"line_number":138,"context_line":"                          \u0027Pause is not available.\u0027)"},{"line_number":139,"context_line":"    def test_live_block_migration_paused(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_79531518","line":136,"range":{"start_line":126,"start_character":0,"end_line":136,"end_character":62},"in_reply_to":"bf51134e_70f049fe","updated":"2020-06-23 23:02:57.000000000","message":"for the test \u003c2.24 with block_migration\u003dnone and no conf set for block_migration_for_live_migration this will fail as  this is getting the value from here conf file: https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_live_migration.py#L63-%23L67\nwhich doesn\u0027t exist so I still think for block level live migration it make sense to add this skip flags like if the value is not true this will run the api with block_migration\u003dnone and thus this will eventually run as shared storage live migration and failed","commit_id":"850e72387945c25662384c03a39f05a3d0e293a4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0ff52b0562d6f5491045ca5a3e10ed1220fbbe09","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            self._live_migrate(server_id, source_host, state, volume_backed)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @decorators.idempotent_id(\u00271dce86b8-eb04-4c03-a9d8-9c1dc3ee0c7b\u0027)"},{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":127,"context_line":"                      block_migration_for_live_migration,"},{"line_number":128,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":129,"context_line":"    def test_live_block_migration(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_6ecf0d7f","line":126,"range":{"start_line":126,"start_character":15,"end_line":126,"end_character":21},"updated":"2020-07-07 22:38:56.000000000","message":"maybe better to use skipUnless? we would avoid negation in the condition:\nhttps://testtools.readthedocs.io/en/latest/api.html#testtools.skipUnless\n\n@testtools.skipUnless(CONF.compute_feature_enabled.\n                      block_migration_for_live_migration,\n                      \u0027Block Live migration not available\u0027)","commit_id":"e43a4aa76c462a22cea9156ebc0ef7007e9a16aa"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"9413d20ce0374fd7e96954cf633180153bef0c63","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            self._live_migrate(server_id, source_host, state, volume_backed)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @decorators.idempotent_id(\u00271dce86b8-eb04-4c03-a9d8-9c1dc3ee0c7b\u0027)"},{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":127,"context_line":"                      block_migration_for_live_migration,"},{"line_number":128,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":129,"context_line":"    def test_live_block_migration(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_89ac108d","line":126,"range":{"start_line":126,"start_character":15,"end_line":126,"end_character":21},"in_reply_to":"bf51134e_6ecf0d7f","updated":"2020-07-10 01:07:29.000000000","message":"done","commit_id":"e43a4aa76c462a22cea9156ebc0ef7007e9a16aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0ff52b0562d6f5491045ca5a3e10ed1220fbbe09","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self._test_live_migration()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.idempotent_id(\u00271e107f21-61b2-4988-8f22-b196e938ab88\u0027)"},{"line_number":134,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":135,"context_line":"                      block_migration_for_live_migration,"},{"line_number":136,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":137,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_aec92579","line":134,"range":{"start_line":134,"start_character":15,"end_line":134,"end_character":21},"updated":"2020-07-07 22:38:56.000000000","message":"the same as above","commit_id":"e43a4aa76c462a22cea9156ebc0ef7007e9a16aa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7934031eab394f18e0de761e67fdec0917f1b493","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if self.block_migration is None:"},{"line_number":63,"context_line":"            if self.is_requested_microversion_compatible(\u00272.24\u0027):"},{"line_number":64,"context_line":"                kwargs[\u0027disk_over_commit\u0027] \u003d False"},{"line_number":65,"context_line":"            block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":66,"context_line":"                               block_migration_for_live_migration and"},{"line_number":67,"context_line":"                               not volume_backed)"},{"line_number":68,"context_line":"        self.admin_servers_client.live_migrate_server("},{"line_number":69,"context_line":"            server_id, host\u003ddest_host, block_migration\u003dblock_migration,"},{"line_number":70,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_b0531339","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":49},"updated":"2020-07-10 05:59:15.000000000","message":"Sorry I didn\u0027t catch the issue,\nif CONF.compute_feature_enabled.block_migration_for_live_migration is set to False, that means the environment doesn\u0027t support block migration(e.g.,ceph), so, block_migration will set to False, what\u0027s wrong with this logic?","commit_id":"e18335e1a221cb2ff4c84e27d0dd122f968e3c42"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1c52c66ced2e618e8ddd7beb567c21f9fdf78354","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if self.block_migration is None:"},{"line_number":63,"context_line":"            if self.is_requested_microversion_compatible(\u00272.24\u0027):"},{"line_number":64,"context_line":"                kwargs[\u0027disk_over_commit\u0027] \u003d False"},{"line_number":65,"context_line":"            block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":66,"context_line":"                               block_migration_for_live_migration and"},{"line_number":67,"context_line":"                               not volume_backed)"},{"line_number":68,"context_line":"        self.admin_servers_client.live_migrate_server("},{"line_number":69,"context_line":"            server_id, host\u003ddest_host, block_migration\u003dblock_migration,"},{"line_number":70,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_0bb164e2","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":49},"in_reply_to":"bf51134e_8b94da8c","updated":"2020-08-14 00:04:39.000000000","message":"yeah this block is run for LiveMigrationTest which has microversion capped to 2.24 so skipping the block migration tests if block_migration_for_live_migration\u003dFalse is right thing.","commit_id":"e18335e1a221cb2ff4c84e27d0dd122f968e3c42"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"d8f8dee995ebcb89d8561c614d357800db900065","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if self.block_migration is None:"},{"line_number":63,"context_line":"            if self.is_requested_microversion_compatible(\u00272.24\u0027):"},{"line_number":64,"context_line":"                kwargs[\u0027disk_over_commit\u0027] \u003d False"},{"line_number":65,"context_line":"            block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":66,"context_line":"                               block_migration_for_live_migration and"},{"line_number":67,"context_line":"                               not volume_backed)"},{"line_number":68,"context_line":"        self.admin_servers_client.live_migrate_server("},{"line_number":69,"context_line":"            server_id, host\u003ddest_host, block_migration\u003dblock_migration,"},{"line_number":70,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_8b94da8c","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":49},"in_reply_to":"bf51134e_b0531339","updated":"2020-07-10 15:54:25.000000000","message":"Yes that\u0027s correct but the problem for-ex In non-ceph env when we don\u0027t set the parameter in tempest.conf this would add block_migration\u003d false at micro_version 2.24 and assume to be running the migration as shared storage live migration and thus it failed. So the user should set/unset this value as per the deployment and if it\u0027s not set then we shouldn\u0027t be running block migration at all.\n\nHowever just FYI, this works fine on LiveAutoBlockMigrationV225Test with min_microversion \u003d2.25 but we observe this only in 2.24 microversion\n\nThis is where gmann was able to reproduce it:\nhttps://review.opendev.org/#/c/737658/","commit_id":"e18335e1a221cb2ff4c84e27d0dd122f968e3c42"}]}