)]}'
{"tempest/api/compute/v3/admin/test_migrations.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"85d6407b139f0dd9586988492238f3d930cda518","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B8eM%3D","line":1,"updated":"2014-02-18 03:45:58.000000000","message":"Is this file copied from v2? If you\u0027ve wrote this file originally, this copyright is probably wrong.","commit_id":"defe9a6930603024d8adf178f709400ac3bb13fb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"98d1bdddf7bac65e37594bd0cda3056b70cdb207","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B8Ks%3D","line":1,"in_reply_to":"AAAAUX%2F%2B8eM%3D","updated":"2014-02-18 03:53:53.000000000","message":"Nice point, will change here","commit_id":"defe9a6930603024d8adf178f709400ac3bb13fb"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"85d6407b139f0dd9586988492238f3d930cda518","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        body \u003d body[\u0027objects\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        found \u003d False"},{"line_number":56,"context_line":"        for migration in body:"},{"line_number":57,"context_line":"            instance_uuid \u003d migration[\u0027instance_uuid\u0027]"},{"line_number":58,"context_line":"            if instance_uuid \u003d\u003d server_id:"},{"line_number":59,"context_line":"                found \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B8Oo%3D","line":56,"updated":"2014-02-18 03:45:58.000000000","message":"I\u0027m not sure whether this is correct. I think the response body is like below as you\u0027ve wrote in the commit message:\n\n {\"migrations\": [\n  {\"instance_uuid\": \"4ed20c05-6bcb-46c5-a6a4-115523660283\",\n      :\n  \"new_instance_type_id\": 7},\n  {\"instance_uuid\": \"4ed20c05-6bcb-46c5-a6a4-115523660284\",\n      :\n  \"new_instance_type_id\": 7},\n ]}\n\nSo \u0027for migration in body:\u0027 gets only one dict {\u0027migrations\u0027: [...]} here. Do I misunderstand?","commit_id":"defe9a6930603024d8adf178f709400ac3bb13fb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"98d1bdddf7bac65e37594bd0cda3056b70cdb207","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        body \u003d body[\u0027objects\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        found \u003d False"},{"line_number":56,"context_line":"        for migration in body:"},{"line_number":57,"context_line":"            instance_uuid \u003d migration[\u0027instance_uuid\u0027]"},{"line_number":58,"context_line":"            if instance_uuid \u003d\u003d server_id:"},{"line_number":59,"context_line":"                found \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B8LE%3D","line":56,"in_reply_to":"AAAAUX%2F%2B8Oo%3D","updated":"2014-02-18 03:53:53.000000000","message":"\u0027migrations\u0027 has been already removed because of _parse_resp() of https://review.openstack.org/#/c/73995/2/tempest/services/compute/v3/json/migration_client.py . The method has been implemented during client refactoring.\n\nhttps://github.com/openstack/tempest/blob/master/tempest/common/rest_client.py#L270","commit_id":"defe9a6930603024d8adf178f709400ac3bb13fb"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"85d6407b139f0dd9586988492238f3d930cda518","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            instance_uuid \u003d migration[\u0027instance_uuid\u0027]"},{"line_number":58,"context_line":"            if instance_uuid \u003d\u003d server_id:"},{"line_number":59,"context_line":"                found \u003d True"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.assertTrue(found)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B8Ow%3D","line":60,"updated":"2014-02-18 03:45:58.000000000","message":"Can we write with 1 line here instead of above 5 lines?\n\n  server_id in [(m[\u0027instance_uuid\u0027]) for m in body]","commit_id":"defe9a6930603024d8adf178f709400ac3bb13fb"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"34e6dc75b49f50aee50edac640b035a24a1d7e9b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class MigrationsAdminV3Test(base.BaseV3ComputeAdminTest):"},{"line_number":25,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":28,"context_line":"    def test_list_migrations(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BPR4%3D","line":25,"updated":"2014-03-28 06:53:15.000000000","message":"we don\u0027t need _interface for json in compute tests now as it is in base class.","commit_id":"79989bdfeee9c3ee013715df544665830e380214"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a3c91b4a66ce65e4e0dcdc57382dcab0de975d9","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class MigrationsAdminV3Test(base.BaseV3ComputeAdminTest):"},{"line_number":25,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":28,"context_line":"    def test_list_migrations(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BPPY%3D","line":25,"in_reply_to":"AAAAWH%2F%2BPR4%3D","updated":"2014-03-28 07:03:47.000000000","message":"Nice catch, thanks!","commit_id":"79989bdfeee9c3ee013715df544665830e380214"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"34e6dc75b49f50aee50edac640b035a24a1d7e9b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            if migration[\u0027instance_uuid\u0027] \u003d\u003d server_id:"},{"line_number":53,"context_line":"                found \u003d True"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.assertTrue(found)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BPRk%3D","line":55,"updated":"2014-03-28 06:53:15.000000000","message":"we could use list comprehension to check instance uuid\n\ne.g.\n aaa \u003d  [ x[\u0027instance_uuid\u0027] for x in body ]\n assertIn(server_id, aaa, \"xxx\")","commit_id":"79989bdfeee9c3ee013715df544665830e380214"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a3c91b4a66ce65e4e0dcdc57382dcab0de975d9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            if migration[\u0027instance_uuid\u0027] \u003d\u003d server_id:"},{"line_number":53,"context_line":"                found \u003d True"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.assertTrue(found)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BPPA%3D","line":55,"in_reply_to":"AAAAWH%2F%2BPRk%3D","updated":"2014-03-28 07:03:47.000000000","message":"Nice idea, I will apply it.\nThanks","commit_id":"79989bdfeee9c3ee013715df544665830e380214"}]}