)]}'
{"tempest/api/compute/admin/test_hypervisor.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5e23faf200e5d2aa111b2ea1aefd7a5427348536","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setup_credentials(cls):"},{"line_number":25,"context_line":"        if CONF.compute_feature_enabled.enforce_scope:"},{"line_number":26,"context_line":"            cls.credentials \u003d [\u0027system_reader\u0027]"},{"line_number":27,"context_line":"        super(HypervisorAdminTestBase, cls).setup_credentials()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8f6086d1","line":25,"updated":"2020-07-09 00:50:26.000000000","message":"pep8: F821 undefined name \u0027CONF\u0027","commit_id":"b8960f43319a1b45c7f0fe7fa441ee2249194d56"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5e23faf200e5d2aa111b2ea1aefd7a5427348536","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def setup_clients(cls):"},{"line_number":31,"context_line":"        super(HypervisorAdminTestBase, cls).setup_clients()"},{"line_number":32,"context_line":"        if CONF.compute_feature_enabled.enforce_scope:"},{"line_number":33,"context_line":"            cls.client \u003d cls.os_system_reader.hypervisor_client"},{"line_number":34,"context_line":"        else:"},{"line_number":35,"context_line":"            cls.client \u003d cls.os_admin.hypervisor_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6f5d3214","line":32,"updated":"2020-07-09 00:50:26.000000000","message":"pep8: F821 undefined name \u0027CONF\u0027","commit_id":"b8960f43319a1b45c7f0fe7fa441ee2249194d56"}],"tempest/config.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8df25caab4ea8050c942153ceae6cf285604534e","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                help\u003d\u0027Does the test environment support attaching a volume to \u0027"},{"line_number":612,"context_line":"                     \u0027more than one instance? This depends on hypervisor and \u0027"},{"line_number":613,"context_line":"                     \u0027volume backend/type and compute API version 2.60.\u0027),"},{"line_number":614,"context_line":"    cfg.BoolOpt(\u0027enforce_scope\u0027,"},{"line_number":615,"context_line":"                default\u003dFalse,"},{"line_number":616,"context_line":"                help\u003d\u0027Does the compute service API policies enforce scope?\u0027),"},{"line_number":617,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_47b7c387","line":614,"range":{"start_line":614,"start_character":17,"end_line":614,"end_character":30},"updated":"2020-08-15 18:34:43.000000000","message":"I have a question about this. Technically there is project scope and domain scope: https://docs.openstack.org/keystone/latest/contributor/services.html\n\nKeystone defines scope pretty openly. Nova in the spec also says scope can be \"project\" or \"system\": https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/policy-defaults-refresh.html#scope\n\nSo should this be enforce_system_scope because that is what you are using it for? I don\u0027t think this will ever be used for domain scoping or anything.","commit_id":"e79caecd23808f2123d243a6b9d61f66d37ef962"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5373fb4ee656b647ca53419678b6a4f27a0f0ceb","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                help\u003d\u0027Does the test environment support attaching a volume to \u0027"},{"line_number":612,"context_line":"                     \u0027more than one instance? This depends on hypervisor and \u0027"},{"line_number":613,"context_line":"                     \u0027volume backend/type and compute API version 2.60.\u0027),"},{"line_number":614,"context_line":"    cfg.BoolOpt(\u0027enforce_scope\u0027,"},{"line_number":615,"context_line":"                default\u003dFalse,"},{"line_number":616,"context_line":"                help\u003d\u0027Does the compute service API policies enforce scope?\u0027),"},{"line_number":617,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_be3f4f84","line":614,"range":{"start_line":614,"start_character":17,"end_line":614,"end_character":30},"in_reply_to":"9f560f44_47b7c387","updated":"2020-10-09 19:11:31.000000000","message":"actually, this flag is for - if service enabled the CONF.oslo_policy.enforce_scope then we have to pass the appropriate scope (for nova case it is project or system). If CONF.oslo_policy.enforce_scope is True on any service side then oslo policy will start enforcing the scope checks. So in Tempest if this flag (which is corresponding to CONF.oslo_policy.enforce_scope) is true then we should pass credential corresponding to the policy default scope which can be project or system or domain.","commit_id":"e79caecd23808f2123d243a6b9d61f66d37ef962"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8df25caab4ea8050c942153ceae6cf285604534e","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                     \u0027volume backend/type and compute API version 2.60.\u0027),"},{"line_number":614,"context_line":"    cfg.BoolOpt(\u0027enforce_scope\u0027,"},{"line_number":615,"context_line":"                default\u003dFalse,"},{"line_number":616,"context_line":"                help\u003d\u0027Does the compute service API policies enforce scope?\u0027),"},{"line_number":617,"context_line":"]"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_27bc4f68","line":616,"range":{"start_line":616,"start_character":68,"end_line":616,"end_character":73},"updated":"2020-08-15 18:34:43.000000000","message":"Same question: Should this say \"system scope\" instead?","commit_id":"e79caecd23808f2123d243a6b9d61f66d37ef962"}]}