)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expand baremetal nodes coverage `POST`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add `POST` tests for create baremetal nodes API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I3172601a063a106a81103e6e55592727014f064c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1ae5cdf2_8e9c2bc2","line":9,"updated":"2014-06-11 04:09:24.000000000","message":"Please provide some more details in commit msg about changes. same way as comment in https://review.openstack.org/#/c/71476/16//COMMIT_MSG","commit_id":"f4a67a590204ba7081a5d2d7ce9ef1904d71b266"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expand baremetal nodes coverage `POST`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add `POST` tests for create baremetal nodes API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I3172601a063a106a81103e6e55592727014f064c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1ae5cdf2_23296537","line":9,"in_reply_to":"1ae5cdf2_8e9c2bc2","updated":"2014-06-11 11:29:53.000000000","message":"Done","commit_id":"f4a67a590204ba7081a5d2d7ce9ef1904d71b266"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expand baremetal nodes coverage `POST`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Expan `POST` tests for create baremetal nodes API:"},{"line_number":10,"context_line":"    - expand post tests"},{"line_number":11,"context_line":"    - added negative post tests"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_9bf8c27d","line":9,"updated":"2014-06-12 02:57:02.000000000","message":"typo Expan-\u003eExpand","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expand baremetal nodes coverage `POST`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Expan `POST` tests for create baremetal nodes API:"},{"line_number":10,"context_line":"    - expand post tests"},{"line_number":11,"context_line":"    - added negative post tests"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_dde15a9c","line":9,"in_reply_to":"1ae5cdf2_9bf8c27d","updated":"2014-06-12 07:33:44.000000000","message":"Oops! :)","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":9,"context_line":"Expan `POST` tests for create baremetal nodes API:"},{"line_number":10,"context_line":"    - expand post tests"},{"line_number":11,"context_line":"    - added negative post tests"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3172601a063a106a81103e6e55592727014f064c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_bbf57e84","line":12,"updated":"2014-06-12 02:57:02.000000000","message":"Also mention about the config addition.","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":9,"context_line":"Expan `POST` tests for create baremetal nodes API:"},{"line_number":10,"context_line":"    - expand post tests"},{"line_number":11,"context_line":"    - added negative post tests"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3172601a063a106a81103e6e55592727014f064c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_1def4288","line":12,"in_reply_to":"1ae5cdf2_bbf57e84","updated":"2014-06-12 07:33:44.000000000","message":"Will do!","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"}],"tempest/api/baremetal/test_nodes.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"b8bb4e7130806dcc450a2d957566b16571d127bc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        for key in params:"},{"line_number":48,"context_line":"                self.assertEqual(node[\u0027properties\u0027][key], params[key])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":51,"context_line":"    def test_create_node_with_specifying_uuid(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9%2BAg%3D","line":48,"updated":"2014-03-31 20:55:59.000000000","message":"Why this over indentation?","commit_id":"7f51769c4c8753159fbe6022e023933fe838a7aa"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"3e214855e107e158015ac9246b6d556f908b1d62","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        for key in params:"},{"line_number":48,"context_line":"                self.assertEqual(node[\u0027properties\u0027][key], params[key])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":51,"context_line":"    def test_create_node_with_specifying_uuid(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9wZs%3D","line":48,"in_reply_to":"AAAAWH%2F9%2BAg%3D","updated":"2014-04-02 10:40:22.000000000","message":"Need to fix pep8 there: we should use 4 white spaces.","commit_id":"7f51769c4c8753159fbe6022e023933fe838a7aa"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"b8bb4e7130806dcc450a2d957566b16571d127bc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                self.assertEqual(node[\u0027properties\u0027][key], params[key])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":51,"context_line":"    def test_create_node_with_specifying_uuid(self):"},{"line_number":52,"context_line":"        chassis_id \u003d self.chassis[\u0027uuid\u0027]"},{"line_number":53,"context_line":"        params \u003d {\u0027cpu_arch\u0027: \u0027x86_64\u0027,"},{"line_number":54,"context_line":"                  \u0027cpu_num\u0027: \u002712\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9%2BAQ%3D","line":51,"updated":"2014-03-31 20:55:59.000000000","message":"The content of all these tests is almost the same and should not be copy/pasted as more tests are added. The common setup and assertion code should be abstracted into a helper method.","commit_id":"7f51769c4c8753159fbe6022e023933fe838a7aa"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"3e214855e107e158015ac9246b6d556f908b1d62","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        for key in params:"},{"line_number":70,"context_line":"                self.assertEqual(node[\u0027properties\u0027][key], params[key])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":73,"context_line":"    def test_create_node_with_extra(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9wZw%3D","line":70,"updated":"2014-04-02 10:40:22.000000000","message":"Need to fix pep8 there: we should use 4 white spaces.","commit_id":"7f51769c4c8753159fbe6022e023933fe838a7aa"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"3e214855e107e158015ac9246b6d556f908b1d62","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        for key in params:"},{"line_number":93,"context_line":"                self.assertEqual(node[\u0027properties\u0027][key], params[key])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":96,"context_line":"    def test_delete_node(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9wZo%3D","line":93,"updated":"2014-04-02 10:40:22.000000000","message":"Need to fix pep8 there: we should use 4 white spaces.","commit_id":"7f51769c4c8753159fbe6022e023933fe838a7aa"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"3e214855e107e158015ac9246b6d556f908b1d62","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        for key in self.params:"},{"line_number":48,"context_line":"                self.assertEqual(node[\u0027properties\u0027][key], self.params[key])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":51,"context_line":"    def test_create_node_with_specifying_uuid(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F9Rbs%3D","line":48,"updated":"2014-04-07 14:03:36.000000000","message":"Need to fix pep8 here. Please, use only 4 white spaces.","commit_id":"d27b5dce2c6ff2871d47162cca48113d85229174"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"3e214855e107e158015ac9246b6d556f908b1d62","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        for key in self.params:"},{"line_number":65,"context_line":"                self.assertEqual(node[\u0027properties\u0027][key], self.params[key])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":68,"context_line":"    def test_create_node_with_extra(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F9Rbg%3D","line":65,"updated":"2014-04-07 14:03:36.000000000","message":"Need to fix pep8 here. Please, use only 4 white spaces.","commit_id":"d27b5dce2c6ff2871d47162cca48113d85229174"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"3e214855e107e158015ac9246b6d556f908b1d62","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        for key in self.params:"},{"line_number":83,"context_line":"                self.assertEqual(node[\u0027properties\u0027][key], self.params[key])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":86,"context_line":"    def test_delete_node(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F9Rbc%3D","line":83,"updated":"2014-04-07 14:03:36.000000000","message":"Need to fix pep8 here. Please, use only 4 white spaces.","commit_id":"d27b5dce2c6ff2871d47162cca48113d85229174"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"2903fad73936d7a7362216c379fc4a99edb77026","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        self.chassis \u003d self.create_chassis()[\u0027chassis\u0027]"},{"line_number":28,"context_line":"        self.chassis_id \u003d self.chassis[\u0027uuid\u0027]"},{"line_number":29,"context_line":"        self.params \u003d {\u0027cpu_arch\u0027: \u0027x86_64\u0027,"},{"line_number":30,"context_line":"                       \u0027cpu_num\u0027: \u002712\u0027,"},{"line_number":31,"context_line":"                       \u0027storage\u0027: \u002710240\u0027,"},{"line_number":32,"context_line":"                       \u0027memory\u0027: \u00271024\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FVY4%3D","line":29,"updated":"2014-04-22 13:07:45.000000000","message":"this really can\u0027t be hard coded. It seems to be coming from the conf file.","commit_id":"842a8918b9186c651f00cb72b031fe44395fc66f"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        self.chassis \u003d self.create_chassis()[\u0027chassis\u0027]"},{"line_number":28,"context_line":"        self.chassis_id \u003d self.chassis[\u0027uuid\u0027]"},{"line_number":29,"context_line":"        self.params \u003d {\u0027cpu_arch\u0027: \u0027x86_64\u0027,"},{"line_number":30,"context_line":"                       \u0027cpu_num\u0027: \u002712\u0027,"},{"line_number":31,"context_line":"                       \u0027storage\u0027: \u002710240\u0027,"},{"line_number":32,"context_line":"                       \u0027memory\u0027: \u00271024\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FBh8%3D","line":29,"in_reply_to":"AAAAXH%2F%2FVY4%3D","updated":"2014-04-24 15:21:10.000000000","message":"Will do! :)","commit_id":"842a8918b9186c651f00cb72b031fe44395fc66f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.create_node(self.chassis_id, uuid\u003duuid, **self.params)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        resp, node \u003d self.client.show_node(uuid)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":52,"context_line":"        self.assertEqual(uuid, node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_2b0a2926","line":49,"updated":"2014-06-11 04:09:24.000000000","message":"code can be reused among previous, next and this test-\n\n_verify_created_node(uuid) \n    resp, node \u003d self.client.show_node(node_id)\t\n    node \u003d self.create_node(self.chassis[\u0027uuid\u0027], **params)[\u0027node\u0027]\t     \n    self.assertEqual(200, resp.status)\t\n    self.assertEqual(node_id, node[\u0027uuid\u0027])\t\n    self.assertEqual({}, node[\u0027extra\u0027])\t\n    self.assertIsNotNone(node[\u0027created_at\u0027])\t\n    self.assertIsNone(node[\u0027updated_at\u0027])\t\n\n    for key in self.params:\t\n        self.assertEqual(node[\u0027properties\u0027][key], self.params[key])","commit_id":"f4a67a590204ba7081a5d2d7ce9ef1904d71b266"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.create_node(self.chassis_id, uuid\u003duuid, **self.params)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        resp, node \u003d self.client.show_node(uuid)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":52,"context_line":"        self.assertEqual(uuid, node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_e8503a34","line":49,"in_reply_to":"1ae5cdf2_2b0a2926","updated":"2014-06-11 11:29:53.000000000","message":"Done","commit_id":"f4a67a590204ba7081a5d2d7ce9ef1904d71b266"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestNodes(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \u0027\u0027\u0027Tests for baremetal nodes.\u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _verify_created_node(self, uuid, extra\u003dNone):"},{"line_number":28,"context_line":"        resp, node \u003d self.client.show_node(uuid)"},{"line_number":29,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":30,"context_line":"        self.assertEqual(uuid, node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_3bc08e4f","line":27,"updated":"2014-06-12 02:57:02.000000000","message":"make \u0027extra\u0027 default as \u0027{}\u0027 so that we can get rid of if else.","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestNodes(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \u0027\u0027\u0027Tests for baremetal nodes.\u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _verify_created_node(self, uuid, extra\u003dNone):"},{"line_number":28,"context_line":"        resp, node \u003d self.client.show_node(uuid)"},{"line_number":29,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":30,"context_line":"        self.assertEqual(uuid, node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_71977348","line":27,"in_reply_to":"1ae5cdf2_2a491131","updated":"2014-06-13 02:00:29.000000000","message":"oh yes, sorry i missed the mutable/immutable here.\n\nThanks for clarification.","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestNodes(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \u0027\u0027\u0027Tests for baremetal nodes.\u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _verify_created_node(self, uuid, extra\u003dNone):"},{"line_number":28,"context_line":"        resp, node \u003d self.client.show_node(uuid)"},{"line_number":29,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":30,"context_line":"        self.assertEqual(uuid, node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_9df8b27d","line":27,"in_reply_to":"1ae5cdf2_3bc08e4f","updated":"2014-06-12 07:33:44.000000000","message":"not quite, look at the method `test_create_node_with_extra` L53.","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestNodes(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \u0027\u0027\u0027Tests for baremetal nodes.\u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _verify_created_node(self, uuid, extra\u003dNone):"},{"line_number":28,"context_line":"        resp, node \u003d self.client.show_node(uuid)"},{"line_number":29,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":30,"context_line":"        self.assertEqual(uuid, node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_e45a02f1","line":27,"in_reply_to":"1ae5cdf2_9df8b27d","updated":"2014-06-12 08:23:54.000000000","message":"I means \"extra\"\u0027s default value to change from \u0027None\u0027 to \"{}\" So that if else condition can be removed. like below-\ndef _verify_created_node(self, uuid, extra\u003d{}):\n    resp, node \u003d self.client.show_node(uuid)\n    self.assertEqual(200, resp.status)\n    self.assertEqual(uuid, node[\u0027uuid\u0027])\n    self.assertEqual(extra, node[\u0027extra\u0027])\n    self.assertIsNotNone(node[\u0027created_at\u0027])\n    for key in self.params:\n        self.assertEqual(node[\u0027properties\u0027][key],  \n                               self.params[key])","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestNodes(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \u0027\u0027\u0027Tests for baremetal nodes.\u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _verify_created_node(self, uuid, extra\u003dNone):"},{"line_number":28,"context_line":"        resp, node \u003d self.client.show_node(uuid)"},{"line_number":29,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":30,"context_line":"        self.assertEqual(uuid, node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_2a491131","line":27,"in_reply_to":"1ae5cdf2_e45a02f1","updated":"2014-06-12 09:23:06.000000000","message":"Hmmm... Please look at the comment Daryl Walleck in [1]. He describes why shouldn\u0027t do the default value the mutable data type.\n[1] https://review.openstack.org/#/c/71476/15/tempest/api/baremetal/base.py,cm","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if extra:"},{"line_number":32,"context_line":"            self.assertEqual(extra, node[\u0027extra\u0027])"},{"line_number":33,"context_line":"        else:"},{"line_number":34,"context_line":"            self.assertEqual({}, node[\u0027extra\u0027])"},{"line_number":35,"context_line":"        self.assertIsNotNone(node[\u0027created_at\u0027])"},{"line_number":36,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":37,"context_line":"        for key in self.params:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_3ba7aebe","line":34,"updated":"2014-06-12 02:57:02.000000000","message":"if else can be just replaced by self.assertEqual(extra, node[\u0027extra\u0027]) with \u0027extra\u0027 as default \u0027{}\u0027 as mentioned above.","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if extra:"},{"line_number":32,"context_line":"            self.assertEqual(extra, node[\u0027extra\u0027])"},{"line_number":33,"context_line":"        else:"},{"line_number":34,"context_line":"            self.assertEqual({}, node[\u0027extra\u0027])"},{"line_number":35,"context_line":"        self.assertIsNotNone(node[\u0027created_at\u0027])"},{"line_number":36,"context_line":"        self.assertIsNone(node[\u0027updated_at\u0027])"},{"line_number":37,"context_line":"        for key in self.params:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_5d09ca82","line":34,"in_reply_to":"1ae5cdf2_3ba7aebe","updated":"2014-06-12 07:33:44.000000000","message":"ditto about `extra`","commit_id":"4c41fcd9be78523f520ce9020ad488f0587bdae7"}],"tempest/api/baremetal/test_nodes_negative.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"class TestNodesNegative(base.BaseBaremetalTest):"},{"line_number":23,"context_line":"    \"\"\"Negative tests for nodes.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(TestNodesNegative, self).setUp()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        self.chassis \u003d self.create_chassis()[\u0027chassis\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_acd4f647","line":25,"updated":"2014-05-21 11:31:29.000000000","message":"Do you really need setUp method? Maybe it is better to use setUpClass method here?","commit_id":"6afc3537301175e324282716194d7c6bb2421b7e"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"unresolved":false,"context_lines":[{"line_number":915,"context_line":"    cfg.IntOpt(\u0027unprovision_timeout\u0027,"},{"line_number":916,"context_line":"               default\u003d20,"},{"line_number":917,"context_line":"               help\u003d\"Timeout for unprovisioning an Ironic node.\"),"},{"line_number":918,"context_line":"    cfg.DictOpt(\u0027params\u0027, default\u003d{\u0027cpu_arch\u0027: \u0027x86_64\u0027,"},{"line_number":919,"context_line":"                                   \u0027cpu_num\u0027: \u002712\u0027,"},{"line_number":920,"context_line":"                                   \u0027storage\u0027: \u002710240\u0027,"},{"line_number":921,"context_line":"                                   \u0027memory\u0027: \u00271024\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_4e5f830f","line":918,"updated":"2014-06-11 04:09:24.000000000","message":"if it needs to go to config then, please five it some meaning full name. for example - \u0027ironic_node\u0027","commit_id":"f4a67a590204ba7081a5d2d7ce9ef1904d71b266"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"unresolved":false,"context_lines":[{"line_number":915,"context_line":"    cfg.IntOpt(\u0027unprovision_timeout\u0027,"},{"line_number":916,"context_line":"               default\u003d20,"},{"line_number":917,"context_line":"               help\u003d\"Timeout for unprovisioning an Ironic node.\"),"},{"line_number":918,"context_line":"    cfg.DictOpt(\u0027params\u0027, default\u003d{\u0027cpu_arch\u0027: \u0027x86_64\u0027,"},{"line_number":919,"context_line":"                                   \u0027cpu_num\u0027: \u002712\u0027,"},{"line_number":920,"context_line":"                                   \u0027storage\u0027: \u002710240\u0027,"},{"line_number":921,"context_line":"                                   \u0027memory\u0027: \u00271024\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_97b8b712","line":918,"in_reply_to":"1ae5cdf2_4e5f830f","updated":"2014-06-11 11:29:53.000000000","message":"Done","commit_id":"f4a67a590204ba7081a5d2d7ce9ef1904d71b266"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"unresolved":false,"context_lines":[{"line_number":932,"context_line":"               help\u003d\"Timeout for Ironic power transitions.\"),"},{"line_number":933,"context_line":"    cfg.IntOpt(\u0027unprovision_timeout\u0027,"},{"line_number":934,"context_line":"               default\u003d20,"},{"line_number":935,"context_line":"               help\u003d\"Timeout for unprovisioning an Ironic node.\"),"},{"line_number":936,"context_line":"    cfg.DictOpt(\u0027ironic_node\u0027, default\u003d{\u0027cpu_arch\u0027: \u0027x86_64\u0027,"},{"line_number":937,"context_line":"                                        \u0027cpu_num\u0027: \u002712\u0027,"},{"line_number":938,"context_line":"                                        \u0027storage\u0027: \u002710240\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_39bb8de5","line":935,"updated":"2014-06-24 23:13:38.000000000","message":"I don\u0027t think we need a config option to specify these parameters -- the API tests exercise the ability to create, update, and delete a node, but the actual key/value pairs used do not matter for these tests.\n\nInstead, what does matter is which driver we use. For instance, if the \"fake\" driver is not present, the API tests should probably not run.\n\nInstead of this option, I would suggest adding this:\n\n  cfg.StrOpt(\u0027admin_driver\u0027,\n    default\u003d\u0027fake\u0027,\n    help\u003d\"Specify which driver to use when exercising create/update/delete \"\n      \"operations in Ironic\u0027s admin API. Using an actual hardware driver with \"\n      \"these tests is not recommended.\")","commit_id":"7940d05fabc0ae2d5ac0515def8f661486f364c2"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"unresolved":false,"context_lines":[{"line_number":969,"context_line":"               help\u003d\"Specify which driver to use when exercising \""},{"line_number":970,"context_line":"                    \"create/update/delete operations in Ironic\u0027s admin API. \""},{"line_number":971,"context_line":"                    \"Using an actual hardware driver with \""},{"line_number":972,"context_line":"                    \"these tests is not recommended.\")"},{"line_number":973,"context_line":"]"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"cli_group \u003d cfg.OptGroup(name\u003d\u0027cli\u0027, title\u003d\"cli Configuration Options\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_f4107102","line":972,"updated":"2014-07-29 22:29:46.000000000","message":"This isn\u0027t needed anymore, a similar config option was added @ https://review.openstack.org/#/c/92996/4 that can be used for the same purpose.","commit_id":"00dbf2073de8ab80ef5422ce13911f34b7cb42a6"}]}