)]}'
{"tempest/api/compute/servers/test_multiple_large_availability.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5526e21f0320afdb6a85948b587c46861e2ef6aa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def setUpClass(cls):"},{"line_number":47,"context_line":"        super(MultipleLargeAvailability, cls).setUpClass()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":21,"id":"7adec928_fc2049b2","line":46,"updated":"2014-05-09 18:36:20.000000000","message":"Not needed","commit_id":"584506a2d7d8d8e929a8102873ff9377625daed7"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5526e21f0320afdb6a85948b587c46861e2ef6aa","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        super(MultipleLargeAvailability, cls).setUpClass()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def tearDownClass(cls):"},{"line_number":51,"context_line":"        super(MultipleLargeAvailability, cls).tearDownClass()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _attach_and_register_floating_ip(self, server):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7adec928_3c2b9195","line":50,"updated":"2014-05-09 18:36:20.000000000","message":"Not needed.","commit_id":"584506a2d7d8d8e929a8102873ff9377625daed7"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b77d5b32df7a1e388adf9f402692207bb504d066","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Dassault Systemes"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":22,"id":"7adec928_a60ed8e3","line":1,"updated":"2014-05-21 08:18:07.000000000","message":"I think this test should be in tempest/stress/actions because this test is not for api test.","commit_id":"5ba4039b5873450f2c29f89a25d54ba451791e8c"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"bf3246d2274250af188c196f905ab0d73872a502","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.create_test_server(**kwargs)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @testtools.skipUnless(CONF.compute.run_ssh,"},{"line_number":211,"context_line":"                          \u0027Instance availability through SSH disabled\u0027)"},{"line_number":212,"context_line":"    @testtools.skipUnless(CONF.stress.max_instances \u003e 0,"},{"line_number":213,"context_line":"                          \u0027Not enough required servers to test\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3ae8d1ca_612ab77f","line":210,"updated":"2014-05-29 05:45:09.000000000","message":"Can you remove this condition ?\nThe run_ssh option will be deprecated, and disabled by default.","commit_id":"0e7c01fd5685803c33dad886be829d434874a862"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"9d7bc8fcacbe579e17e86930c63bed498759fbcb","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.create_test_server(**kwargs)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @testtools.skipUnless(CONF.compute.run_ssh,"},{"line_number":211,"context_line":"                          \u0027Instance availability through SSH disabled\u0027)"},{"line_number":212,"context_line":"    @testtools.skipUnless(CONF.stress.max_instances \u003e 0,"},{"line_number":213,"context_line":"                          \u0027Not enough required servers to test\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1ae5cdf2_e2e60e16","line":210,"in_reply_to":"3ae8d1ca_612ab77f","updated":"2014-05-30 12:32:34.000000000","message":"Done","commit_id":"0e7c01fd5685803c33dad886be829d434874a862"}],"tempest/config.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5526e21f0320afdb6a85948b587c46861e2ef6aa","unresolved":false,"context_lines":[{"line_number":755,"context_line":"               help\u003d\u0027ssh username for the image file\u0027),"},{"line_number":756,"context_line":"    cfg.IntOpt("},{"line_number":757,"context_line":"        \u0027large_ops_number\u0027,"},{"line_number":758,"context_line":"        default\u003d50,"},{"line_number":759,"context_line":"        help\u003d\"specifies how many resources to request at once. Used \""},{"line_number":760,"context_line":"        \"for large operations testing.\")"},{"line_number":761,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":21,"id":"7adec928_3f5e2313","line":758,"updated":"2014-05-09 18:36:20.000000000","message":"You can\u0027t change this value to be nonzero. The zero-ness is what suppresses the large ops scenario test from running in the normal gate jobs. In any event, an api test should not be using a value from the scenario group. Which gate jobs, if any, is this test supposed to run in?","commit_id":"584506a2d7d8d8e929a8102873ff9377625daed7"}],"tempest/scenario/test_large_ops.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"37dd9c695e6c0d14e870f6d94b10a4b9d06134b2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        * spin up multiple instances in one nova call"},{"line_number":36,"context_line":"        * as a regular user"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    #2: test_large_ssh_scenario (stress test)"},{"line_number":39,"context_line":"        * call test #1"},{"line_number":40,"context_line":"        * attach floating IPs for every instance"},{"line_number":41,"context_line":"        * check SSH connectivity for every instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2Fy%2FM%3D","line":38,"updated":"2014-02-24 18:37:05.000000000","message":"This won\u0027t work, because the large-ops test uses nova\u0027 fakevirt driver. so no VMs are created to SSH into.","commit_id":"c9f74bd6ddc314bcc1a7aeac2660918d391dfd3f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b333a1501231278a3b6296b66e30414e366464f4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        * spin up multiple instances in one nova call"},{"line_number":36,"context_line":"        * as a regular user"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    #2: test_large_ssh_scenario (stress test)"},{"line_number":39,"context_line":"        * call test #1"},{"line_number":40,"context_line":"        * attach floating IPs for every instance"},{"line_number":41,"context_line":"        * check SSH connectivity for every instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2FkiY%3D","line":38,"in_reply_to":"AAAAU3%2F%2FrfI%3D","updated":"2014-02-25 21:25:11.000000000","message":"due to the tiny size of the devstack instances, and because we run them as all in one, using a real virt driver for a large ops test in the gate be useful.\n\n\nI am not too keen on the idea of using tempest to test the limits of scale, although it does sound like a reasonable case in general.","commit_id":"c9f74bd6ddc314bcc1a7aeac2660918d391dfd3f"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"7bd372e1e1dd550a9c96472ffe57080a072d29df","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        * spin up multiple instances in one nova call"},{"line_number":36,"context_line":"        * as a regular user"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    #2: test_large_ssh_scenario (stress test)"},{"line_number":39,"context_line":"        * call test #1"},{"line_number":40,"context_line":"        * attach floating IPs for every instance"},{"line_number":41,"context_line":"        * check SSH connectivity for every instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2FrfI%3D","line":38,"in_reply_to":"AAAAU3%2F%2Fy%2FM%3D","updated":"2014-02-25 09:56:22.000000000","message":"Does this mean this stress test won\u0027t be included in Tempest at all ?\n\nI believe some people are interested of testing the limit of the number of servers that can be started and made available in their openstack deployment.\n\nSo is there a way to have this test pushed in order to allow these people to have a simple way to test this limit ?\n\nMaybe avoid running it in large-ops gates or modifying these gates to have a full fledged large ops test (replace the fakevirt driver).","commit_id":"c9f74bd6ddc314bcc1a7aeac2660918d391dfd3f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ded7908334a714185f8d76b70599acc093dbe56b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        creating batches of instances and getting them available."},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if CONF.scenario.large_ops_number \u003c 1 or not CONF.compute.run_ssh:"},{"line_number":168,"context_line":"            LOG.info((\"Test aborted either \u0027large_ops-number\u0027 \u003c 1 (%i) \""},{"line_number":169,"context_line":"                      \"or \u0027run_ssh\u0027 is set to False (%r)\"),"},{"line_number":170,"context_line":"                     CONF.scenario.large_ops_number,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Fe4c%3D","line":167,"updated":"2014-03-17 16:32:10.000000000","message":"why not just move this test into a separate file?","commit_id":"d57c5813f2b50893d863cf02c21e5296ea227291"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"be8e9bf3756d67fc64ea548503e1db006dffe2a3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        creating batches of instances and getting them available."},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if CONF.scenario.large_ops_number \u003c 1 or not CONF.compute.run_ssh:"},{"line_number":168,"context_line":"            LOG.info((\"Test aborted either \u0027large_ops-number\u0027 \u003c 1 (%i) \""},{"line_number":169,"context_line":"                      \"or \u0027run_ssh\u0027 is set to False (%r)\"),"},{"line_number":170,"context_line":"                     CONF.scenario.large_ops_number,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2FSa4%3D","line":167,"in_reply_to":"AAAAWH%2F%2Fe00%3D","updated":"2014-03-18 21:06:20.000000000","message":"sure. I think a separate file will be nice to clarify that these tests are used for two different things.\n\nyour test is designed to work on real clouds, the other is targeted clouds running fake virt driver.","commit_id":"d57c5813f2b50893d863cf02c21e5296ea227291"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"9d213ab38c1e7ff5fbbfe04310c30104a8bb57b4","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        creating batches of instances and getting them available."},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if CONF.scenario.large_ops_number \u003c 1 or not CONF.compute.run_ssh:"},{"line_number":168,"context_line":"            LOG.info((\"Test aborted either \u0027large_ops-number\u0027 \u003c 1 (%i) \""},{"line_number":169,"context_line":"                      \"or \u0027run_ssh\u0027 is set to False (%r)\"),"},{"line_number":170,"context_line":"                     CONF.scenario.large_ops_number,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Fe00%3D","line":167,"in_reply_to":"AAAAWH%2F%2Fe4c%3D","updated":"2014-03-18 09:29:33.000000000","message":"Ok for me.\nIs it OK for a new scenario to inherit from another one (in this case : TestLargeOpsScenario) to avoid code duplication ? Or should I simply copy methods like nova_boot ?","commit_id":"d57c5813f2b50893d863cf02c21e5296ea227291"}],"tempest/scenario/test_load_basic_ops.py":[{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"09810c769996ce82d0b5d527a4100f7fafb6c3f4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.servers \u003d client.servers.create(**body)"},{"line_number":147,"context_line":"        # needed because of bug 1199788"},{"line_number":148,"context_line":"        self.servers \u003d [x for x in client.servers.list() if name in x.name]"},{"line_number":149,"context_line":"        [self.set_resource(server.name, server) for server in self.servers]"},{"line_number":150,"context_line":"        self._wait_for_server_status(\u0027ACTIVE\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @test.stresstest(class_setup_per\u003d\u0027action\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2BuY8%3D","line":149,"updated":"2014-03-24 19:55:07.000000000","message":"I suggest to rewrite it to \n\nfor server in self.servers:\n    self.set_resource(server.name, server)","commit_id":"c05e6b6ee42307b0147a5bd3bf681971d40676d8"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"6821e94d6fde7e5e58707d939bf5b4f0597fe7ab","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.servers \u003d client.servers.create(**body)"},{"line_number":147,"context_line":"        # needed because of bug 1199788"},{"line_number":148,"context_line":"        self.servers \u003d [x for x in client.servers.list() if name in x.name]"},{"line_number":149,"context_line":"        [self.set_resource(server.name, server) for server in self.servers]"},{"line_number":150,"context_line":"        self._wait_for_server_status(\u0027ACTIVE\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @test.stresstest(class_setup_per\u003d\u0027action\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2Bps8%3D","line":149,"in_reply_to":"AAAAWH%2F%2BuY8%3D","updated":"2014-03-25 09:39:56.000000000","message":"Done","commit_id":"c05e6b6ee42307b0147a5bd3bf681971d40676d8"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"09810c769996ce82d0b5d527a4100f7fafb6c3f4","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            self.glance_image_create()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        [LOG.info(\"Image used fo tests : %s\", image.name)"},{"line_number":179,"context_line":"         for image in self.image_client.images.list()"},{"line_number":180,"context_line":"         if image.id \u003d\u003d self.image]"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2Buag%3D","line":178,"updated":"2014-03-24 19:55:07.000000000","message":"fix fo -\u003e for","commit_id":"c05e6b6ee42307b0147a5bd3bf681971d40676d8"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"6821e94d6fde7e5e58707d939bf5b4f0597fe7ab","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            self.glance_image_create()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        [LOG.info(\"Image used fo tests : %s\", image.name)"},{"line_number":179,"context_line":"         for image in self.image_client.images.list()"},{"line_number":180,"context_line":"         if image.id \u003d\u003d self.image]"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2Bps0%3D","line":178,"in_reply_to":"AAAAWH%2F%2Buag%3D","updated":"2014-03-25 09:39:56.000000000","message":"Done","commit_id":"c05e6b6ee42307b0147a5bd3bf681971d40676d8"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"09810c769996ce82d0b5d527a4100f7fafb6c3f4","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        LOG.info(\"Attach floating IPs\")"},{"line_number":191,"context_line":"        [self._attach_and_register_floating_ip(server)"},{"line_number":192,"context_line":"         for server in self.servers]"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Use a queue to check servers connectivity in separate threads"},{"line_number":195,"context_line":"        check_queue \u003d Queue.Queue()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2BuZk%3D","line":192,"updated":"2014-03-24 19:55:07.000000000","message":"I suggest to rewrite this code to\n\nfor server in self.servers:\n    self._attach_and_register_floating_ip(server)\n\nit is more readable.","commit_id":"c05e6b6ee42307b0147a5bd3bf681971d40676d8"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"6821e94d6fde7e5e58707d939bf5b4f0597fe7ab","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        LOG.info(\"Attach floating IPs\")"},{"line_number":191,"context_line":"        [self._attach_and_register_floating_ip(server)"},{"line_number":192,"context_line":"         for server in self.servers]"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Use a queue to check servers connectivity in separate threads"},{"line_number":195,"context_line":"        check_queue \u003d Queue.Queue()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2Bpso%3D","line":192,"in_reply_to":"AAAAWH%2F%2BuZk%3D","updated":"2014-03-25 09:39:56.000000000","message":"Done","commit_id":"c05e6b6ee42307b0147a5bd3bf681971d40676d8"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"09810c769996ce82d0b5d527a4100f7fafb6c3f4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # Use a queue to check servers connectivity in separate threads"},{"line_number":195,"context_line":"        check_queue \u003d Queue.Queue()"},{"line_number":196,"context_line":"        errors \u003d list()"},{"line_number":197,"context_line":"        [check_queue.put(server) for server in self.servers]"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        thread_num \u003d min(len(self.servers), 12)"},{"line_number":200,"context_line":"        LOG.info(\"Using %i threads to check servers connectivity\", thread_num)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2BuZU%3D","line":197,"updated":"2014-03-24 19:55:07.000000000","message":"the same, let\u0027s to rewrite to:\n\nfor server in self.servers:\n    check_queue.put(server)","commit_id":"c05e6b6ee42307b0147a5bd3bf681971d40676d8"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"6821e94d6fde7e5e58707d939bf5b4f0597fe7ab","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # Use a queue to check servers connectivity in separate threads"},{"line_number":195,"context_line":"        check_queue \u003d Queue.Queue()"},{"line_number":196,"context_line":"        errors \u003d list()"},{"line_number":197,"context_line":"        [check_queue.put(server) for server in self.servers]"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        thread_num \u003d min(len(self.servers), 12)"},{"line_number":200,"context_line":"        LOG.info(\"Using %i threads to check servers connectivity\", thread_num)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2Bpsg%3D","line":197,"in_reply_to":"AAAAWH%2F%2BuZU%3D","updated":"2014-03-25 09:39:56.000000000","message":"Done","commit_id":"c05e6b6ee42307b0147a5bd3bf681971d40676d8"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"6c17de9cd15bce074efd2e260bc9c3ab26f87efd","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        [LOG.info(\"Image used for tests : %s\", image.name)"},{"line_number":180,"context_line":"         for image in self.image_client.images.list()"},{"line_number":181,"context_line":"         if image.id \u003d\u003d self.image]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        self.nova_boot()"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWH%2F%2BpiQ%3D","line":181,"updated":"2014-03-25 10:02:25.000000000","message":"I suggest to change this to:\n\nfor image in self.image_client.images.list():\n    if image.id \u003d\u003d self.image:\n        LOG.info(\"Image used for tests : %s\", image.name)","commit_id":"709defcac69ae60509e597389db1c456c9878ec3"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"0723868205a9427e8c9da2ae5a75af8ec2c753d6","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        [LOG.info(\"Image used for tests : %s\", image.name)"},{"line_number":180,"context_line":"         for image in self.image_client.images.list()"},{"line_number":181,"context_line":"         if image.id \u003d\u003d self.image]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        self.nova_boot()"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWH%2F%2BpX4%3D","line":181,"in_reply_to":"AAAAWH%2F%2BpiQ%3D","updated":"2014-03-25 10:23:37.000000000","message":"Done","commit_id":"709defcac69ae60509e597389db1c456c9878ec3"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c6b55e734d29acc26cdcd1e67ceb83ba947c53dd","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                      \"or \u0027run_ssh\u0027 is set to False (%r)\"),"},{"line_number":166,"context_line":"                     CONF.scenario.large_ops_number,"},{"line_number":167,"context_line":"                     CONF.compute.run_ssh)"},{"line_number":168,"context_line":"            return"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        LOG.info(\"Launch \u0027%i\u0027 instances\","},{"line_number":171,"context_line":"                 CONF.scenario.large_ops_number)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAWH%2F9ojI%3D","line":168,"updated":"2014-04-03 08:37:47.000000000","message":"I think you should raise a testtools.TestCase.skipException in case you want to skip the test.","commit_id":"0e268a2e7379090a43f9669216922dfdb9bba6fb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c6b55e734d29acc26cdcd1e67ceb83ba947c53dd","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        LOG.info(\"Using %i threads to check servers connectivity\", thread_num)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        for i in range(thread_num):"},{"line_number":205,"context_line":"            t \u003d threading.Thread(name\u003d\u0027Check-\u0027 + str(i),"},{"line_number":206,"context_line":"                                 target\u003dself.check_servers_network,"},{"line_number":207,"context_line":"                                 args\u003d[check_queue, errors])"},{"line_number":208,"context_line":"            t.setDaemon(True)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAWH%2F9ogg%3D","line":205,"updated":"2014-04-03 08:37:47.000000000","message":"I am not an expert in Python threading but AFAIK threading is limited to the cpu the Python process is running in. So what is the benefit in using queues/threading there?\nSee http://en.wikibooks.org/wiki/Python_Programming/Threading","commit_id":"0e268a2e7379090a43f9669216922dfdb9bba6fb"}],"tempest/stress/etc/test_load_ssh_scenario.json":[{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"0f079bb0a7526375f0b23ffe1627ce4b78686383","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[{\"action\": \"tempest.stress.actions.unit_test.UnitTest\","},{"line_number":2,"context_line":"  \"threads\": 1,"},{"line_number":3,"context_line":"  \"use_admin\": false,"},{"line_number":4,"context_line":"  \"use_isolated_tenants\": false,"}],"source_content_type":"application/json","patch_set":16,"id":"AAAAWH%2F9vyQ%3D","line":1,"updated":"2014-04-02 12:30:13.000000000","message":"This JSON looks strange, can we format it to \u0027good JSON\u0027 like in other files?","commit_id":"0e268a2e7379090a43f9669216922dfdb9bba6fb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c6b55e734d29acc26cdcd1e67ceb83ba947c53dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[{\"action\": \"tempest.stress.actions.unit_test.UnitTest\","},{"line_number":2,"context_line":"  \"threads\": 1,"},{"line_number":3,"context_line":"  \"use_admin\": false,"},{"line_number":4,"context_line":"  \"use_isolated_tenants\": false,"}],"source_content_type":"application/json","patch_set":16,"id":"AAAAWH%2F9oUY%3D","line":1,"in_reply_to":"AAAAWH%2F9vq8%3D","updated":"2014-04-03 08:37:47.000000000","message":"I think Timur means the indentation of this file. All of the json files under stress/etc/ are not really nice indented. So it\u0027s might a good idea to have a separate fix and make it look nicer.","commit_id":"0e268a2e7379090a43f9669216922dfdb9bba6fb"},{"author":{"_account_id":9922,"name":"Julien Leloup","email":"julien.leloup@3ds.com","username":"JulienLeloup"},"change_message_id":"154d0c710e8294520a1d1c8ffa51e21bf1118623","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[{\"action\": \"tempest.stress.actions.unit_test.UnitTest\","},{"line_number":2,"context_line":"  \"threads\": 1,"},{"line_number":3,"context_line":"  \"use_admin\": false,"},{"line_number":4,"context_line":"  \"use_isolated_tenants\": false,"}],"source_content_type":"application/json","patch_set":16,"id":"AAAAWH%2F9vq8%3D","line":1,"in_reply_to":"AAAAWH%2F9vyQ%3D","updated":"2014-04-02 12:43:01.000000000","message":"I believe you are speaking of the \u0027[ ]\u0027 around the JSON content.\n\nAt the moment the stress test framework in Tempest only accept JSON configurations file with this format.\n\nI agree with you that this feels strange and should probably be refactored but I think this work is out of the scope of this blueprint and should be done in a new one.","commit_id":"0e268a2e7379090a43f9669216922dfdb9bba6fb"}]}