)]}'
{"tempest/api/queuing/base.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"946b52f3ee4a545ad9182535c5df98f6320367a0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return resp, body"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def delete_queue(cls, queue_name):"},{"line_number":53,"context_line":"        \"\"\"Wrapper utility that returns a test queue.\"\"\""},{"line_number":54,"context_line":"        resp, body \u003d cls.client.delete_queue(queue_name)"},{"line_number":55,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2Bxso%3D","line":52,"updated":"2014-03-12 08:32:31.000000000","message":"Why this method is necessary?\nThis method does not contain any special implementation.\n\nIn API tests, I feel it is better to call/test the target API directly without any wrapper if we can.","commit_id":"2dd14483f2aa520d436ceba7c4b51f7471df3ead"},{"author":{"_account_id":10351,"name":"Jorge Chai","email":"jorge.chai@rackspace.com","username":"jchai"},"change_message_id":"a357173fcb6212bfa72066ad7b11e60937babe8d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return resp, body"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def delete_queue(cls, queue_name):"},{"line_number":53,"context_line":"        \"\"\"Wrapper utility that returns a test queue.\"\"\""},{"line_number":54,"context_line":"        resp, body \u003d cls.client.delete_queue(queue_name)"},{"line_number":55,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2F%2FbY%3D","line":52,"in_reply_to":"AAAAVn%2F%2Bxso%3D","updated":"2014-03-12 14:07:39.000000000","message":"I thought it was best to follow the structure of the original creator of the class, so I mimicked the structure for create_queue","commit_id":"2dd14483f2aa520d436ceba7c4b51f7471df3ead"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"554d1529bd350d3e3d6dfcdea9ad25a7058fd21e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return resp, body"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def delete_queue(cls, queue_name):"},{"line_number":53,"context_line":"        \"\"\"Wrapper utility that returns a test queue.\"\"\""},{"line_number":54,"context_line":"        resp, body \u003d cls.client.delete_queue(queue_name)"},{"line_number":55,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2F%2FSE%3D","line":52,"in_reply_to":"AAAAWH%2F%2F%2FbY%3D","updated":"2014-03-12 14:30:08.000000000","message":"This is also the standard followed by other tempest tests.\nSo I would prefer to keep this  way.","commit_id":"2dd14483f2aa520d436ceba7c4b51f7471df3ead"}],"tempest/api/queuing/test_queues.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"2b64f529270c0838605bbaaeed01c63de39f8c38","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":41,"context_line":"    def test_delete_queue(self):"},{"line_number":42,"context_line":"        # Create Queue"},{"line_number":43,"context_line":"        resp, body \u003d self.create_queue(self.queue_name)"},{"line_number":44,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2B%2B%2BE%3D","line":41,"updated":"2014-02-17 20:17:25.000000000","message":"It will be better to move this test to a new separate class, so that we can make the test pre-requisite (#Create Queue) part of setUp.\nThis new class can be used for our future tests such as insert queue metadata, list queues etc. - all of which need a queue created as a pre-requisite","commit_id":"87fd7c0ff20c5e3c35094b63681e14f3735db626"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"c78d5e137791b5dd987abd0e59f346a5b16f6e6b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(TestQueues, self).tearDown()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ManageQueue(base.BaseQueuingTest):"},{"line_number":46,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B9D0%3D","line":45,"updated":"2014-02-18 01:12:57.000000000","message":"Test classes need to start with \u0027Test\u0027.\nSo this will need to be renamed as TestManageQueue.","commit_id":"226ebb3a36b6f9cc4466003cfedb045126ea2aec"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"554d1529bd350d3e3d6dfcdea9ad25a7058fd21e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"class TestManageQueue(base.BaseQueuingTest):"},{"line_number":45,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def setUp(self):"},{"line_number":48,"context_line":"        super(TestManageQueue, self).setUp()"},{"line_number":49,"context_line":"        self.queue_name \u003d data_utils.rand_name(\u0027Queues-Test\u0027)"},{"line_number":50,"context_line":"        # Create Queue"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2F%2FMw%3D","line":47,"updated":"2014-03-12 14:30:08.000000000","message":"It was suggested to move the test level setUp to classLevel  setup in the base class. Can you check if this can be implemented in a similar fashion?","commit_id":"2dd14483f2aa520d436ceba7c4b51f7471df3ead"},{"author":{"_account_id":10351,"name":"Jorge Chai","email":"jorge.chai@rackspace.com","username":"jchai"},"change_message_id":"ca5f8894e0d12a5c9d9d5c81539fcea5836bd655","unresolved":false,"context_lines":[{"line_number":44,"context_line":"class TestManageQueue(base.BaseQueuingTest):"},{"line_number":45,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def setUp(self):"},{"line_number":48,"context_line":"        super(TestManageQueue, self).setUp()"},{"line_number":49,"context_line":"        self.queue_name \u003d data_utils.rand_name(\u0027Queues-Test\u0027)"},{"line_number":50,"context_line":"        # Create Queue"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2F%2BLw%3D","line":47,"in_reply_to":"AAAAWH%2F%2F%2FMw%3D","updated":"2014-03-12 16:16:25.000000000","message":"I wasn\u0027t sure if it made sense to move that to the base class.\nI changed the methods to be class methods, though","commit_id":"2dd14483f2aa520d436ceba7c4b51f7471df3ead"}]}