)]}'
{"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"52b1a1046f64c94ac0daf53b67c7798345997f53","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.assertIn(\u0027status\u0027, image)"},{"line_number":70,"context_line":"        self.assertEqual(\u0027queued\u0027, image[\u0027status\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        check_status \u003d \u0027active\u0027"},{"line_number":73,"context_line":"        image_uri \u003d None"},{"line_number":74,"context_line":"        if import_method \u003d\u003d \u0027glance-direct\u0027:"},{"line_number":75,"context_line":"            # Stage image data"},{"line_number":76,"context_line":"            file_content \u003d data_utils.random_bytes()"},{"line_number":77,"context_line":"            image_file \u003d six.BytesIO(file_content)"},{"line_number":78,"context_line":"            self.client.stage_image_file(image[\u0027id\u0027], image_file)"},{"line_number":79,"context_line":"            check_status \u003d \u0027uploading\u0027"},{"line_number":80,"context_line":"        elif import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":81,"context_line":"            check_status \u003d \u0027queued\u0027"},{"line_number":82,"context_line":"            image_uri \u003d CONF.image.web_download_uri"},{"line_number":83,"context_line":"        # Now try to get image details"},{"line_number":84,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":85,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_96f2dd05","line":82,"range":{"start_line":72,"start_character":8,"end_line":82,"end_character":51},"updated":"2020-07-25 12:42:08.000000000","message":"NIT not a big fan of if logic in methods since they can grow over time, could break down to 2 methods like \n_get_image(self, import_method) line 44-70\nline 72 82 in test_* method\n_assert_image (self, image_id) lines 84-93","commit_id":"3d343bb2122a7c6c04fd3cb9ca61be84b09a3dc6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72a8c897a16808e734570cecc43932dccd18b0c4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.assertIn(\u0027status\u0027, image)"},{"line_number":70,"context_line":"        self.assertEqual(\u0027queued\u0027, image[\u0027status\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        check_status \u003d \u0027active\u0027"},{"line_number":73,"context_line":"        image_uri \u003d None"},{"line_number":74,"context_line":"        if import_method \u003d\u003d \u0027glance-direct\u0027:"},{"line_number":75,"context_line":"            # Stage image data"},{"line_number":76,"context_line":"            file_content \u003d data_utils.random_bytes()"},{"line_number":77,"context_line":"            image_file \u003d six.BytesIO(file_content)"},{"line_number":78,"context_line":"            self.client.stage_image_file(image[\u0027id\u0027], image_file)"},{"line_number":79,"context_line":"            check_status \u003d \u0027uploading\u0027"},{"line_number":80,"context_line":"        elif import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":81,"context_line":"            check_status \u003d \u0027queued\u0027"},{"line_number":82,"context_line":"            image_uri \u003d CONF.image.web_download_uri"},{"line_number":83,"context_line":"        # Now try to get image details"},{"line_number":84,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":85,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_35f93980","line":82,"range":{"start_line":72,"start_character":8,"end_line":82,"end_character":51},"in_reply_to":"9f560f44_96f2dd05","updated":"2020-07-27 15:18:15.000000000","message":"done","commit_id":"3d343bb2122a7c6c04fd3cb9ca61be84b09a3dc6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"133db0ce5d3e8ca8e4f27f6f11d11bf96305b7d4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Check image status is \u0027uploading\u0027"},{"line_number":87,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(\u0027uploading\u0027, body[\u0027status\u0027])"},{"line_number":90,"context_line":"        # import image from staging to backend"},{"line_number":91,"context_line":"        self.client.image_import(image[\u0027id\u0027], method\u003d\u0027glance-direct\u0027)"},{"line_number":92,"context_line":"        self.client.wait_for_resource_activation(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_07794bfb","line":89,"range":{"start_line":89,"start_character":26,"end_line":89,"end_character":35},"updated":"2020-07-29 12:43:53.000000000","message":"will it be always in uploading state? Is there a chance that the image will be already in ACTIVE at this point? Because I remember we had a bug when a test didn\u0027t expect the resource might be ACTIVE that fast and it lead to errors.. so better to ask.","commit_id":"1425ecd42e47224b4713501eb204f8b3837700cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aba8ab38d3866e8072d1865cd1f06d9a44deac5d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Check image status is \u0027uploading\u0027"},{"line_number":87,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(\u0027uploading\u0027, body[\u0027status\u0027])"},{"line_number":90,"context_line":"        # import image from staging to backend"},{"line_number":91,"context_line":"        self.client.image_import(image[\u0027id\u0027], method\u003d\u0027glance-direct\u0027)"},{"line_number":92,"context_line":"        self.client.wait_for_resource_activation(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_59acbb33","line":89,"range":{"start_line":89,"start_character":26,"end_line":89,"end_character":35},"in_reply_to":"9f560f44_07794bfb","updated":"2020-07-29 14:56:58.000000000","message":"no, it will be in \u0027updating\u0027 always after stage operation and only move to Active when import operation is done.\n\n- https://docs.openstack.org/api-ref/image/v2/?expanded\u003dimport-an-image-detail,stage-binary-image-data-detail#stage-binary-image-data","commit_id":"1425ecd42e47224b4713501eb204f8b3837700cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ac0b688e6d09d61fcd9c6f3fbccb0ba51f25ed21","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Check image status is \u0027uploading\u0027"},{"line_number":87,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(\u0027uploading\u0027, body[\u0027status\u0027])"},{"line_number":90,"context_line":"        # import image from staging to backend"},{"line_number":91,"context_line":"        self.client.image_import(image[\u0027id\u0027], method\u003d\u0027glance-direct\u0027)"},{"line_number":92,"context_line":"        self.client.wait_for_resource_activation(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_5e7f6566","line":89,"range":{"start_line":89,"start_character":26,"end_line":89,"end_character":35},"in_reply_to":"9f560f44_3fd55044","updated":"2020-07-30 19:51:44.000000000","message":"image in \u0027uploading\u0027 is a precondition for \u0027glance-direct\u0027 import operation, you can see in \u0027Additional Preconditions\u0027 part in api ref - https://docs.openstack.org/api-ref/image/v2/?expanded\u003dimport-an-image-detail#import-an-image","commit_id":"1425ecd42e47224b4713501eb204f8b3837700cf"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"5c07953d21aae90f322978a156c9fdb9b6425cab","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Check image status is \u0027uploading\u0027"},{"line_number":87,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(\u0027uploading\u0027, body[\u0027status\u0027])"},{"line_number":90,"context_line":"        # import image from staging to backend"},{"line_number":91,"context_line":"        self.client.image_import(image[\u0027id\u0027], method\u003d\u0027glance-direct\u0027)"},{"line_number":92,"context_line":"        self.client.wait_for_resource_activation(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_3fd55044","line":89,"range":{"start_line":89,"start_character":26,"end_line":89,"end_character":35},"in_reply_to":"9f560f44_59acbb33","updated":"2020-07-30 18:15:11.000000000","message":"It sounds unsafe to check in this way .\nWhet if the uploading finishes sooner then you check ?\nCan you also accept the finished (active)state here ?","commit_id":"1425ecd42e47224b4713501eb204f8b3837700cf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"133db0ce5d3e8ca8e4f27f6f11d11bf96305b7d4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # Now try to get image details"},{"line_number":106,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":107,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(\u0027queued\u0027, body[\u0027status\u0027])"},{"line_number":109,"context_line":"        # import image from web to backend"},{"line_number":110,"context_line":"        image_uri \u003d CONF.image.http_image"},{"line_number":111,"context_line":"        self.client.image_import(image[\u0027id\u0027], method\u003d\u0027web-download\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_85d26e5b","line":108,"range":{"start_line":108,"start_character":26,"end_line":108,"end_character":32},"updated":"2020-07-29 12:43:53.000000000","message":"the same question as above","commit_id":"1425ecd42e47224b4713501eb204f8b3837700cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aba8ab38d3866e8072d1865cd1f06d9a44deac5d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # Now try to get image details"},{"line_number":106,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":107,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(\u0027queued\u0027, body[\u0027status\u0027])"},{"line_number":109,"context_line":"        # import image from web to backend"},{"line_number":110,"context_line":"        image_uri \u003d CONF.image.http_image"},{"line_number":111,"context_line":"        self.client.image_import(image[\u0027id\u0027], method\u003d\u0027web-download\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_f9714fe0","line":108,"range":{"start_line":108,"start_character":26,"end_line":108,"end_character":32},"in_reply_to":"9f560f44_85d26e5b","updated":"2020-07-29 14:56:58.000000000","message":"after create image it will be in queued until image file is uploaded which can be done via multiple way, importing with web-download is one of them.\n- https://docs.openstack.org/api-ref/image/v2/?expanded\u003dcreate-image-detail#create-image","commit_id":"1425ecd42e47224b4713501eb204f8b3837700cf"}],"tempest/config.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"52b1a1046f64c94ac0daf53b67c7798345997f53","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                        \u0027publicURL\u0027, \u0027adminURL\u0027, \u0027internalURL\u0027],"},{"line_number":617,"context_line":"               help\u003d\"The endpoint type to use for the image service.\"),"},{"line_number":618,"context_line":"    cfg.StrOpt(\u0027http_image\u0027,"},{"line_number":619,"context_line":"               default\u003d\u0027http://download.cirros-cloud.net/0.3.1/\u0027"},{"line_number":620,"context_line":"               \u0027cirros-0.3.1-x86_64-uec.tar.gz\u0027,"},{"line_number":621,"context_line":"               help\u003d\u0027http accessible image\u0027),"},{"line_number":622,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_16e6cd45","line":619,"range":{"start_line":619,"start_character":57,"end_line":619,"end_character":62},"updated":"2020-07-25 12:42:08.000000000","message":"NIT: should we update the version of this image at this time to use the same image?  I am not sure but wanted to bring it up. .0.3.0 is the oldest directory from 2017 https://download.cirros-cloud.net\n\nif it drops soon we would have a failed gate.","commit_id":"3d343bb2122a7c6c04fd3cb9ca61be84b09a3dc6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e74f82ca1cb041e04d1695ffeaabb5aed9becc2b","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                        \u0027publicURL\u0027, \u0027adminURL\u0027, \u0027internalURL\u0027],"},{"line_number":617,"context_line":"               help\u003d\"The endpoint type to use for the image service.\"),"},{"line_number":618,"context_line":"    cfg.StrOpt(\u0027http_image\u0027,"},{"line_number":619,"context_line":"               default\u003d\u0027http://download.cirros-cloud.net/0.3.1/\u0027"},{"line_number":620,"context_line":"               \u0027cirros-0.3.1-x86_64-uec.tar.gz\u0027,"},{"line_number":621,"context_line":"               help\u003d\u0027http accessible image\u0027),"},{"line_number":622,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_55ff8da9","line":619,"range":{"start_line":619,"start_character":57,"end_line":619,"end_character":62},"in_reply_to":"9f560f44_16e6cd45","updated":"2020-07-27 14:49:11.000000000","message":"yeah, we can update it the old one is gone.","commit_id":"3d343bb2122a7c6c04fd3cb9ca61be84b09a3dc6"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"6080ddb9317fac6cacd137244a9a27ff0c9b1d35","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                         \u0027vdi\u0027, \u0027iso\u0027, \u0027vhdx\u0027],"},{"line_number":637,"context_line":"                help\u003d\"A list of image\u0027s disk formats \""},{"line_number":638,"context_line":"                     \"users can specify.\"),"},{"line_number":639,"context_line":"    cfg.StrOpt(\u0027web_download_uri\u0027,"},{"line_number":640,"context_line":"               default\u003d\u0027https://download.cirros-cloud.net/0.5.1/\u0027"},{"line_number":641,"context_line":"               \u0027cirros-0.5.1-x86_64-disk.img\u0027,"},{"line_number":642,"context_line":"               help\u003d\"Image web uri for web-download import tests.\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_692f67f6","line":639,"updated":"2020-07-27 07:28:05.000000000","message":"Do we really need a yet another new url option ?\nIMHO http_image should be used here as well.","commit_id":"3d343bb2122a7c6c04fd3cb9ca61be84b09a3dc6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e74f82ca1cb041e04d1695ffeaabb5aed9becc2b","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                         \u0027vdi\u0027, \u0027iso\u0027, \u0027vhdx\u0027],"},{"line_number":637,"context_line":"                help\u003d\"A list of image\u0027s disk formats \""},{"line_number":638,"context_line":"                     \"users can specify.\"),"},{"line_number":639,"context_line":"    cfg.StrOpt(\u0027web_download_uri\u0027,"},{"line_number":640,"context_line":"               default\u003d\u0027https://download.cirros-cloud.net/0.5.1/\u0027"},{"line_number":641,"context_line":"               \u0027cirros-0.5.1-x86_64-disk.img\u0027,"},{"line_number":642,"context_line":"               help\u003d\"Image web uri for web-download import tests.\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_7577313c","line":639,"in_reply_to":"9f560f44_692f67f6","updated":"2020-07-27 14:49:11.000000000","message":"yeah that is being used in v1 API for location of copy_from of image. let me update that.\n\nthanks","commit_id":"3d343bb2122a7c6c04fd3cb9ca61be84b09a3dc6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2ff9b1aed9f08b7e4fb29dcde8517d7376709677","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                default\u003d[\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027, \u0027vhd\u0027, \u0027vmdk\u0027, \u0027raw\u0027, \u0027qcow2\u0027,"},{"line_number":636,"context_line":"                         \u0027vdi\u0027, \u0027iso\u0027, \u0027vhdx\u0027],"},{"line_number":637,"context_line":"                help\u003d\"A list of image\u0027s disk formats \""},{"line_number":638,"context_line":"                     \"users can specify.\"),"},{"line_number":639,"context_line":"]"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"image_feature_group \u003d cfg.OptGroup(name\u003d\u0027image-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_cd7ae986","line":638,"range":{"start_line":638,"start_character":42,"end_line":638,"end_character":43},"updated":"2020-07-28 05:24:18.000000000","message":"why this is related?","commit_id":"2ae50436c9f82581b552fa56a327d16cadd6e8da"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6f33978e858d31a553a0a78d8504467958f59d71","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                default\u003d[\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027, \u0027vhd\u0027, \u0027vmdk\u0027, \u0027raw\u0027, \u0027qcow2\u0027,"},{"line_number":636,"context_line":"                         \u0027vdi\u0027, \u0027iso\u0027, \u0027vhdx\u0027],"},{"line_number":637,"context_line":"                help\u003d\"A list of image\u0027s disk formats \""},{"line_number":638,"context_line":"                     \"users can specify.\"),"},{"line_number":639,"context_line":"]"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"image_feature_group \u003d cfg.OptGroup(name\u003d\u0027image-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_cbdc8c1a","line":638,"range":{"start_line":638,"start_character":42,"end_line":638,"end_character":43},"in_reply_to":"9f560f44_cd7ae986","updated":"2020-07-28 13:02:43.000000000","message":"this is left over from removing new config. Done","commit_id":"2ae50436c9f82581b552fa56a327d16cadd6e8da"}],"tempest/lib/services/image/v2/images_client.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9396f0903246c0132b9bfb5158680c69600c101e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            \"method\": {"},{"line_number":204,"context_line":"                \"name\": method"},{"line_number":205,"context_line":"            },"},{"line_number":206,"context_line":"            \"all_stores\": stores \u003d\u003d None,"},{"line_number":207,"context_line":"            \"all_stores_must_succeed\": all_stores_must_succeed,"},{"line_number":208,"context_line":"        }"},{"line_number":209,"context_line":"        if stores:"},{"line_number":210,"context_line":"            data[\"stores\"] \u003d stores"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_af85cd09","line":207,"range":{"start_line":206,"start_character":12,"end_line":207,"end_character":63},"updated":"2020-07-22 06:54:25.000000000","message":"These needs to be set only in case of multiple stores are enabled using enabled_backends config option. Otherwise it will always raise 400 Bad request.","commit_id":"f8f4f2e9d9938e5962e88e966aab8aa6a721986b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"82721171db0fddbb746a055debc9cbe57f41763b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            \"method\": {"},{"line_number":222,"context_line":"                \"name\": method"},{"line_number":223,"context_line":"            },"},{"line_number":224,"context_line":"            \"all_stores\": all_stores if all_stores else stores is None,"},{"line_number":225,"context_line":"        }"},{"line_number":226,"context_line":"        if stores is not None:"},{"line_number":227,"context_line":"            data[\"stores\"] \u003d stores"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf51134e_a8d10b5a","line":224,"range":{"start_line":224,"start_character":12,"end_line":224,"end_character":71},"updated":"2020-07-24 14:10:50.000000000","message":"The api-ref says \"To import the data into the entire set of stores you may consume from this particular deployment of Glance without specifying each one of them, you can use the optional boolean body parameter all_stores. Note that this can’t be used simultaneously with the stores parameter.\", which implies to me that \"all_stores\" shouldn\u0027t appear in the request JSON at all if a \"stores\" element is in there.  That said, the code does seem to do the right thing here if \u0027\"all_stores\": false\u0027 is in the request body and a list of stores is also present.\n\nI don\u0027t think the import request body is JSON-schematized yet (or else we\u0027d be getting a 400 here), but we should probably respect the api-ref in the tempest test, I\u0027d think?\n\nhttps://docs.openstack.org/api-ref/image/v2/?expanded\u003dimport-an-image-detail#import-an-image","commit_id":"7ec9d435a6239fba8206c2e6f40ea9b2c643706a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"482d473a9b2c18db17d1896a6a230a70736880fe","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            \"method\": {"},{"line_number":222,"context_line":"                \"name\": method"},{"line_number":223,"context_line":"            },"},{"line_number":224,"context_line":"            \"all_stores\": all_stores if all_stores else stores is None,"},{"line_number":225,"context_line":"        }"},{"line_number":226,"context_line":"        if stores is not None:"},{"line_number":227,"context_line":"            data[\"stores\"] \u003d stores"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_7d13af67","line":224,"range":{"start_line":224,"start_character":12,"end_line":224,"end_character":71},"in_reply_to":"bf51134e_a8d10b5a","updated":"2020-07-24 18:06:27.000000000","message":"This was my bad on the previous patch. I must say, the number of permutations the body can/must take depending on the server config and what the client wants to do is a bit mesmerizing. It\u0027d be nice if I could always specify everything and only have it freak out if the combination was not compatible with what was actually going on :)","commit_id":"7ec9d435a6239fba8206c2e6f40ea9b2c643706a"}]}