)]}'
{"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2e477607b9ac478f0a56017c374377c117c69e37","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(AttachVolumeShelveTestJSON, cls).skip_checks()"},{"line_number":201,"context_line":"        if not CONF.compute_feature_enabled.shelve:"},{"line_number":202,"context_line":"            raise cls.skipException(\u0027Shelve is not available.\u0027)"},{"line_number":203,"context_line":"        if not CONF.compute.feature_enabled.cross_az_attach:"},{"line_number":204,"context_line":"            raise cls.skipException(\u0027Cross AZ attach not available.\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _count_volumes(self, server, validation_resources):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_a09d085b","line":203,"range":{"start_line":203,"start_character":15,"end_line":203,"end_character":59},"updated":"2020-10-22 08:28:24.000000000","message":"maybe we could use this option instead CONF.compute.compute_volume_common_az ?\n\nThat option should be set when cross_az_attach is disabled in cinder, otherwise it\u0027s None, see https://review.opendev.org/#/c/408498/","commit_id":"4d94da0afc62e377f6afb90ed520b486cc5bc623"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a18e4adac94b4319ab362fe99a3421774a05af83","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(AttachVolumeShelveTestJSON, cls).skip_checks()"},{"line_number":201,"context_line":"        if not CONF.compute_feature_enabled.shelve:"},{"line_number":202,"context_line":"            raise cls.skipException(\u0027Shelve is not available.\u0027)"},{"line_number":203,"context_line":"        if not CONF.compute.feature_enabled.cross_az_attach:"},{"line_number":204,"context_line":"            raise cls.skipException(\u0027Cross AZ attach not available.\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _count_volumes(self, server, validation_resources):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_de78952b","line":203,"updated":"2020-07-30 20:02:12.000000000","message":"should this also check if a nova AZ is configured?","commit_id":"4d94da0afc62e377f6afb90ed520b486cc5bc623"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0fa6a0c146f0d09a2eba2bea38ae93e505437d50","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(AttachVolumeShelveTestJSON, cls).skip_checks()"},{"line_number":201,"context_line":"        if not CONF.compute_feature_enabled.shelve:"},{"line_number":202,"context_line":"            raise cls.skipException(\u0027Shelve is not available.\u0027)"},{"line_number":203,"context_line":"        if not CONF.compute.feature_enabled.cross_az_attach:"},{"line_number":204,"context_line":"            raise cls.skipException(\u0027Cross AZ attach not available.\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _count_volumes(self, server, validation_resources):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_808ef424","line":203,"range":{"start_line":203,"start_character":15,"end_line":203,"end_character":59},"in_reply_to":"3f65232a_a09d085b","updated":"2020-11-19 17:59:48.000000000","message":"yeah, we do it in other place to set the AZ and same can be used to skip the tests too, replied in https://review.opendev.org/#/c/744039/1//COMMIT_MSG@12","commit_id":"4d94da0afc62e377f6afb90ed520b486cc5bc623"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"741739cc9cce8d4c8edcb8ed764399d8ba38281e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(AttachVolumeShelveTestJSON, cls).skip_checks()"},{"line_number":201,"context_line":"        if not CONF.compute_feature_enabled.shelve:"},{"line_number":202,"context_line":"            raise cls.skipException(\u0027Shelve is not available.\u0027)"},{"line_number":203,"context_line":"        if not CONF.compute.feature_enabled.cross_az_attach:"},{"line_number":204,"context_line":"            raise cls.skipException(\u0027Cross AZ attach not available.\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _count_volumes(self, server, validation_resources):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_de95de88","line":203,"in_reply_to":"9f560f44_70d08820","updated":"2020-08-05 17:39:32.000000000","message":"I mean check if tempest has been configured to use a nova AZ. If not then does it matter what cross_az_attach is set to?","commit_id":"4d94da0afc62e377f6afb90ed520b486cc5bc623"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3890d7e02a9f82f68aca594757155aab0364ab1c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(AttachVolumeShelveTestJSON, cls).skip_checks()"},{"line_number":201,"context_line":"        if not CONF.compute_feature_enabled.shelve:"},{"line_number":202,"context_line":"            raise cls.skipException(\u0027Shelve is not available.\u0027)"},{"line_number":203,"context_line":"        if not CONF.compute.feature_enabled.cross_az_attach:"},{"line_number":204,"context_line":"            raise cls.skipException(\u0027Cross AZ attach not available.\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _count_volumes(self, server, validation_resources):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_70d08820","line":203,"in_reply_to":"9f560f44_de78952b","updated":"2020-07-31 11:57:35.000000000","message":"We should always have a default AZ of nova right?\n\nhttps://github.com/openstack/nova/blob/91b948177f7eaf48736ecbe00a6b4701581302ea/nova/conf/availability_zone.py#L32-L43","commit_id":"4d94da0afc62e377f6afb90ed520b486cc5bc623"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"64c124df380ff2bd402412f98dba7eec81faa898","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(AttachVolumeShelveTestJSON, cls).skip_checks()"},{"line_number":201,"context_line":"        if not CONF.compute_feature_enabled.shelve:"},{"line_number":202,"context_line":"            raise cls.skipException(\u0027Shelve is not available.\u0027)"},{"line_number":203,"context_line":"        if not CONF.compute.feature_enabled.cross_az_attach:"},{"line_number":204,"context_line":"            raise cls.skipException(\u0027Cross AZ attach not available.\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _count_volumes(self, server, validation_resources):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9e5c06ee","line":203,"in_reply_to":"9f560f44_de95de88","updated":"2020-08-05 18:09:33.000000000","message":"Actually after looking at the code there is only one option for AZs, compute_volume_common_az, and this already implies/assumes cross_az_attach\u003dFalse.\n\nFor the new cross_az_attach conf option to be useful I think it would also require separate AZ options for cinder and nova.","commit_id":"4d94da0afc62e377f6afb90ed520b486cc5bc623"}]}