)]}'
{"id":"openstack%2Ftempest~744048","triplet_id":"openstack%2Ftempest~master~I35fe49a6ce2148890c55f279cf8742c0e4332004","project":"openstack/tempest","branch":"master","topic":"bp/tempest-cli-unit-test-coverage","hashtags":[],"change_id":"I35fe49a6ce2148890c55f279cf8742c0e4332004","subject":"Add import line unit tests for check_uuid command","status":"ABANDONED","created":"2020-07-30 20:34:20.000000000","updated":"2022-08-26 18:53:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3677b9bc09040e9378c97f0153817e1f956de8ef","_number":744048,"virtual_id_number":744048,"owner":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-08-02 19:27:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Release Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-30 22:32:36.000000000","updated_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"reviewer":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"state":"REVIEWER"},{"updated":"2020-08-02 19:27:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d40da2a6a874cf8bdd669a984537446e8b97a1c","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-07-30 20:34:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9bb78341b853362fb47eb4fdcbd1e5224597269b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-30 23:21:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7708d274f1dd4e6eb103f82dbc4429cd : FAILURE in 4m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d1f1da8a37924630a15727088f236955 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/27b751696add453aba9c1b016172fe72 : FAILURE in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b7a44a28ef24484a937e125a68bfeb52 : FAILURE in 4m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a0688f5d3e634bd59489a622cf9a8ec4 : SUCCESS in 11m 55s","accounts_in_message":[],"_revision_number":1},{"id":"8847a04b8ab279d3b017a0e45d96312f9efef75b","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-08-02 19:07:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"83315c7e47a9c17bc01b642b86c5ca6a904455c4","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-08-02 19:08:33.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"478cf871abfa8e670910125e7d199d12c9a16cec","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-02 19:27:24.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8462c9865b794c17ada10ed1e5e9899e : FAILURE in 4m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2a4135ca2aaa43839a4469ee16c98e04 : FAILURE in 3m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/010e001637c941b8bfb2ddd8ea55c0cf : FAILURE in 5m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3cd1ff2484a54ba1b964f39e242c4b93 : FAILURE in 4m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b4e2a56bd0964e059dc65f648e718685 : SUCCESS in 10m 48s","accounts_in_message":[],"_revision_number":3},{"id":"3677b9bc09040e9378c97f0153817e1f956de8ef","tag":"autogenerated:gerrit:abandon","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2022-08-26 18:53:18.000000000","message":"Abandoned\n\nThere is no change/response since long, we are abandoning it feel free to restore an rebase it.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6143393e149bac3533dc8e2db11365c9b68f0ea5","revisions":{"e9c4e5e41508b9a93bd01524ae7a76f053ae28c3":{"kind":"REWORK","_number":1,"created":"2020-07-30 20:34:20.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/48/744048/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/48/744048/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/48/744048/1"}}},"commit":{"parents":[{"commit":"4237716010f4d200b9759c9afa6dcc454e12dff5","subject":"Merge \"Fix KeyError exc in volumes_client\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/4237716010f4d200b9759c9afa6dcc454e12dff5"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2020-07-30 20:26:14.000000000","tz":-300},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2020-07-30 20:26:14.000000000","tz":-300},"subject":"Add import line unit tests for check_uuid command","message":"Add import line unit tests for check_uuid command\n\ncheck_uuid end up adding the import line at the end of the\nfile if there is no tempest import present in the file.\n\nThis is due to:\nhttps://github.com/openstack/tempest/blob/f2727fa6b4eb9ed3a8b48f6b8a6b0d34d72307fb/tempest/lib/cmd/check_uuid.py#L186-L191\nwhere line_no is passed as 0 to add_patch.\n\n0 line number is never a valid value for add_patch and end\nup adding the import line at the end of file.\n\nThis commit adds test to cover this case.\n\nChange-Id: I35fe49a6ce2148890c55f279cf8742c0e4332004\nPartially-Implements: blueprint tempest-cli-unit-test-coverage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/e9c4e5e41508b9a93bd01524ae7a76f053ae28c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/e9c4e5e41508b9a93bd01524ae7a76f053ae28c3"}]},"branch":"refs/heads/master"},"e55ec9c32cdc11418333374c11f8412845f6b031":{"kind":"REWORK","_number":2,"created":"2020-08-02 19:07:42.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/48/744048/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/48/744048/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/48/744048/2"}}},"commit":{"parents":[{"commit":"ad080bc78d703a6babedc31665f4d8aad0a6478e","subject":"Fix import line location when there is no tempest import","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/ad080bc78d703a6babedc31665f4d8aad0a6478e"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2020-08-02 19:06:14.000000000","tz":-300},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2020-08-02 19:06:14.000000000","tz":-300},"subject":"Add import line unit tests for check_uuid command","message":"Add import line unit tests for check_uuid command\n\ncheck_uuid end up adding the import line at the end of the\nfile if there is no tempest import present in the file.\n\nThis is due to:\nhttps://github.com/openstack/tempest/blob/f2727fa6b4eb9ed3a8b48f6b8a6b0d34d72307fb/tempest/lib/cmd/check_uuid.py#L186-L191\nwhere line_no is passed as 0 to add_patch.\n\n0 line number is never a valid value for add_patch and end\nup adding the import line at the end of file.\n\nThis commit adds test to cover the expected line number case where\ndecorator import will be patched in both cases 1. if there is no\ntempest import 2. there is tempest import.\n\nChange-Id: I35fe49a6ce2148890c55f279cf8742c0e4332004\nPartially-Implements: blueprint tempest-cli-unit-test-coverage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/e55ec9c32cdc11418333374c11f8412845f6b031"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/e55ec9c32cdc11418333374c11f8412845f6b031"}]},"branch":"refs/heads/master"},"6143393e149bac3533dc8e2db11365c9b68f0ea5":{"kind":"REWORK","_number":3,"created":"2020-08-02 19:08:33.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/48/744048/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/48/744048/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/48/744048/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/48/744048/3"}}},"commit":{"parents":[{"commit":"ad080bc78d703a6babedc31665f4d8aad0a6478e","subject":"Fix import line location when there is no tempest import","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/ad080bc78d703a6babedc31665f4d8aad0a6478e"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2020-08-02 19:06:14.000000000","tz":-300},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2020-08-02 19:08:31.000000000","tz":0},"subject":"Add import line unit tests for check_uuid command","message":"Add import line unit tests for check_uuid command\n\ncheck_uuid end up adding the import line at the end of the\nfile if there is no tempest import present in the file.\n\nThis is due to:\nhttps://github.com/openstack/tempest/blob/f2727fa6b4eb9ed3a8b48f6b8a6b0d34d72307fb/tempest/lib/cmd/check_uuid.py#L186-L191\nwhere line_no is passed as 0 to add_patch.\n\n0 line number is never a valid value for add_patch and end\nup adding the import line at the end of file.\n\nThis commit adds test to cover the expected line number case where\ndecorator import will be patched in both cases 1. if there is no\ntempest import 2. there is tempest import.\n\nChange-Id: I35fe49a6ce2148890c55f279cf8742c0e4332004\nPartially-Implements: blueprint tempest-cli-unit-test-coverage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/6143393e149bac3533dc8e2db11365c9b68f0ea5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/6143393e149bac3533dc8e2db11365c9b68f0ea5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}