)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"3d2df2fa5d27dd51a2d5f600c45140ae59d64713","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add shelve_offload test for Nova v3 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On compute nodes which are configured with shelved_offload_time \u003e 1,"},{"line_number":10,"context_line":"the shelve API changes a server status to SHELVED and a server image"},{"line_number":11,"context_line":"remains in the node. The shelve_offload API offloads the server image"},{"line_number":12,"context_line":"from the node. This patch adds the API test for Nova v3 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2F%2B4w%3D","line":9,"updated":"2014-03-03 00:31:36.000000000","message":"So I think the test changes are fine, but something is wrong with this commit message. I think you\u0027re adding a test for when shelved_offload_time is set to \u003c 0 ?","commit_id":"16203c9d165e455f91f83db0cb818a4a0cd668a9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b0120cb2c705e735343861201f60499a2e76ffed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add shelve_offload test for Nova v3 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On compute nodes which are configured with shelved_offload_time \u003e 1,"},{"line_number":10,"context_line":"the shelve API changes a server status to SHELVED and a server image"},{"line_number":11,"context_line":"remains in the node. The shelve_offload API offloads the server image"},{"line_number":12,"context_line":"from the node. This patch adds the API test for Nova v3 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2F%2B3M%3D","line":9,"in_reply_to":"AAAAVn%2F%2F%2B4w%3D","updated":"2014-03-03 00:46:20.000000000","message":"oops, you are right.\nHere is the shelve_offload_time description of Nova:\n\netc/nova/nova.conf.sample\n # Time in seconds before a shelved instance is eligible for\n # removing from a host.  -1 never offload, 0 offload when\n # shelved (integer value)\n #shelved_offload_time\u003d0\n\nSo the above line should be changed to\n\n - shelved_offload_time \u003e 1,\n + shelved_offload_time \u003d -1,","commit_id":"16203c9d165e455f91f83db0cb818a4a0cd668a9"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"67db5f4b0913fd256b6ecd1fe26684bc6b6133b0","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":384,"context_line":"                                               \u0027SHELVED\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"            resp, server \u003d self.client.shelve_offload_server(self.server_id)"},{"line_number":387,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":388,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":389,"context_line":"                                               \u0027SHELVED_OFFLOADED\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FcuI%3D","line":386,"updated":"2014-03-06 01:20:09.000000000","message":"So I may be missing something, but isn\u0027t this call to the v2 servers client? But, you\u0027re only adding this method to v3 servers client in the patch. I didn\u0027t see shelve_offload_server() defined anywhere for v2.","commit_id":"86333d5dba083a748497b2dec4af4a52e4d3eb0d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"184e06f6b0045f483f27958e3bf0900fb34f0114","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":384,"context_line":"                                               \u0027SHELVED\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"            resp, server \u003d self.client.shelve_offload_server(self.server_id)"},{"line_number":387,"context_line":"            self.assertEqual(202, resp.status)"},{"line_number":388,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":389,"context_line":"                                               \u0027SHELVED_OFFLOADED\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FcXU%3D","line":386,"in_reply_to":"AAAAVn%2F%2FcuI%3D","updated":"2014-03-06 02:16:18.000000000","message":"@Matthew,\n\nGreat catch, thanks!\n\nYou are right, I forgot to add it for v2 API.\nI will do it in the next patch.\n\nThanks","commit_id":"86333d5dba083a748497b2dec4af4a52e4d3eb0d"}],"tempest/services/compute/json/servers_client.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"56d7c7c431709efd1df904ee0e746719d2bc60af","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def shelve_offload_server(self, server_id, **kwargs):"},{"line_number":386,"context_line":"        \"\"\"Shelve-offload the provided server.\"\"\""},{"line_number":387,"context_line":"        return self.action(server_id, \u0027shelve_offload\u0027, None, **kwargs)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def get_console_output(self, server_id, length):"},{"line_number":390,"context_line":"        return self.action(server_id, \u0027os-getConsoleOutput\u0027, \u0027output\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FY5E%3D","line":387,"updated":"2014-03-06 12:39:23.000000000","message":"So this is shelveOffload in the V2 API. Same issue with the xml version.\n\nI guess these tests aren\u0027t actually being run in the gate because of the way shelve is configured by default?","commit_id":"22c86f535b8af59ae48d97604210921214378b4c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d31e14824e2fc089b02449517b2a2eac40610205","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def shelve_offload_server(self, server_id, **kwargs):"},{"line_number":386,"context_line":"        \"\"\"Shelve-offload the provided server.\"\"\""},{"line_number":387,"context_line":"        return self.action(server_id, \u0027shelve_offload\u0027, None, **kwargs)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def get_console_output(self, server_id, length):"},{"line_number":390,"context_line":"        return self.action(server_id, \u0027os-getConsoleOutput\u0027, \u0027output\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FO0c%3D","line":387,"in_reply_to":"AAAAVn%2F%2FY5E%3D","updated":"2014-03-07 12:55:32.000000000","message":"Nice catch, thanks!\n\n\u003e I guess these tests aren\u0027t actually being run in the gate because of the way shelve is configured by default?\n\nI guess you are right.\nand I will post \"DO NOT MERGE\" patch for changing the related config to run this test after this patch is merged.","commit_id":"22c86f535b8af59ae48d97604210921214378b4c"}]}