)]}'
{"tempest/api/network/test_routers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1912025a5aa8fc9598df256ef18d886850f14555","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":80,"context_line":"    def test_create_delete_router_setting_tenant_id(self):"},{"line_number":81,"context_line":"        # Test creating a router from an admin user setting a tenant_id."},{"line_number":82,"context_line":"        # RoutersTest inherits from BaseAdminNetworkTest."},{"line_number":83,"context_line":"        tmp_tenant_id \u003d data_utils.rand_uuid()"},{"line_number":84,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":85,"context_line":"        resp, create_body \u003d self.admin_client.create_router("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BpBY%3D","line":82,"updated":"2014-02-20 02:38:26.000000000","message":"I don\u0027t think this line82 is necessary.\nWe can see it from line26.","commit_id":"a0c33d7f95f4bc00368ce1d8b3ea6d71e87cfd88"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7af4d57272b0aa13c0ff321abb29a8d3e46b19ae","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":80,"context_line":"    def test_create_delete_router_setting_tenant_id(self):"},{"line_number":81,"context_line":"        # Test creating a router from an admin user setting a tenant_id."},{"line_number":82,"context_line":"        # RoutersTest inherits from BaseAdminNetworkTest."},{"line_number":83,"context_line":"        tmp_tenant_id \u003d data_utils.rand_uuid()"},{"line_number":84,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":85,"context_line":"        resp, create_body \u003d self.admin_client.create_router("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Bo8w%3D","line":82,"in_reply_to":"AAAAUX%2F%2Bo%2FI%3D","updated":"2014-02-20 02:52:33.000000000","message":"Thanks for your explanation.\nHowever, current comment does not show it.\nso better to show it clearly or remove it.","commit_id":"a0c33d7f95f4bc00368ce1d8b3ea6d71e87cfd88"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"5bf1c3e9848cfefbe5b89244b9f3b9ad2e2237d5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":80,"context_line":"    def test_create_delete_router_setting_tenant_id(self):"},{"line_number":81,"context_line":"        # Test creating a router from an admin user setting a tenant_id."},{"line_number":82,"context_line":"        # RoutersTest inherits from BaseAdminNetworkTest."},{"line_number":83,"context_line":"        tmp_tenant_id \u003d data_utils.rand_uuid()"},{"line_number":84,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":85,"context_line":"        resp, create_body \u003d self.admin_client.create_router("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Bo64%3D","line":82,"in_reply_to":"AAAAUX%2F%2Bo8w%3D","updated":"2014-02-20 02:57:51.000000000","message":"thanks. removed.","commit_id":"a0c33d7f95f4bc00368ce1d8b3ea6d71e87cfd88"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"a46e070777bfe8a22d3ab8b5e56cc3a265da12eb","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":80,"context_line":"    def test_create_delete_router_setting_tenant_id(self):"},{"line_number":81,"context_line":"        # Test creating a router from an admin user setting a tenant_id."},{"line_number":82,"context_line":"        # RoutersTest inherits from BaseAdminNetworkTest."},{"line_number":83,"context_line":"        tmp_tenant_id \u003d data_utils.rand_uuid()"},{"line_number":84,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":85,"context_line":"        resp, create_body \u003d self.admin_client.create_router("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Bo%2FI%3D","line":82,"in_reply_to":"AAAAUX%2F%2BpBY%3D","updated":"2014-02-20 02:46:02.000000000","message":"thanks,Ken\u0027ichi. I actually added this line because: this test  needs admin privileges(to set the tenant_id when creating router), i just added this line here to say that. If you still think it is not necessary, i will delete this line. thanks again","commit_id":"a0c33d7f95f4bc00368ce1d8b3ea6d71e87cfd88"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4f2790bf4be78f00a5e4bc74a766e85b1d4e7bc3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":84,"context_line":"        resp, create_body \u003d self.admin_client.create_router("},{"line_number":85,"context_line":"            name, tenant_id\u003dtmp_tenant_id)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":87,"context_line":"        self.assertEqual(tmp_tenant_id, create_body[\u0027router\u0027][\u0027tenant_id\u0027])"},{"line_number":88,"context_line":"        resp, body \u003d self.admin_client.delete_router("},{"line_number":89,"context_line":"            create_body[\u0027router\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Boko%3D","line":86,"updated":"2014-02-20 04:00:30.000000000","message":"self.addCleanup(self._delete_router, create_body[\u0027router\u0027][\u0027id\u0027])\n\nis necessary before\n\n self.assertEqual(tmp_tenant_id, create_body[\u0027router\u0027][\u0027tenant_id\u0027])\n\nfor avoiding that some testing resources remain in environments.\nThe above test_create_show_list_update_delete_router also do it.\n\nSo if applying this, current line88-90 would be unnecessary.","commit_id":"b993d002333882d27f0d2b652a235ed89da32e4c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f3d41bec6bf6e7da3e418e54f5c8002d91ea379d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":84,"context_line":"        resp, create_body \u003d self.admin_client.create_router("},{"line_number":85,"context_line":"            name, tenant_id\u003dtmp_tenant_id)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":87,"context_line":"        self.assertEqual(tmp_tenant_id, create_body[\u0027router\u0027][\u0027tenant_id\u0027])"},{"line_number":88,"context_line":"        resp, body \u003d self.admin_client.delete_router("},{"line_number":89,"context_line":"            create_body[\u0027router\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BoPY%3D","line":86,"in_reply_to":"AAAAUX%2F%2BojE%3D","updated":"2014-02-20 05:10:25.000000000","message":"How about\n\n self.addCleanup(self.admin_client.delete_router, create_body[\u0027router\u0027][\u0027id\u0027])\n\n?","commit_id":"b993d002333882d27f0d2b652a235ed89da32e4c"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"b5dc534db530a7d4c4b3b1018fcc1282203aebaa","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":84,"context_line":"        resp, create_body \u003d self.admin_client.create_router("},{"line_number":85,"context_line":"            name, tenant_id\u003dtmp_tenant_id)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":87,"context_line":"        self.assertEqual(tmp_tenant_id, create_body[\u0027router\u0027][\u0027tenant_id\u0027])"},{"line_number":88,"context_line":"        resp, body \u003d self.admin_client.delete_router("},{"line_number":89,"context_line":"            create_body[\u0027router\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BojE%3D","line":86,"in_reply_to":"AAAAUX%2F%2Boko%3D","updated":"2014-02-20 04:04:26.000000000","message":"seems that u can  not use _delete_router to delete the router created by admin_client. it will complain it does not find the router. that is why i use delete_router  instead of the self._delete_router. thanks","commit_id":"b993d002333882d27f0d2b652a235ed89da32e4c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"17134928ab84f5a3aff68b929c087be8608398bf","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":80,"context_line":"    def test_create_delete_router_setting_tenant_id(self):"},{"line_number":81,"context_line":"        # Test create/delete router from admin user setting tenant_id."},{"line_number":82,"context_line":"        tmp_tenant_id \u003d data_utils.rand_uuid()"},{"line_number":83,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":84,"context_line":"        resp, create_body \u003d self.admin_client.create_router("},{"line_number":85,"context_line":"            name, tenant_id\u003dtmp_tenant_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BmnY%3D","line":82,"updated":"2014-02-20 08:56:36.000000000","message":"fake tenant id should be generated by data_utils.rand_uuid_hex()\n\n e.g. tenantId: da5bfe3448584cbfa92b174fecf25f7d\n \u003e\u003e\u003e uuid.uuid4().hex\n \u0027c8bc3872096d40c7acc08ceb9e0b7eae\u0027\n \u003e\u003e\u003e str(uuid.uuid4())\n \u002729747a59-d80a-4ab0-b0f2-c884b8197818\u0027","commit_id":"063e5301409f7e847e948e40de8f1fc77a75a129"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"4372d483448a0a45acca238891f36ebe2ae78f8e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":80,"context_line":"    def test_create_delete_router_setting_tenant_id(self):"},{"line_number":81,"context_line":"        # Test create/delete router from admin user setting tenant_id."},{"line_number":82,"context_line":"        tmp_tenant_id \u003d data_utils.rand_uuid()"},{"line_number":83,"context_line":"        name \u003d data_utils.rand_name(\u0027router-\u0027)"},{"line_number":84,"context_line":"        resp, create_body \u003d self.admin_client.create_router("},{"line_number":85,"context_line":"            name, tenant_id\u003dtmp_tenant_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BmgQ%3D","line":82,"in_reply_to":"AAAAUX%2F%2BmnY%3D","updated":"2014-02-20 09:09:24.000000000","message":"Done","commit_id":"063e5301409f7e847e948e40de8f1fc77a75a129"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7fa4624d32f57ccf2a45a035c48c2391fff7d690","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        resp, create_body \u003d self.admin_client.create_router("},{"line_number":85,"context_line":"            name, tenant_id\u003dtmp_tenant_id)"},{"line_number":86,"context_line":"        self.addCleanup(self.admin_client.delete_router,"},{"line_number":87,"context_line":"                        create_body[\u0027router\u0027][\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(tmp_tenant_id, create_body[\u0027router\u0027][\u0027tenant_id\u0027])"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2Blik%3D","line":87,"updated":"2014-02-20 10:53:03.000000000","message":"addCleanup should be added after resp[\u0027status\u0027] check for deleting a resource which is confirmed the creation.","commit_id":"07085198b8150fa973dfa3533f25de2f9ea4943e"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"a05f118782e065f937da2f38bfe50b8a6e306c13","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        resp, create_body \u003d self.admin_client.create_router("},{"line_number":85,"context_line":"            name, tenant_id\u003dtmp_tenant_id)"},{"line_number":86,"context_line":"        self.addCleanup(self.admin_client.delete_router,"},{"line_number":87,"context_line":"                        create_body[\u0027router\u0027][\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(tmp_tenant_id, create_body[\u0027router\u0027][\u0027tenant_id\u0027])"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2BkEQ%3D","line":87,"in_reply_to":"AAAAUX%2F%2Blik%3D","updated":"2014-02-20 14:09:13.000000000","message":"Done","commit_id":"07085198b8150fa973dfa3533f25de2f9ea4943e"}]}