)]}'
{"tempest/api/network/admin/test_ports.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"cd3943308b6e736ea8e27a5d488c747587e38efd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":51,"context_line":"        self.addCleanup(self.admin_ports_client.wait_for_resource_deletion,"},{"line_number":52,"context_line":"                        port[\u0027id\u0027])"},{"line_number":53,"context_line":"        self.addCleanup("},{"line_number":54,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":55,"context_line":"            self.admin_ports_client.delete_port, port[\u0027id\u0027])"},{"line_number":56,"context_line":"        host_id \u003d port[\u0027binding:host_id\u0027]"},{"line_number":57,"context_line":"        self.assertIsNotNone(host_id)"},{"line_number":58,"context_line":"        self.assertEqual(self.host_id, host_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_dc32a25e","line":55,"range":{"start_line":53,"start_character":8,"end_line":55,"end_character":60},"updated":"2020-08-30 19:51:01.000000000","message":"I can image that this could cause the problem mentioned in the linked bug - this code just calls the method (delete_port in this case) but doesn\u0027t wait for the result which could lead to a situation when port is still not deleted (e.g. waiting for backend) but tempest is already trying to delete the network ...\n\nif I\u0027m right, this should be replaced by the new code (the same for other 3 cases below)","commit_id":"0cf6d6edc3903cc77c906ab33fad2426c71127f3"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"0bd986267f6bb8324f6afa9a6a943d0991aab019","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":51,"context_line":"        self.addCleanup(self.admin_ports_client.wait_for_resource_deletion,"},{"line_number":52,"context_line":"                        port[\u0027id\u0027])"},{"line_number":53,"context_line":"        self.addCleanup("},{"line_number":54,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":55,"context_line":"            self.admin_ports_client.delete_port, port[\u0027id\u0027])"},{"line_number":56,"context_line":"        host_id \u003d port[\u0027binding:host_id\u0027]"},{"line_number":57,"context_line":"        self.assertIsNotNone(host_id)"},{"line_number":58,"context_line":"        self.assertEqual(self.host_id, host_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_df5e0a75","line":55,"range":{"start_line":53,"start_character":8,"end_line":55,"end_character":60},"in_reply_to":"9f560f44_dc32a25e","updated":"2020-08-31 14:40:49.000000000","message":"Thank you for the review but I\u0027m unable understand when you refer \"new code\". Are you saying there should only be one cleanup function called?","commit_id":"0cf6d6edc3903cc77c906ab33fad2426c71127f3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"918b299383134945f073735d705a14edd325f0a0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":51,"context_line":"        self.addCleanup(self.admin_ports_client.wait_for_resource_deletion,"},{"line_number":52,"context_line":"                        port[\u0027id\u0027])"},{"line_number":53,"context_line":"        self.addCleanup("},{"line_number":54,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":55,"context_line":"            self.admin_ports_client.delete_port, port[\u0027id\u0027])"},{"line_number":56,"context_line":"        host_id \u003d port[\u0027binding:host_id\u0027]"},{"line_number":57,"context_line":"        self.assertIsNotNone(host_id)"},{"line_number":58,"context_line":"        self.assertEqual(self.host_id, host_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_5202f10c","line":55,"range":{"start_line":53,"start_character":8,"end_line":55,"end_character":60},"in_reply_to":"9f560f44_df5e0a75","updated":"2020-08-31 15:33:25.000000000","message":"oh, I misread, never mind, it\u0027s correct as it is, thanks","commit_id":"0cf6d6edc3903cc77c906ab33fad2426c71127f3"}]}