)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66ca80f7e18afac2ed7c07cbef7766d7fcfa894f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use the correct attachment id for multiattach."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A volume attached to multiple servers has multiple attachment structures"},{"line_number":10,"context_line":"that are distinguished by their \"attachment_id\" field, not the \"id\" one."},{"line_number":11,"context_line":"So when setting up a waiter watching for an attachment being removed,"},{"line_number":12,"context_line":"the \"attachment_id\" field must be passed. Thus, when attaching a volume,"},{"line_number":13,"context_line":"it is necessary to wait until the attachment shows up in the volume\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_d826a516","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":67},"updated":"2020-09-08 19:31:42.000000000","message":"yeah, in nova we justs et volume_id as \u0027id\u0027 in attachment dict - https://github.com/openstack/nova/blob/b0c529a73d1856cec18184ca500bb095dff6b5c0/nova/api/openstack/compute/volumes.py#L247","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"7b6051bc29cadd571fab5b283113e55429bbbb0b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use the correct attachment id for multiattach."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A volume attached to multiple servers has multiple attachment structures"},{"line_number":10,"context_line":"that are distinguished by their \"attachment_id\" field, not the \"id\" one."},{"line_number":11,"context_line":"So when setting up a waiter watching for an attachment being removed,"},{"line_number":12,"context_line":"the \"attachment_id\" field must be passed. Thus, when attaching a volume,"},{"line_number":13,"context_line":"it is necessary to wait until the attachment shows up in the volume\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_825b1b52","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":67},"in_reply_to":"9f560f44_d826a516","updated":"2020-09-08 23:06:25.000000000","message":"Yep, I mentioned this in the referenced bug report, but thanks for confirming it.","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"}],"tempest/api/compute/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66ca80f7e18afac2ed7c07cbef7766d7fcfa894f","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # the attachment to be removed. For non-multiattach volumes wait for"},{"line_number":566,"context_line":"        # the state of the volume to change to available. This is so we don\u0027t"},{"line_number":567,"context_line":"        # error out when trying to delete the volume during teardown."},{"line_number":568,"context_line":"        try:"},{"line_number":569,"context_line":"            if volume[\u0027multiattach\u0027]:"},{"line_number":570,"context_line":"                att \u003d waiters.wait_for_volume_attachment_create("},{"line_number":571,"context_line":"                    self.volumes_client, volume[\u0027id\u0027], server[\u0027id\u0027])"},{"line_number":572,"context_line":"                self.addCleanup(waiters.wait_for_volume_attachment_remove,"},{"line_number":573,"context_line":"                                self.volumes_client, volume[\u0027id\u0027],"},{"line_number":574,"context_line":"                                att[\u0027attachment_id\u0027])"},{"line_number":575,"context_line":"                attachment[\u0027attachmentId\u0027] \u003d att[\u0027attachment_id\u0027]"},{"line_number":576,"context_line":"            else:"},{"line_number":577,"context_line":"                self.addCleanup(waiters.wait_for_volume_resource_status,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_78003967","line":574,"range":{"start_line":568,"start_character":0,"end_line":574,"end_character":53},"updated":"2020-09-08 19:31:42.000000000","message":"we can remove the try block here and let test fail with Timeout if attachment is failed.","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"7b6051bc29cadd571fab5b283113e55429bbbb0b","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # the attachment to be removed. For non-multiattach volumes wait for"},{"line_number":566,"context_line":"        # the state of the volume to change to available. This is so we don\u0027t"},{"line_number":567,"context_line":"        # error out when trying to delete the volume during teardown."},{"line_number":568,"context_line":"        try:"},{"line_number":569,"context_line":"            if volume[\u0027multiattach\u0027]:"},{"line_number":570,"context_line":"                att \u003d waiters.wait_for_volume_attachment_create("},{"line_number":571,"context_line":"                    self.volumes_client, volume[\u0027id\u0027], server[\u0027id\u0027])"},{"line_number":572,"context_line":"                self.addCleanup(waiters.wait_for_volume_attachment_remove,"},{"line_number":573,"context_line":"                                self.volumes_client, volume[\u0027id\u0027],"},{"line_number":574,"context_line":"                                att[\u0027attachment_id\u0027])"},{"line_number":575,"context_line":"                attachment[\u0027attachmentId\u0027] \u003d att[\u0027attachment_id\u0027]"},{"line_number":576,"context_line":"            else:"},{"line_number":577,"context_line":"                self.addCleanup(waiters.wait_for_volume_resource_status,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e2549724","line":574,"range":{"start_line":568,"start_character":0,"end_line":574,"end_character":53},"in_reply_to":"9f560f44_78003967","updated":"2020-09-08 23:06:25.000000000","message":"Done","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66ca80f7e18afac2ed7c07cbef7766d7fcfa894f","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                self.addCleanup(waiters.wait_for_volume_attachment_remove,"},{"line_number":573,"context_line":"                                self.volumes_client, volume[\u0027id\u0027],"},{"line_number":574,"context_line":"                                att[\u0027attachment_id\u0027])"},{"line_number":575,"context_line":"                attachment[\u0027attachmentId\u0027] \u003d att[\u0027attachment_id\u0027]"},{"line_number":576,"context_line":"            else:"},{"line_number":577,"context_line":"                self.addCleanup(waiters.wait_for_volume_resource_status,"},{"line_number":578,"context_line":"                                self.volumes_client, volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_18ef7db1","line":575,"range":{"start_line":575,"start_character":0,"end_line":575,"end_character":65},"updated":"2020-09-08 19:31:42.000000000","message":"do we use this anywhere? i think let\u0027s not set this and anywhere we need should be queried from cinder.","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"7b6051bc29cadd571fab5b283113e55429bbbb0b","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                self.addCleanup(waiters.wait_for_volume_attachment_remove,"},{"line_number":573,"context_line":"                                self.volumes_client, volume[\u0027id\u0027],"},{"line_number":574,"context_line":"                                att[\u0027attachment_id\u0027])"},{"line_number":575,"context_line":"                attachment[\u0027attachmentId\u0027] \u003d att[\u0027attachment_id\u0027]"},{"line_number":576,"context_line":"            else:"},{"line_number":577,"context_line":"                self.addCleanup(waiters.wait_for_volume_resource_status,"},{"line_number":578,"context_line":"                                self.volumes_client, volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c2519332","line":575,"range":{"start_line":575,"start_character":0,"end_line":575,"end_character":65},"in_reply_to":"9f560f44_18ef7db1","updated":"2020-09-08 23:06:25.000000000","message":"Done","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66ca80f7e18afac2ed7c07cbef7766d7fcfa894f","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            # Ignore 404s on detach in case the server is deleted or the volume"},{"line_number":581,"context_line":"            # is already detached."},{"line_number":582,"context_line":"            self.addCleanup(self._detach_volume, server, volume)"},{"line_number":583,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":584,"context_line":"                                                volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":585,"context_line":"        return attachment"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    def create_volume_snapshot(self, volume_id, name\u003dNone, description\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_380a4189","line":584,"range":{"start_line":583,"start_character":0,"end_line":584,"end_character":71},"updated":"2020-09-08 19:31:42.000000000","message":"so this is not required for multiattach now as L570 make sure attachment is created means volume is in-use. Let\u0027s make this API call only for non-multiattach case","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"7b6051bc29cadd571fab5b283113e55429bbbb0b","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            # Ignore 404s on detach in case the server is deleted or the volume"},{"line_number":581,"context_line":"            # is already detached."},{"line_number":582,"context_line":"            self.addCleanup(self._detach_volume, server, volume)"},{"line_number":583,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":584,"context_line":"                                                volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":585,"context_line":"        return attachment"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    def create_volume_snapshot(self, volume_id, name\u003dNone, description\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_22304f07","line":584,"range":{"start_line":583,"start_character":0,"end_line":584,"end_character":71},"in_reply_to":"9f560f44_380a4189","updated":"2020-09-08 23:06:25.000000000","message":"Done","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66ca80f7e18afac2ed7c07cbef7766d7fcfa894f","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"},{"line_number":417,"context_line":"            self.assertEqual(1, len(vol_attachments))"},{"line_number":418,"context_line":"            attachment \u003d attachments[server[\u0027id\u0027]]"},{"line_number":419,"context_line":"            del attachment[\u0027attachmentId\u0027]"},{"line_number":420,"context_line":"            self.assertDictEqual(attachment, vol_attachments[0])"},{"line_number":421,"context_line":"            # Detach the volume from this server."},{"line_number":422,"context_line":"            self._detach_multiattach_volume(volume[\u0027id\u0027], server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7835d944","line":419,"range":{"start_line":419,"start_character":0,"end_line":419,"end_character":42},"updated":"2020-09-08 19:31:42.000000000","message":"as per my comment in previous file. we do not need to delete this if we do not add it in attach_volume method","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"7b6051bc29cadd571fab5b283113e55429bbbb0b","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"},{"line_number":417,"context_line":"            self.assertEqual(1, len(vol_attachments))"},{"line_number":418,"context_line":"            attachment \u003d attachments[server[\u0027id\u0027]]"},{"line_number":419,"context_line":"            del attachment[\u0027attachmentId\u0027]"},{"line_number":420,"context_line":"            self.assertDictEqual(attachment, vol_attachments[0])"},{"line_number":421,"context_line":"            # Detach the volume from this server."},{"line_number":422,"context_line":"            self._detach_multiattach_volume(volume[\u0027id\u0027], server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6236c704","line":419,"range":{"start_line":419,"start_character":0,"end_line":419,"end_character":42},"in_reply_to":"9f560f44_7835d944","updated":"2020-09-08 23:06:25.000000000","message":"Done","commit_id":"9d62013db22505cc97ac9b4c225a22e6f7bf3ed7"}]}