)]}'
{"tempest/api/compute/servers/test_delete_server.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4d59858eb0b2b0bb335d1b9f56f4b006c722f822","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":89,"context_line":"    def test_delete_server_while_in_attached_volume(self):"},{"line_number":90,"context_line":"        # Delete a server while it is attached with volume"},{"line_number":91,"context_line":"        volumes_client \u003d self.volumes_extensions_client"},{"line_number":92,"context_line":"        resp, server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2Fs3Y%3D","line":90,"updated":"2014-03-04 15:56:39.000000000","message":"I think you should formulate the other way round: \"delete a server while a volume is attached to it\". Just a nit-pick but you usually consider that it\u0027s the volume that is attached to a server.","commit_id":"0b712b0abe10bec9b63dd5e0acf8d37e9fd3a1a2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"775c589ca0d56415ef90cb850f6f80d007d34dac","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":89,"context_line":"    def test_delete_server_while_in_attached_volume(self):"},{"line_number":90,"context_line":"        # Delete a server while it is attached with volume"},{"line_number":91,"context_line":"        volumes_client \u003d self.volumes_extensions_client"},{"line_number":92,"context_line":"        resp, server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FOxs%3D","line":90,"in_reply_to":"AAAAVn%2F%2Fs3Y%3D","updated":"2014-03-07 13:04:54.000000000","message":"Thanks for good point. I will apply it.","commit_id":"0b712b0abe10bec9b63dd5e0acf8d37e9fd3a1a2"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4d59858eb0b2b0bb335d1b9f56f4b006c722f822","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        resp, _ \u003d self.client.delete_server(server[\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":104,"context_line":"        self.client.wait_for_server_termination(server[\u0027id\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class DeleteServersAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2Fs28%3D","line":104,"updated":"2014-03-04 15:56:39.000000000","message":"Would it make sense to also test that the volume is switched back to \"available\" ?","commit_id":"0b712b0abe10bec9b63dd5e0acf8d37e9fd3a1a2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"775c589ca0d56415ef90cb850f6f80d007d34dac","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        resp, _ \u003d self.client.delete_server(server[\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":104,"context_line":"        self.client.wait_for_server_termination(server[\u0027id\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class DeleteServersAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FOxg%3D","line":104,"in_reply_to":"AAAAVn%2F%2Fs28%3D","updated":"2014-03-07 13:04:54.000000000","message":"Nice idea, I\u0027d like to test it.\nThank you very much!","commit_id":"0b712b0abe10bec9b63dd5e0acf8d37e9fd3a1a2"}],"tempest/api/compute/v3/servers/test_delete_server.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"34db8f49aad72388ce2aacdc2fe031b8afba1da3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":110,"context_line":"        resp, body \u003d self.client.attach_volume(server[\u0027id\u0027],"},{"line_number":111,"context_line":"                                               volume[\u0027id\u0027],"},{"line_number":112,"context_line":"                                               device\u003d\u0027/dev/vdb\u0027)"},{"line_number":113,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, _ \u003d self.client.delete_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B8pk%3D","line":112,"updated":"2014-03-21 13:22:43.000000000","message":"does the device need to be a parameter? I\u0027m concerned about hardcoding it.","commit_id":"945b40a172bfe6b367532faa5b725009301b4df8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"514923538b5c7f6b867c94837c5425ccb83e9f15","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":110,"context_line":"        resp, body \u003d self.client.attach_volume(server[\u0027id\u0027],"},{"line_number":111,"context_line":"                                               volume[\u0027id\u0027],"},{"line_number":112,"context_line":"                                               device\u003d\u0027/dev/vdb\u0027)"},{"line_number":113,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, _ \u003d self.client.delete_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B0ok%3D","line":112,"in_reply_to":"AAAAWH%2F%2B8pk%3D","updated":"2014-03-24 01:34:32.000000000","message":"Nice catch, thanks.\n\nWe should use CONF.compute.volume_device_name for here. I will fix it in the next patch.","commit_id":"945b40a172bfe6b367532faa5b725009301b4df8"}]}