)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2befcd222f2f88e1daa1d80460d0510f3fa51a4b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added apis to scenario manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tempest plugins do use associate_floating_ip() and"},{"line_number":10,"context_line":"_disassociate_floating_ip() api but scenario-"},{"line_number":11,"context_line":"manager doesn\u0027t implement it."},{"line_number":12,"context_line":"Hence, added it to the scenario manager"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_4bdfee65","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":27},"updated":"2020-09-29 20:42:23.000000000","message":"it will be good to add what all plugins need these? and then we make a decision if that is worth to maintain in tempest or plugin side.","commit_id":"d83eb55c80d2b3774d690ff4ecbbae55ec7a1894"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e3e049186e7322b735b07a150044d93ddc1675d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Tempest plugins do use associate_floating_ip() and"},{"line_number":10,"context_line":"disassociate_floating_ip() api but scenario-"},{"line_number":11,"context_line":"manager doesn\u0027t implement it."},{"line_number":12,"context_line":"The plugins using these apis are manila, tap,"},{"line_number":13,"context_line":"vmware-nsx."},{"line_number":14,"context_line":"Hence, added it to the scenario manager"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_6143e140","line":12,"range":{"start_line":12,"start_character":33,"end_line":12,"end_character":39},"updated":"2020-09-30 21:02:47.000000000","message":"manila-tempest-plugin","commit_id":"64502777b0f548bbd90613247d783c8b12faebf9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"59ff85bdf91c10f866a1839f75bd9bbeea759941","unresolved":false,"context_lines":[{"line_number":10,"context_line":"disassociate_floating_ip() api but scenario-"},{"line_number":11,"context_line":"manager doesn\u0027t implement it."},{"line_number":12,"context_line":"The plugins using these apis are manila, tap,"},{"line_number":13,"context_line":"vmware-nsx."},{"line_number":14,"context_line":"Hence, added it to the scenario manager"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint tempest-scenario-manager-stable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_9f31320e","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":11},"updated":"2020-09-30 15:18:18.000000000","message":"and neutron-tempest-plugin too","commit_id":"64502777b0f548bbd90613247d783c8b12faebf9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e3e049186e7322b735b07a150044d93ddc1675d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"disassociate_floating_ip() api but scenario-"},{"line_number":11,"context_line":"manager doesn\u0027t implement it."},{"line_number":12,"context_line":"The plugins using these apis are manila, tap,"},{"line_number":13,"context_line":"vmware-nsx."},{"line_number":14,"context_line":"Hence, added it to the scenario manager"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint tempest-scenario-manager-stable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_2139e9ce","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":11},"in_reply_to":"9f560f44_9f31320e","updated":"2020-09-30 21:02:47.000000000","message":"+1, let add this too in this list.","commit_id":"64502777b0f548bbd90613247d783c8b12faebf9"}],"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"92c0e655ca342dcff3e1f6c7e6b41ac29ef47de5","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            floating_ip[\u0027ip\u0027], server[\u0027id\u0027])"},{"line_number":816,"context_line":"        return floating_ip"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def _associate_floating_ip(self, floating_ip, server):"},{"line_number":819,"context_line":"        \"\"\"Associate floating ip"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        This wrapper utility attaches the floating_ip for"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9a622515","line":818,"range":{"start_line":818,"start_character":8,"end_line":818,"end_character":9},"updated":"2020-09-25 17:26:11.000000000","message":"Do we want these new methods private? They are not used in our manager.py and their main purpose is to actually create an interface for the plugins. If the methods are expected to be used by third parties, they should not be private.","commit_id":"ec20a58c8f29c8cd380931775f616e416ec9e133"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"92c0e655ca342dcff3e1f6c7e6b41ac29ef47de5","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    def _disassociate_floating_ip(self, floating_ip):"},{"line_number":832,"context_line":"        \"\"\"Disassociates floating ip"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        This utility checks whether the respective floating_ip"},{"line_number":835,"context_line":"        exists or not."},{"line_number":836,"context_line":"        :param floating_ip: floating_ips_client.create_floatingip"},{"line_number":837,"context_line":"        \"\"\""},{"line_number":838,"context_line":"        kwargs \u003d dict(port_id\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fafd213b","line":835,"range":{"start_line":834,"start_character":8,"end_line":835,"end_character":22},"updated":"2020-09-25 17:26:11.000000000","message":"but it\u0027s primary purpose is to disassociate floating ip, not to check if it exists or not ... maybe we could write here something similar like on line 821:\n\n\"This wrapper utility disassociates given floating ip.","commit_id":"ec20a58c8f29c8cd380931775f616e416ec9e133"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"92c0e655ca342dcff3e1f6c7e6b41ac29ef47de5","unresolved":false,"context_lines":[{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        This utility checks whether the respective floating_ip"},{"line_number":835,"context_line":"        exists or not."},{"line_number":836,"context_line":"        :param floating_ip: floating_ips_client.create_floatingip"},{"line_number":837,"context_line":"        \"\"\""},{"line_number":838,"context_line":"        kwargs \u003d dict(port_id\u003dNone)"},{"line_number":839,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_050d1a34","line":836,"range":{"start_line":836,"start_character":28,"end_line":836,"end_character":65},"updated":"2020-09-25 17:26:11.000000000","message":"I find this misleading, the param is not supposed to be the floating_ips_client.create_floatingip method (we can pass methods as arguments as well). floating_ip param is supposed to be a dict which is a return value of floating_ips_client.create_floatingip method.","commit_id":"ec20a58c8f29c8cd380931775f616e416ec9e133"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e3e049186e7322b735b07a150044d93ddc1675d","unresolved":false,"context_lines":[{"line_number":824,"context_line":"            floating_ip[\u0027ip\u0027], server[\u0027id\u0027])"},{"line_number":825,"context_line":"        return floating_ip"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    def associate_floating_ip(self, floating_ip, server):"},{"line_number":828,"context_line":"        \"\"\"Associate floating ip"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        This wrapper utility attaches the floating_ip for"},{"line_number":831,"context_line":"        the respective port_id of server"},{"line_number":832,"context_line":"        \"\"\""},{"line_number":833,"context_line":"        port_id, _ \u003d self._get_server_port_id_and_ip4(server)"},{"line_number":834,"context_line":"        kwargs \u003d dict(port_id\u003dport_id)"},{"line_number":835,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":836,"context_line":"            floating_ip[\u0027id\u0027], **kwargs)[\u0027floatingip\u0027]"},{"line_number":837,"context_line":"        self.assertEqual(port_id, floating_ip[\u0027port_id\u0027])"},{"line_number":838,"context_line":"        return floating_ip"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def disassociate_floating_ip(self, floating_ip):"},{"line_number":841,"context_line":"        \"\"\"Disassociates floating ip"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        This wrapper utility disassociates given floating ip."},{"line_number":844,"context_line":"        :param floating_ip: a dict which is a return value of"},{"line_number":845,"context_line":"        floating_ips_client.create_floatingip method"},{"line_number":846,"context_line":"        \"\"\""},{"line_number":847,"context_line":"        kwargs \u003d dict(port_id\u003dNone)"},{"line_number":848,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":849,"context_line":"            floating_ip[\u0027id\u0027], **kwargs)[\u0027floatingip\u0027]"},{"line_number":850,"context_line":"        self.assertIsNone(floating_ip[\u0027port_id\u0027])"},{"line_number":851,"context_line":"        return floating_ip"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def create_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":854,"context_line":"                         private_key\u003dNone, server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_01530518","line":851,"range":{"start_line":827,"start_character":0,"end_line":851,"end_character":26},"updated":"2020-09-30 21:02:47.000000000","message":"In create_floating_ip() method at L813 do associate the floating IP to server which is basically compute API testing. \n\nAs these are attaching the FIP via neutron API, let\u0027s move these to L1165","commit_id":"64502777b0f548bbd90613247d783c8b12faebf9"}]}