)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4e540fb2246fe37dc4f50c8ec38b1f31e954b87f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    # The create_[resource] functions only return body and discard the"},{"line_number":143,"context_line":"    # resp part which is not used in scenario tests"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def create_port(self, network_id, client\u003dNone, namestart\u003d\u0027port-quotatest\u0027,"},{"line_number":146,"context_line":"                    **kwargs):"},{"line_number":147,"context_line":"        \"\"\"Creates port for the respective network_id\"\"\""},{"line_number":148,"context_line":"        if not client:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ca6dea99","line":145,"range":{"start_line":145,"start_character":62,"end_line":145,"end_character":76},"updated":"2020-09-25 17:30:49.000000000","message":"i\u0027d rather leave here the original value \u003d self.__class__.__name__ \n\nthat way the method won\u0027t change behavior from tempest point of view (from our scenario tests) however will allow to override the namestart from plugins .. so at the end behavior of the method is not changed for tempest itself and its plugins too.","commit_id":"eb21f902c29d039fcb526007611117de7d76f81f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9c359de8ccd9c055de9ea6f6923672677e420150","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        \"\"\"Creates port for the respective network_id\"\"\""},{"line_number":147,"context_line":"        if not client:"},{"line_number":148,"context_line":"            client \u003d self.ports_client"},{"line_number":149,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":150,"context_line":"        if CONF.network.port_vnic_type and \u0027binding:vnic_type\u0027 not in kwargs:"},{"line_number":151,"context_line":"            kwargs[\u0027binding:vnic_type\u0027] \u003d CONF.network.port_vnic_type"},{"line_number":152,"context_line":"        if CONF.network.port_profile and \u0027binding:profile\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_ad2a158e","line":149,"range":{"start_line":149,"start_character":36,"end_line":149,"end_character":59},"updated":"2020-09-30 13:04:52.000000000","message":"we should add here a possibility to override this because some of the plugins use namestart argument to set the string rand name is generated from, f.e. neutron plugin: https://opendev.org/openstack/neutron-tempest-plugin/src/commit/ff09b50d54acf36550238b2e73f8f3c360be1ee6/neutron_tempest_plugin/bgpvpn/scenario/manager.py#L65\n\nkwargs.get(\u0027namestart\u0027, self.__class__.__name__) should work","commit_id":"ead5c07bf7c8ae928c2de72564057bbd6f7a75b5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fe12ca129917662413d0100506606924ee5c1b5d","unresolved":true,"context_lines":[{"line_number":146,"context_line":"        \"\"\"Creates port for the respective network_id\"\"\""},{"line_number":147,"context_line":"        if not client:"},{"line_number":148,"context_line":"            client \u003d self.ports_client"},{"line_number":149,"context_line":"        name \u003d kwargs.get(\u0027namestart\u0027, self.__class__.__name__)"},{"line_number":150,"context_line":"        if CONF.network.port_vnic_type and \u0027binding:vnic_type\u0027 not in kwargs:"},{"line_number":151,"context_line":"            kwargs[\u0027binding:vnic_type\u0027] \u003d CONF.network.port_vnic_type"},{"line_number":152,"context_line":"        if CONF.network.port_profile and \u0027binding:profile\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a8bbf43f_ca47322e","line":149,"range":{"start_line":149,"start_character":22,"end_line":149,"end_character":25},"updated":"2020-11-27 13:08:49.000000000","message":"it\u0027d be better to use \u0027pop\u0027 here so that we get rid of that parameter from kwargs and don\u0027t pass it twice to the create_port client. I\u0027m sorry, I didn\u0027t thought of that before when I wrote the previous comment.","commit_id":"8b26c04320d0a8a4439356d1fec3c9dd103ce35d"}]}