)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43e486a1b444d91b7df2454855d70dbd6ac6e7f4","unresolved":true,"context_lines":[{"line_number":410,"context_line":"                                           server_id, \u0027ACTIVE\u0027)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def create_volume_snapshot(self, volume_id, name\u003dNone, description\u003dNone,"},{"line_number":413,"context_line":"                               metadata\u003dNone, force\u003dFalse):"},{"line_number":414,"context_line":"        \"\"\"Creates volume"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        This wrapper utility creates volume snapshot and waits for backup"}],"source_content_type":"text/x-python","patch_set":2,"id":"2d6b04e0_0fd9342f","side":"PARENT","line":413,"range":{"start_line":413,"start_character":57,"end_line":413,"end_character":58},"updated":"2020-11-26 00:30:14.000000000","message":"let\u0027s just add **kwargs here so that existing kwargs are known by client by this func signature.","commit_id":"20c87c795274e9706f13d6833f5b02a70a1ed887"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4205467a1f0b17be93fa185673ed55094eeab12","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                                           server_id, \u0027ACTIVE\u0027)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def create_volume_snapshot(self, volume_id, name\u003dNone, description\u003dNone,"},{"line_number":413,"context_line":"                               metadata\u003dNone, force\u003dFalse):"},{"line_number":414,"context_line":"        \"\"\"Creates volume"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        This wrapper utility creates volume snapshot and waits for backup"}],"source_content_type":"text/x-python","patch_set":2,"id":"588c8871_94b26af1","side":"PARENT","line":413,"range":{"start_line":413,"start_character":57,"end_line":413,"end_character":58},"in_reply_to":"19acabcd_0a140e0a","updated":"2020-11-26 09:49:11.000000000","message":"Done","commit_id":"20c87c795274e9706f13d6833f5b02a70a1ed887"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"da1901ad06f10768b1d8098cb756470ff7ee624a","unresolved":true,"context_lines":[{"line_number":410,"context_line":"                                           server_id, \u0027ACTIVE\u0027)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def create_volume_snapshot(self, volume_id, name\u003dNone, description\u003dNone,"},{"line_number":413,"context_line":"                               metadata\u003dNone, force\u003dFalse):"},{"line_number":414,"context_line":"        \"\"\"Creates volume"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        This wrapper utility creates volume snapshot and waits for backup"}],"source_content_type":"text/x-python","patch_set":2,"id":"19acabcd_0a140e0a","side":"PARENT","line":413,"range":{"start_line":413,"start_character":57,"end_line":413,"end_character":58},"in_reply_to":"2d6b04e0_0fd9342f","updated":"2020-11-26 00:33:20.000000000","message":"that way is easy to use the function otherwise user needs to refer the api-ref for commonly known kwargs too","commit_id":"20c87c795274e9706f13d6833f5b02a70a1ed887"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43e486a1b444d91b7df2454855d70dbd6ac6e7f4","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        \"\"\"Creates volume"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        This wrapper utility creates volume snapshot and waits for backup"},{"line_number":416,"context_line":"        to be in \u0027available\u0027 state."},{"line_number":417,"context_line":"        \"\"\""},{"line_number":418,"context_line":"        if not kwargs.get(\u0027name\u0027):"},{"line_number":419,"context_line":"            namestart \u003d self.__class__.__name__ + \u0027-snapshot\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"20c086bf_61c7709c","line":416,"range":{"start_line":416,"start_character":34,"end_line":416,"end_character":35},"updated":"2020-11-26 00:30:14.000000000","message":"we can add doc string also for existing kwargs and the api-ref link to know other kwargsthis API allow","commit_id":"cd35ec193b7a6d5b5f948615952baa1655670949"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4205467a1f0b17be93fa185673ed55094eeab12","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        \"\"\"Creates volume"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        This wrapper utility creates volume snapshot and waits for backup"},{"line_number":416,"context_line":"        to be in \u0027available\u0027 state."},{"line_number":417,"context_line":"        \"\"\""},{"line_number":418,"context_line":"        if not kwargs.get(\u0027name\u0027):"},{"line_number":419,"context_line":"            namestart \u003d self.__class__.__name__ + \u0027-snapshot\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"954b73c0_29d1567b","line":416,"range":{"start_line":416,"start_character":34,"end_line":416,"end_character":35},"in_reply_to":"20c086bf_61c7709c","updated":"2020-11-26 09:49:11.000000000","message":"Done","commit_id":"cd35ec193b7a6d5b5f948615952baa1655670949"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b57e35f7c75529c33873e78c10a771c12829e81f","unresolved":true,"context_lines":[{"line_number":420,"context_line":"        :param name: name of the snapshot, \u0027$classname-snapshot\u0027 by default"},{"line_number":421,"context_line":"        :param description: description of the snapshot"},{"line_number":422,"context_line":"        :param metadata: metadata key and value pairs for the snapshot"},{"line_number":423,"context_line":"        :param force: whether backup even when the volume is attached"},{"line_number":424,"context_line":"        :param **kwargs: additional parameters per the doc"},{"line_number":425,"context_line":"            https://docs.openstack.org/api-ref/block-storage/v3/"},{"line_number":426,"context_line":"            #create-a-snapshot"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c48e547_56d13900","line":423,"range":{"start_line":423,"start_character":22,"end_line":423,"end_character":37},"updated":"2020-12-10 07:32:12.000000000","message":"I wonder if the api doc is not so accurate...\nBTW, there seems no other parameters except these ones:)","commit_id":"aa907178a9f7a0f856030216e5ddcecd60fb6aef"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9c267fb8380092d8ce914a8b3d2f8de31018db87","unresolved":true,"context_lines":[{"line_number":420,"context_line":"        :param name: name of the snapshot, \u0027$classname-snapshot\u0027 by default"},{"line_number":421,"context_line":"        :param description: description of the snapshot"},{"line_number":422,"context_line":"        :param metadata: metadata key and value pairs for the snapshot"},{"line_number":423,"context_line":"        :param force: whether backup even when the volume is attached"},{"line_number":424,"context_line":"        :param **kwargs: additional parameters per the doc"},{"line_number":425,"context_line":"            https://docs.openstack.org/api-ref/block-storage/v3/"},{"line_number":426,"context_line":"            #create-a-snapshot"}],"source_content_type":"text/x-python","patch_set":3,"id":"feca794a_c5eb6395","line":423,"range":{"start_line":423,"start_character":22,"end_line":423,"end_character":37},"in_reply_to":"8c48e547_56d13900","updated":"2021-02-09 17:08:22.000000000","message":"what is not so accurate? \nyeah, at least not now, but when we\u0027re adding kwargs almost everywhere ..","commit_id":"aa907178a9f7a0f856030216e5ddcecd60fb6aef"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8ddd054b32d661115de24cb5359ac05c2d40f777","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        :param name: name of the snapshot, \u0027$classname-snapshot\u0027 by default"},{"line_number":421,"context_line":"        :param description: description of the snapshot"},{"line_number":422,"context_line":"        :param metadata: metadata key and value pairs for the snapshot"},{"line_number":423,"context_line":"        :param force: whether backup even when the volume is attached"},{"line_number":424,"context_line":"        :param **kwargs: additional parameters per the doc"},{"line_number":425,"context_line":"            https://docs.openstack.org/api-ref/block-storage/v3/"},{"line_number":426,"context_line":"            #create-a-snapshot"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b38cfc6_4b352ab3","line":423,"range":{"start_line":423,"start_character":22,"end_line":423,"end_character":37},"in_reply_to":"aa1b0efb_dde75dfc","updated":"2021-02-11 20:54:28.000000000","message":"oh, i see, i didn\u0027t notice that, thanks","commit_id":"aa907178a9f7a0f856030216e5ddcecd60fb6aef"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e88ae27825c17dcc5482835bd7487bcf4fec98ba","unresolved":true,"context_lines":[{"line_number":420,"context_line":"        :param name: name of the snapshot, \u0027$classname-snapshot\u0027 by default"},{"line_number":421,"context_line":"        :param description: description of the snapshot"},{"line_number":422,"context_line":"        :param metadata: metadata key and value pairs for the snapshot"},{"line_number":423,"context_line":"        :param force: whether backup even when the volume is attached"},{"line_number":424,"context_line":"        :param **kwargs: additional parameters per the doc"},{"line_number":425,"context_line":"            https://docs.openstack.org/api-ref/block-storage/v3/"},{"line_number":426,"context_line":"            #create-a-snapshot"}],"source_content_type":"text/x-python","patch_set":3,"id":"aa1b0efb_dde75dfc","line":423,"range":{"start_line":423,"start_character":22,"end_line":423,"end_character":37},"in_reply_to":"feca794a_c5eb6395","updated":"2021-02-11 20:49:39.000000000","message":"this flag allow in-use volume to snapshot - https://github.com/openstack/cinder/blob/cc21a5d95b73c3fffe9385f691fe1bc83d51ee57/cinder/volume/api.py#L882\n\nI think zhufl point is that api doc mention this as \u0027backup\u0027 not \u0027snapshot\u0027. at least we can fix here.","commit_id":"aa907178a9f7a0f856030216e5ddcecd60fb6aef"}]}