)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e709d6906b2d7a6ae77a1a501535bdc8f2e5a2c8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This test will enable the config drive and attach"},{"line_number":10,"context_line":"the volume to the instance that is boot up using"},{"line_number":11,"context_line":"the custom image property for scsi disk."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #186705"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9c7be55aaa363860a78d2efe2a4685433777625b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f65232a_8ce80d17","line":12,"updated":"2020-10-21 22:24:20.000000000","message":"The commit message would need more context, I feel. Sure, we can read the related bug, but it won\u0027t hurt to explain it a bit more here.\n\nThe issue is that Nova used to only consider an instance\u0027s existing volumes when finding the next available SCSI address when attaching a volume. So if the instance had a config drive in the shape of a SCSI CDROM, its SCSI address would get ignored in the new address calculation, there would be an address collision in the XML, and libvirt would complain.\n\nThis tempest test checks that even with a SCSI CDROM, we can attach SCSI volumes to an instance without issue.","commit_id":"1235d19601039140d00ad1b46d60a63c801d0e2a"}],"tempest/api/compute/admin/test_volume.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e709d6906b2d7a6ae77a1a501535bdc8f2e5a2c8","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        Enable the config drive, followed by booting an instance"},{"line_number":78,"context_line":"        from an image with virtio-scsi and hw_cdrom: scsi property"},{"line_number":79,"context_line":"        and validate the attach/detach of the volume"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        custom_img \u003d self._create_image_with_custom_property("},{"line_number":82,"context_line":"            hw_scsi_model\u003d\u0027virtio-scsi\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_6cedb124","line":79,"updated":"2020-10-21 22:24:20.000000000","message":"The docstring here could also use expanding.","commit_id":"1235d19601039140d00ad1b46d60a63c801d0e2a"},{"author":{"_account_id":31706,"name":"Yingji Sun","email":"yingjisun@vmware.com","username":"yingjisun"},"change_message_id":"e8c13c637abe5574fa2ac03e36f4d268277e92f2","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        in instance after attach and detach of the volume."},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        custom_img \u003d self._create_image_with_custom_property("},{"line_number":83,"context_line":"            hw_scsi_model\u003d\u0027virtio-scsi\u0027,"},{"line_number":84,"context_line":"            hw_disk_bus\u003d\u0027scsi\u0027,"},{"line_number":85,"context_line":"            hw_cdrom_bus\u003d\u0027scsi\u0027)"},{"line_number":86,"context_line":"        server \u003d self.create_test_server(image_id\u003dcustom_img,"}],"source_content_type":"text/x-python","patch_set":3,"id":"977ac98c_b3127b30","line":83,"updated":"2020-12-08 07:53:37.000000000","message":"\u0027virtio-scsi\u0027 does not work on vmware setup. \u0027lsilogic\u0027 is a valid value.","commit_id":"0d62208241872bb0d131312b3af79e85e28ff231"}]}
