)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1431560c25d4a988ecb45d7169682f1b043f4988","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lukas Piwowarski \u003clpiwowar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-30 10:45:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow kwargs in nova_attach_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a part of the scenario/manager.py stabilization tracked by"},{"line_number":10,"context_line":"the below BP the patch adds kwargs argument for nova_attach_volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_8563a5dc","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":34},"updated":"2020-10-30 19:47:45.000000000","message":"nit: nova_volume_attach","commit_id":"c8446b950ed2b81a60226c29c9188ee545d70e44"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1431560c25d4a988ecb45d7169682f1b043f4988","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow kwargs in nova_attach_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a part of the scenario/manager.py stabilization tracked by"},{"line_number":10,"context_line":"the below BP the patch adds kwargs argument for nova_attach_volume"},{"line_number":11,"context_line":"method so that the consumers are able to pass additional"},{"line_number":12,"context_line":"parameters if needed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_656009d0","line":10,"range":{"start_line":10,"start_character":48,"end_line":10,"end_character":66},"updated":"2020-10-30 19:47:45.000000000","message":"nit: nova_volume_attach","commit_id":"c8446b950ed2b81a60226c29c9188ee545d70e44"}],"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1431560c25d4a988ecb45d7169682f1b043f4988","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        self.assertEqual(volume_to_attach[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":710,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":711,"context_line":"                                                volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":712,"context_line":"        # Return the updated volume after the attachment"},{"line_number":713,"context_line":"        return self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    def nova_volume_detach(self, server, volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_25473120","line":712,"range":{"start_line":712,"start_character":7,"end_line":712,"end_character":8},"updated":"2020-10-30 19:47:45.000000000","message":"add please after the waiter a cleanup call like this:\nself.addCleanup(self.nova_volume_detach, server, volume)\n\nit was added f.e. in barbican by https://review.opendev.org/#/c/556800 to solve a bug","commit_id":"c8446b950ed2b81a60226c29c9188ee545d70e44"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ea6ddd4f5130c9648518b589656c4f0dcef03fe5","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        self.assertEqual(volume_to_attach[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":710,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":711,"context_line":"                                                volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":712,"context_line":"        self.addCleanup(self.nova_volume_detach, server, volume)"},{"line_number":713,"context_line":"        # Return the updated volume after the attachment"},{"line_number":714,"context_line":"        return self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_7f77a403","line":712,"updated":"2020-11-06 10:24:19.000000000","message":"add test_utils.call_and_ignore_notfound_exc as the first argument, the other methods here in manager.py have it too","commit_id":"3aa0b68b93926c41b34885b88262cbc32b0cb8b9"}]}