)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0af556ed8ae5956cd480bd44df27aa35def76dfb","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        return floating_ip"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    def create_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":828,"context_line":"                         private_key\u003dNone, server\u003dNone, **kwargs):"},{"line_number":829,"context_line":"        \"\"\"Creates timestamp"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        This wrapper utility does ssh, creates timestamp and returns the"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_13ede824","line":828,"range":{"start_line":828,"start_character":55,"end_line":828,"end_character":64},"updated":"2020-11-04 13:54:52.000000000","message":"I\u0027m thinking if this is the right case for kwargs. Maybe in this case it would make more sense to just add new arguments (username and fs) as they would be used in two different calls (get_remote_client and ssh_client.make_fs).","commit_id":"ff773a97ef0c678489e057ef4bce563afcbcc86b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0af556ed8ae5956cd480bd44df27aa35def76dfb","unresolved":false,"context_lines":[{"line_number":853,"context_line":"        return timestamp"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    def get_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":856,"context_line":"                      private_key\u003dNone, server\u003dNone):"},{"line_number":857,"context_line":"        \"\"\"Returns timestamp"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        This wrapper utility does ssh and returns the timestamp."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_47bb390d","line":856,"range":{"start_line":856,"start_character":51,"end_line":856,"end_character":52},"updated":"2020-11-04 13:54:52.000000000","message":"what about username arg here?","commit_id":"ff773a97ef0c678489e057ef4bce563afcbcc86b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ef9b7b143b694c0111415969018f60f8523a4cbe","unresolved":false,"context_lines":[{"line_number":853,"context_line":"        return timestamp"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    def get_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":856,"context_line":"                      private_key\u003dNone, server\u003dNone):"},{"line_number":857,"context_line":"        \"\"\"Returns timestamp"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        This wrapper utility does ssh and returns the timestamp."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_77b23a96","line":856,"range":{"start_line":856,"start_character":51,"end_line":856,"end_character":52},"in_reply_to":"1f621f24_47bb390d","updated":"2020-11-05 12:51:22.000000000","message":"never mind, there is another review for this: https://review.opendev.org/#/c/760534","commit_id":"ff773a97ef0c678489e057ef4bce563afcbcc86b"}]}