)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7db5c86243ffae4be17cda0e25d96899cf0c1755","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"                fixed_ips\u003d\u0027ip_address\u003d%s\u0027 % ip_addr, **kwargs)[\u0027ports\u0027]"},{"line_number":1071,"context_line":"        else:"},{"line_number":1072,"context_line":"            ports \u003d self.os_admin.ports_client.list_ports("},{"line_number":1073,"context_line":"                device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027]"},{"line_number":1074,"context_line":"        # A port can have more than one IP address in some cases."},{"line_number":1075,"context_line":"        # If the network is dual-stack (IPv4 + IPv6), this port is associated"},{"line_number":1076,"context_line":"        # with 2 subnets"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_45bcba68","line":1073,"range":{"start_line":1073,"start_character":38,"end_line":1073,"end_character":39},"updated":"2020-11-04 12:41:46.000000000","message":"\u0027**kwargs\u0027 should go here as well, shouldn\u0027t it?\n\nAlso this if else condition could be simplified by adding\nfixed_ips to kwargs if ip_addr -\u003e\n```\nif ip_addr and not kwargs.get(\u0027fixed_ips\u0027):\n    kwargs[\u0027fixed_ips\u0027] \u003d \u0027ip_address\u003d%s\u0027 % ip_addr\nports \u003d self.os_admin.ports_client.list_ports(\n    device_id\u003dserver[\u0027id\u0027], **kwargs)[\u0027ports\u0027]\n```","commit_id":"d8097a2cb74568824c10650f2a3089d362274174"}]}