)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7d21f12306a715b5441294204aed3feea11082bb","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        return timestamp"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def get_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":851,"context_line":"                      private_key\u003dNone, server\u003dNone, **kwargs):"},{"line_number":852,"context_line":"        \"\"\"Returns timestamp"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        This wrapper utility does ssh and returns the timestamp."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_c54baaad","line":851,"range":{"start_line":851,"start_character":22,"end_line":851,"end_character":51},"updated":"2020-11-04 12:27:28.000000000","message":"we could squash these two arguments into kwargs because there is no further logic dealing with these two - they simply passed to get_remote_client() \n\nAlso this method is used mainly by us: \nhttp://codesearch.openstack.org/?q\u003d%5C.get_timestamp%5C(\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\nAll the usages of this method are done properly (optional arguments are assigned by name, f.e. private_key\u003d\u003ckey\u003e etc) which allows us to squash private_key and server arguments into kwargs without any additional changes in places the method is called from.","commit_id":"f519ec604c8b814cf1a49a17e131998c82ca9218"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"60b0efd94bdd199ab0860a0bd3305b66073a9cc0","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        return timestamp"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def get_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":851,"context_line":"                      private_key\u003dNone, server\u003dNone, **kwargs):"},{"line_number":852,"context_line":"        \"\"\"Returns timestamp"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        This wrapper utility does ssh and returns the timestamp."}],"source_content_type":"text/x-python","patch_set":1,"id":"02c5d28e_54c2cb1b","line":851,"range":{"start_line":851,"start_character":22,"end_line":851,"end_character":51},"in_reply_to":"1f621f24_c54baaad","updated":"2020-11-26 00:31:56.000000000","message":"I think easy usage is to mention all kwargs by name if not many like in this case. let\u0027s add username explicitly like you are adding for create_timestamp in other patch","commit_id":"f519ec604c8b814cf1a49a17e131998c82ca9218"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"60b0efd94bdd199ab0860a0bd3305b66073a9cc0","unresolved":true,"context_lines":[{"line_number":852,"context_line":"        \"\"\"Returns timestamp"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        This wrapper utility does ssh and returns the timestamp."},{"line_number":855,"context_line":"        \"\"\""},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        ssh_client \u003d self.get_remote_client(ip_address,"},{"line_number":858,"context_line":"                                            private_key\u003dprivate_key,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e48d41b9_cecdba5c","line":855,"range":{"start_line":855,"start_character":10,"end_line":855,"end_character":11},"updated":"2020-11-26 00:31:56.000000000","message":"you can add doc string also for param","commit_id":"f519ec604c8b814cf1a49a17e131998c82ca9218"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a2691dcae1465d54dd39a856e4b3086827c1b347","unresolved":true,"context_lines":[{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def get_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":851,"context_line":"                      private_key\u003dNone, server\u003dNone, username\u003dNone):"},{"line_number":852,"context_line":"        \"\"\"Returns timestamp"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        This wrapper utility does ssh and returns the timestamp."},{"line_number":855,"context_line":"        \"\"\""},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        ssh_client \u003d self.get_remote_client(ip_address,"}],"source_content_type":"text/x-python","patch_set":3,"id":"129159e4_3eacb2dd","line":854,"range":{"start_line":852,"start_character":0,"end_line":854,"end_character":64},"updated":"2020-11-26 16:29:25.000000000","message":"let\u0027s add doc string also for those params","commit_id":"7c4ab3de7d31f00e2d88338d63be87be65e9ce36"}]}