)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"848788c898136a25e64547a9dd1f3ab1b40c80ad","unresolved":false,"context_lines":[{"line_number":10,"context_line":"base class is deleting the images."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Ref:"},{"line_number":13,"context_line":"https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L122"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I602c1dfb8ab85be6c1e722259210cf3d25fb437a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAU3%2F%2Ftis%3D","line":13,"updated":"2014-02-25 05:43:01.000000000","message":"better to avoid writing a github url because the code is being changed every day.","commit_id":"1a1f38198d718562b4b964648c1877846efeb0eb"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"f1c668fb4c545dfb17fb20c3a566f9ec9fb7f382","unresolved":false,"context_lines":[{"line_number":10,"context_line":"base class is deleting the images."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Ref:"},{"line_number":13,"context_line":"https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L122"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I602c1dfb8ab85be6c1e722259210cf3d25fb437a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAU3%2F%2Fth0%3D","line":13,"in_reply_to":"AAAAU3%2F%2Ftis%3D","updated":"2014-02-25 08:50:58.000000000","message":"I agree \nThanks","commit_id":"1a1f38198d718562b4b964648c1877846efeb0eb"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"388a42c771c345e97b9f396ed4a2dc723250337f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"base class is deleting the images."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Ref:"},{"line_number":13,"context_line":"https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L122"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I602c1dfb8ab85be6c1e722259210cf3d25fb437a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAVn%2F%2FkL0%3D","line":13,"updated":"2014-03-05 11:02:50.000000000","message":"I Will change this next Patch.","commit_id":"2dc7da8967397a04035307471b221972a039a6af"}],"tempest/api/compute/images/test_images.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0d9e685fec1146f0838b476a942104c6b0862f4f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        for image_id in self.image_ids:"},{"line_number":41,"context_line":"            self.client.delete_image(image_id)"},{"line_number":42,"context_line":"            self.image_ids.remove(image_id)"},{"line_number":43,"context_line":"        super(ImagesTestJSON, self).tearDown()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __create_image__(self, server_id, name, meta\u003dNone):"},{"line_number":46,"context_line":"        resp, body \u003d self.client.create_image(server_id, name, meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FuBs%3D","side":"PARENT","line":43,"updated":"2014-02-25 04:15:36.000000000","message":"This change would make the code readability a little difficult, because we cannot understand why image_id is appended to self.image_ids with this file only.\nIf seeing https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L122 , we could get it. but it would be a little difficult for long-term maintenance.","commit_id":"fe6da2177d5700349f44b5c2abf399a9983c898c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"29e8610d5affc4a5abc5d067881e306103af62b6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        for image_id in self.image_ids:"},{"line_number":41,"context_line":"            self.client.delete_image(image_id)"},{"line_number":42,"context_line":"            self.image_ids.remove(image_id)"},{"line_number":43,"context_line":"        super(ImagesTestJSON, self).tearDown()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __create_image__(self, server_id, name, meta\u003dNone):"},{"line_number":46,"context_line":"        resp, body \u003d self.client.create_image(server_id, name, meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2F9gw%3D","side":"PARENT","line":43,"in_reply_to":"AAAAU3%2F%2Ft7g%3D","updated":"2014-03-03 06:25:35.000000000","message":"Agree with Ken\u0027ichi\u0027s opinions. Instead of __create_image__(),  create_image_from_server in base.py is a better choice for this tests.  cls.image_ids could be remove too.","commit_id":"fe6da2177d5700349f44b5c2abf399a9983c898c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e44352ab14a74d66ff3b74d680ae11fbffda2db2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        for image_id in self.image_ids:"},{"line_number":41,"context_line":"            self.client.delete_image(image_id)"},{"line_number":42,"context_line":"            self.image_ids.remove(image_id)"},{"line_number":43,"context_line":"        super(ImagesTestJSON, self).tearDown()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __create_image__(self, server_id, name, meta\u003dNone):"},{"line_number":46,"context_line":"        resp, body \u003d self.client.create_image(server_id, name, meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Ft7g%3D","side":"PARENT","line":43,"in_reply_to":"AAAAU3%2F%2FuBs%3D","updated":"2014-02-25 04:31:17.000000000","message":"cls.clear_images() deletes images which are registered into cls.images. The value is registered in create_image_from_server.\n\nSo how about replacing __create_image__() with create_image_from_server()?\nWe could remove not only this tearDown() but also __create_image__().","commit_id":"fe6da2177d5700349f44b5c2abf399a9983c898c"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"097b200e3f68e67f3da0f6a147e2722791dd226b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        for image_id in self.image_ids:"},{"line_number":41,"context_line":"            self.client.delete_image(image_id)"},{"line_number":42,"context_line":"            self.image_ids.remove(image_id)"},{"line_number":43,"context_line":"        super(ImagesTestJSON, self).tearDown()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __create_image__(self, server_id, name, meta\u003dNone):"},{"line_number":46,"context_line":"        resp, body \u003d self.client.create_image(server_id, name, meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FcFs%3D","side":"PARENT","line":43,"in_reply_to":"AAAAVn%2F%2F9gw%3D","updated":"2014-03-06 03:08:27.000000000","message":"Thanks, It will be good.","commit_id":"fe6da2177d5700349f44b5c2abf399a9983c898c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44ac2bef467db79444c572e0300663f0e3736b5c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cls.client \u003d cls.images_client"},{"line_number":34,"context_line":"        cls.servers_client \u003d cls.servers_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        cls.image_ids \u003d []"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":39,"context_line":"    def test_create_image_from_deleted_server(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Fj04%3D","line":36,"updated":"2014-03-05 11:52:29.000000000","message":"Remove \"image_ids\" list also.","commit_id":"2dc7da8967397a04035307471b221972a039a6af"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"097b200e3f68e67f3da0f6a147e2722791dd226b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cls.client \u003d cls.images_client"},{"line_number":34,"context_line":"        cls.servers_client \u003d cls.servers_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        cls.image_ids \u003d []"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":39,"context_line":"    def test_create_image_from_deleted_server(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FcFk%3D","line":36,"in_reply_to":"AAAAVn%2F%2Fj04%3D","updated":"2014-03-06 03:07:47.000000000","message":"Agree.","commit_id":"2dc7da8967397a04035307471b221972a039a6af"}]}