)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"ddd75526138ea08388095656d450d01d9af5d453","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":437,"context_line":"    def test_add_fixed_ip(self):"},{"line_number":438,"context_line":"        resp, ifs \u003d self.os.interfaces_client.list_interfaces(self.server_id)"},{"line_number":439,"context_line":"        network_id \u003d ifs[0][\u0027net_id\u0027]"},{"line_number":440,"context_line":"        resp, body \u003d self.servers_client.add_fixed_ip(self.server_id,"},{"line_number":441,"context_line":"                                                      network_id)"},{"line_number":442,"context_line":"        self.assertEqual(resp.status, 202)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2FqdE%3D","line":439,"updated":"2014-02-25 11:43:00.000000000","message":"Can there be any possibility that, interfaces list is empty ?\nIf it may, then ifs[0] line will give error.\n In this condition better would be a check for an available interfaces.\n\nIt is just a query and suggestion :)","commit_id":"d7084b2471f7a7353edf16217ce30fa7e74c44de"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"676afa38c293e775c6364aed693198cf195fe07b","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":437,"context_line":"    def test_add_fixed_ip(self):"},{"line_number":438,"context_line":"        resp, ifs \u003d self.os.interfaces_client.list_interfaces(self.server_id)"},{"line_number":439,"context_line":"        network_id \u003d ifs[0][\u0027net_id\u0027]"},{"line_number":440,"context_line":"        resp, body \u003d self.servers_client.add_fixed_ip(self.server_id,"},{"line_number":441,"context_line":"                                                      network_id)"},{"line_number":442,"context_line":"        self.assertEqual(resp.status, 202)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2Fjao%3D","line":439,"in_reply_to":"AAAAU3%2F%2FqdE%3D","updated":"2014-02-26 08:08:41.000000000","message":"Here interface should not be empty but in case it is, then yes we should have check. Even I would like to attach the one before get.","commit_id":"d7084b2471f7a7353edf16217ce30fa7e74c44de"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8f023f543dff45145edc04af2c14757c870177c2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    cls.ip \u003d ip[\u0027addr\u0027]"},{"line_number":57,"context_line":"                    break"},{"line_number":58,"context_line":"            if cls.ip:"},{"line_number":59,"context_line":"                break"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.change_password,"},{"line_number":62,"context_line":"                          \u0027Change password not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F%2FS8%3D","line":59,"updated":"2014-02-27 00:18:11.000000000","message":"This should be operated in a new test test_add_fixed_ip because the values gotten with this are used only in the test.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"6716c77f22d41e776ce19de87b67829cdecc9d3a","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":437,"context_line":"    def test_add_fixed_ip(self):"},{"line_number":438,"context_line":"        resp, iface \u003d self.os.interfaces_client.create_interface(self."},{"line_number":439,"context_line":"                                                                 server_id)"},{"line_number":440,"context_line":"        resp, iface \u003d self.os.interfaces_client.wait_for_interface_status("},{"line_number":441,"context_line":"            self.server_id, iface[\u0027port_id\u0027], \u0027ACTIVE\u0027)"},{"line_number":442,"context_line":"        self.assertIn(\u0027port_state\u0027, iface)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Fhdk%3D","line":439,"updated":"2014-02-26 05:47:20.000000000","message":"addCleanup() fuction to clear created interface should be added here.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"6716c77f22d41e776ce19de87b67829cdecc9d3a","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        network_id \u003d iface[\u0027net_id\u0027]"},{"line_number":444,"context_line":"        resp, body \u003d self.servers_client.add_fixed_ip(self.server_id,"},{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Fhgg%3D","line":446,"updated":"2014-02-26 05:47:20.000000000","message":"return body should also be verified.\ni.e supplied server_id, network_id, etc should be verified.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"1ebfb3dae2850606703016e2de504e22cb9802c8","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        network_id \u003d iface[\u0027net_id\u0027]"},{"line_number":444,"context_line":"        resp, body \u003d self.servers_client.add_fixed_ip(self.server_id,"},{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FgNg%3D","line":446,"in_reply_to":"AAAAU3%2F%2FgYU%3D","updated":"2014-02-26 08:56:20.000000000","message":"Done","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8f023f543dff45145edc04af2c14757c870177c2","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        network_id \u003d iface[\u0027net_id\u0027]"},{"line_number":444,"context_line":"        resp, body \u003d self.servers_client.add_fixed_ip(self.server_id,"},{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FgTM%3D","line":446,"in_reply_to":"AAAAU3%2F%2FgYU%3D","updated":"2014-02-27 00:18:11.000000000","message":"Yes, Ghanshyam is right.\nThe class does not have list API because of https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/multinic.py#L36","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c46f62a4b5f4f0f8b58378863b80995ee5ce8a55","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        network_id \u003d iface[\u0027net_id\u0027]"},{"line_number":444,"context_line":"        resp, body \u003d self.servers_client.add_fixed_ip(self.server_id,"},{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FgYU%3D","line":446,"in_reply_to":"AAAAU3%2F%2Fgf0%3D","updated":"2014-02-26 08:40:20.000000000","message":"There is no method.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"aedd635eccc27a4c67c4b0b5bac40cfa2e236426","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        network_id \u003d iface[\u0027net_id\u0027]"},{"line_number":444,"context_line":"        resp, body \u003d self.servers_client.add_fixed_ip(self.server_id,"},{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Fgf0%3D","line":446,"in_reply_to":"AAAAU3%2F%2FhbM%3D","updated":"2014-02-26 08:26:12.000000000","message":"Optional - \nIf there, a method is available to list added fixed ip then it should be implemented here to verify. and if  not then there is no need.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4748e71080ed9b51851b4336aa852d495e2950eb","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        network_id \u003d iface[\u0027net_id\u0027]"},{"line_number":444,"context_line":"        resp, body \u003d self.servers_client.add_fixed_ip(self.server_id,"},{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FhbM%3D","line":446,"in_reply_to":"AAAAU3%2F%2Fhgg%3D","updated":"2014-02-26 08:08:05.000000000","message":"it does not return any response body. Only response status check can be done.- Invalid comment.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"6716c77f22d41e776ce19de87b67829cdecc9d3a","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Fhd8%3D","line":448,"updated":"2014-02-26 05:47:20.000000000","message":"Better would be to combine these two tests cases in following way- \n1. create_interface\n2. add_fixed_ip\n3. checks for create (status/body)\n4. delete_fixed_ip\n5. checks for delete (status/body)","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"1ebfb3dae2850606703016e2de504e22cb9802c8","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FgNI%3D","line":448,"in_reply_to":"AAAAU3%2F%2FgX0%3D","updated":"2014-02-26 08:56:20.000000000","message":"Done","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c46f62a4b5f4f0f8b58378863b80995ee5ce8a55","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FgX0%3D","line":448,"in_reply_to":"AAAAU3%2F%2FgiQ%3D","updated":"2014-02-26 08:40:20.000000000","message":"Both are independent. Check the code.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"aedd635eccc27a4c67c4b0b5bac40cfa2e236426","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FgiQ%3D","line":448,"in_reply_to":"AAAAU3%2F%2FhbI%3D","updated":"2014-02-26 08:26:12.000000000","message":"No actually I want to say that, if both test cases are separate then -\n\nif \"test_add_fixed_ip\" is failed, then \"test_remove_fixed_ip\" will also become failed.\nas when it is not added then cant be removed.\n\nAgain test cases should not be dependent, because as someone want to run particular test then due to dependency it will be failed without actual test failure.\n\nIf both are combined and if addition is failed the the testcase will exit from there only.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4748e71080ed9b51851b4336aa852d495e2950eb","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                                                      network_id)"},{"line_number":446,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FhbI%3D","line":448,"in_reply_to":"AAAAU3%2F%2Fhd8%3D","updated":"2014-02-26 08:08:05.000000000","message":"Separate test cases are better then combining all in one.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8f023f543dff45145edc04af2c14757c870177c2","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"},{"line_number":452,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F%2FQ8%3D","line":451,"updated":"2014-02-27 00:18:11.000000000","message":"We need to create another server with self.create_test_server() because this operation affects the shared server and that would cause the other test result.\nEach test should not affect the other tests because we should avoid making debugging difficult.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"6716c77f22d41e776ce19de87b67829cdecc9d3a","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"},{"line_number":452,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"class ServerActionsTestXML(ServerActionsTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FhfM%3D","line":452,"updated":"2014-02-26 05:47:20.000000000","message":"checks should be added to verify that fixed IP is removed completely and exists no more.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"1ebfb3dae2850606703016e2de504e22cb9802c8","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"},{"line_number":452,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"class ServerActionsTestXML(ServerActionsTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FgNA%3D","line":452,"in_reply_to":"AAAAU3%2F%2FgYE%3D","updated":"2014-02-26 08:56:20.000000000","message":"Done","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c46f62a4b5f4f0f8b58378863b80995ee5ce8a55","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"},{"line_number":452,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"class ServerActionsTestXML(ServerActionsTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FgYE%3D","line":452,"in_reply_to":"AAAAU3%2F%2Fges%3D","updated":"2014-02-26 08:40:20.000000000","message":"Same as above.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"aedd635eccc27a4c67c4b0b5bac40cfa2e236426","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"},{"line_number":452,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"class ServerActionsTestXML(ServerActionsTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Fges%3D","line":452,"in_reply_to":"AAAAU3%2F%2Fha8%3D","updated":"2014-02-26 08:26:12.000000000","message":"Same as comment in L#446","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4748e71080ed9b51851b4336aa852d495e2950eb","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    def test_remove_fixed_ip(self):"},{"line_number":450,"context_line":"        resp, body \u003d self.servers_client.remove_fixed_ip(self.server_id,"},{"line_number":451,"context_line":"                                                         self.ip)"},{"line_number":452,"context_line":"        self.assertEqual(resp.status, 202)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"class ServerActionsTestXML(ServerActionsTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Fha8%3D","line":452,"in_reply_to":"AAAAU3%2F%2FhfM%3D","updated":"2014-02-26 08:08:05.000000000","message":"I also does not return any body. I think status check is enough.","commit_id":"513cbc60ee2aaf3fdd7fb77a1d93abb64a044556"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"93363d8ea63e04f15630ed16e8c051edae6439b3","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":429,"context_line":"    def test_add_fixed_ip(self):"},{"line_number":430,"context_line":"        resp, iface \u003d self.os.interfaces_client.create_interface(self."},{"line_number":431,"context_line":"                                                                 server_id)"},{"line_number":432,"context_line":"        resp, iface \u003d self.os.interfaces_client.wait_for_interface_status("},{"line_number":433,"context_line":"            self.server_id, iface[\u0027port_id\u0027], \u0027ACTIVE\u0027)"},{"line_number":434,"context_line":"        self.assertIn(\u0027port_state\u0027, iface)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVX%2F%2F9nw%3D","line":431,"updated":"2014-02-27 05:24:46.000000000","message":"This create_interface affects the shared server, so this test also needs the other server.\n\nHowever now test_remove_fixed_ip has already created another server, and the server number of each test class should be under 10 because the quota number of server is 10 on the gate test environment.\n\nTo avoid creating many servers, it is better to merge test_add_fixed_ip and test_remove_fixed_ip to one test method.\n\nThe other part is nice, thanks.","commit_id":"184385d22d9cc805be580f0c558eb6534b5a8f50"}]}