)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"53229c040cc39af216c31667260a0cd00824cc52","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"                            \"Unable to get network by name: %s\" % network_name)"},{"line_number":1109,"context_line":"        return net[0]"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def create_floating_ip(self, server, external_network_id\u003dNone,"},{"line_number":1112,"context_line":"                           port_id\u003dNone, client\u003dNone, **kwargs):"},{"line_number":1113,"context_line":"        \"\"\"Create a floating IP and associates to a resource/port on Neutron\"\"\""},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        if not external_network_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_42baf0dd","line":1112,"range":{"start_line":1111,"start_character":41,"end_line":1112,"end_character":52},"updated":"2020-11-04 10:50:17.000000000","message":"would it be worth to squash these optional arguments into kwargs? I\u0027m looking at codesearch.openstack.org and technically it\u0027s possible, however, I\u0027m not sure if it\u0027s worth it in this case.","commit_id":"5e761bfad4745f45b53a830d761c6b76be9d19e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94f4e43b98b0b1f18d2a5df89e9f26488c3022b2","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"                            \"Unable to get network by name: %s\" % network_name)"},{"line_number":1109,"context_line":"        return net[0]"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def create_floating_ip(self, server, external_network_id\u003dNone,"},{"line_number":1112,"context_line":"                           port_id\u003dNone, client\u003dNone, **kwargs):"},{"line_number":1113,"context_line":"        \"\"\"Create a floating IP and associates to a resource/port on Neutron\"\"\""},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        if not external_network_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e05445a5_c1adaf3b","line":1112,"range":{"start_line":1111,"start_character":41,"end_line":1112,"end_character":52},"in_reply_to":"1f621f24_42baf0dd","updated":"2020-11-26 00:41:45.000000000","message":"yeah let\u0027s keep commonly/existing known kwargs as it is for making usage easy","commit_id":"5e761bfad4745f45b53a830d761c6b76be9d19e1"}]}