)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"df9c6178ecdb8abe5fcbce9c3ece52981f5092fb","unresolved":true,"context_lines":[{"line_number":940,"context_line":""},{"line_number":941,"context_line":"    def create_volume_from_image(self, **kwargs):"},{"line_number":942,"context_line":"        \"\"\"Create volume from image\"\"\""},{"line_number":943,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":944,"context_line":"        name \u003d kwargs.pop(\u0027name\u0027, None)"},{"line_number":945,"context_line":"        if not name:"},{"line_number":946,"context_line":"            namestart \u003d self.__class__.__name__ + \u0027-volume-origin\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"61480864_9c096492","line":943,"range":{"start_line":943,"start_character":18,"end_line":943,"end_character":41},"updated":"2020-11-26 00:37:40.000000000","message":"let\u0027s use image_id from kwargs like for name and add image_id as doc string param as that is different name than imageRef used for create_volume()\n        image_id\u003d kwargs.pop(\u0027image_id\u0027, None)\n        if not image_id:\n            image_id \u003d CONF.compute.image_ref","commit_id":"898fbda69dcf451eb2e73f46c15c0e0e977def79"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"433d5e132cb1ea55c6907a189c4c0d97075acf19","unresolved":false,"context_lines":[{"line_number":940,"context_line":""},{"line_number":941,"context_line":"    def create_volume_from_image(self, **kwargs):"},{"line_number":942,"context_line":"        \"\"\"Create volume from image\"\"\""},{"line_number":943,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":944,"context_line":"        name \u003d kwargs.pop(\u0027name\u0027, None)"},{"line_number":945,"context_line":"        if not name:"},{"line_number":946,"context_line":"            namestart \u003d self.__class__.__name__ + \u0027-volume-origin\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"a8c3d0da_adbb021a","line":943,"range":{"start_line":943,"start_character":18,"end_line":943,"end_character":41},"in_reply_to":"61480864_9c096492","updated":"2020-11-26 09:23:19.000000000","message":"Done","commit_id":"898fbda69dcf451eb2e73f46c15c0e0e977def79"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"df9c6178ecdb8abe5fcbce9c3ece52981f5092fb","unresolved":true,"context_lines":[{"line_number":945,"context_line":"        if not name:"},{"line_number":946,"context_line":"            namestart \u003d self.__class__.__name__ + \u0027-volume-origin\u0027"},{"line_number":947,"context_line":"            name \u003d data_utils.rand_name(namestart)"},{"line_number":948,"context_line":"        return self.create_volume(name\u003dname, imageRef\u003dimg_uuid)"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"class NetworkScenarioTest(ScenarioTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"14be2f99_add9f90f","line":948,"range":{"start_line":948,"start_character":62,"end_line":948,"end_character":63},"updated":"2020-11-26 00:37:40.000000000","message":"we should pass kwargs here too if user pass more kwargs","commit_id":"898fbda69dcf451eb2e73f46c15c0e0e977def79"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"433d5e132cb1ea55c6907a189c4c0d97075acf19","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        if not name:"},{"line_number":946,"context_line":"            namestart \u003d self.__class__.__name__ + \u0027-volume-origin\u0027"},{"line_number":947,"context_line":"            name \u003d data_utils.rand_name(namestart)"},{"line_number":948,"context_line":"        return self.create_volume(name\u003dname, imageRef\u003dimg_uuid)"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"class NetworkScenarioTest(ScenarioTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"af09fbd2_3b9968a7","line":948,"range":{"start_line":948,"start_character":62,"end_line":948,"end_character":63},"in_reply_to":"14be2f99_add9f90f","updated":"2020-11-26 09:23:19.000000000","message":"yes, I\u0027ve missed that, thanks","commit_id":"898fbda69dcf451eb2e73f46c15c0e0e977def79"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0f157772d49e0e35529b7202c9abea2f18154aa2","unresolved":true,"context_lines":[{"line_number":951,"context_line":"    def create_volume_from_image(self, **kwargs):"},{"line_number":952,"context_line":"        \"\"\"Create volume from image."},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        :param image_id: ID of the image to create volume from"},{"line_number":955,"context_line":"            CONF.compute.image_ref by default"},{"line_number":956,"context_line":"        :param **kwargs: additional parameters"},{"line_number":957,"context_line":"        \"\"\""},{"line_number":958,"context_line":"        image_id \u003d kwargs.pop(\u0027image_id\u0027, CONF.compute.image_ref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f08b89c6_73872005","line":955,"range":{"start_line":954,"start_character":0,"end_line":955,"end_character":45},"updated":"2020-11-26 16:27:18.000000000","message":"let\u0027s mention name also as we default that if not present.","commit_id":"b13c657a171eb96f8eb7c2b9a06dbdce1b041869"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"82cebe3f2cfd1760b1b130c628b478cf305dbb72","unresolved":false,"context_lines":[{"line_number":951,"context_line":"    def create_volume_from_image(self, **kwargs):"},{"line_number":952,"context_line":"        \"\"\"Create volume from image."},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        :param image_id: ID of the image to create volume from"},{"line_number":955,"context_line":"            CONF.compute.image_ref by default"},{"line_number":956,"context_line":"        :param **kwargs: additional parameters"},{"line_number":957,"context_line":"        \"\"\""},{"line_number":958,"context_line":"        image_id \u003d kwargs.pop(\u0027image_id\u0027, CONF.compute.image_ref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae4f01b_6382427a","line":955,"range":{"start_line":954,"start_character":0,"end_line":955,"end_character":45},"in_reply_to":"f08b89c6_73872005","updated":"2020-11-26 16:51:34.000000000","message":"Done","commit_id":"b13c657a171eb96f8eb7c2b9a06dbdce1b041869"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"99c17c4c14ed7c453373a169abdb3f90bc39d970","unresolved":true,"context_lines":[{"line_number":951,"context_line":"    def create_volume_from_image(self, **kwargs):"},{"line_number":952,"context_line":"        \"\"\"Create volume from image."},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        :param image_id: ID of the image to create volume from,"},{"line_number":955,"context_line":"            CONF.compute.image_ref by default"},{"line_number":956,"context_line":"        :param name: name of the volume,"},{"line_number":957,"context_line":"            \u0027$classname-volume-origin\u0027 by default"},{"line_number":958,"context_line":"        :param **kwargs: additional parameters"},{"line_number":959,"context_line":"        \"\"\""},{"line_number":960,"context_line":"        image_id \u003d kwargs.pop(\u0027image_id\u0027, CONF.compute.image_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f1efa4a1_bccaa6b6","line":957,"range":{"start_line":954,"start_character":0,"end_line":957,"end_character":49},"updated":"2020-12-04 08:41:44.000000000","message":"image_id and name are not in the parameters of create_volume_from_image explicitly, but I think  these comments are helpful.","commit_id":"0216b376843dcebd63279d4562a96c9ee0639778"}]}