)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"742c1462c2281e943ee603e8bd27bf56ff432951","unresolved":false,"context_lines":[{"line_number":810,"context_line":"                LOG.exception(extra_msg)"},{"line_number":811,"context_line":"                raise"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"    def create_floating_ip(self, server, **kwargs):"},{"line_number":814,"context_line":"        \"\"\"Create a floating IP and associates to a server on Nova\"\"\""},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"        if not kwargs.get(\u0027pool_name\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_7facc433","line":813,"range":{"start_line":813,"start_character":41,"end_line":813,"end_character":49},"updated":"2020-11-06 10:32:35.000000000","message":"i think that in this case it will be better to leave pool_name as standalone argument otherwise we change the argument name  (method signature) from pool_name to pool which might be a problem and might require changes in plugins etc","commit_id":"923782d1477e2aeb0dd207a032045ed284df9166"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"742c1462c2281e943ee603e8bd27bf56ff432951","unresolved":false,"context_lines":[{"line_number":814,"context_line":"        \"\"\"Create a floating IP and associates to a server on Nova\"\"\""},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"        if not kwargs.get(\u0027pool_name\u0027):"},{"line_number":817,"context_line":"            kwargs[\u0027pool_name\u0027] \u003d CONF.network.floating_network_name"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        floating_ip \u003d (self.compute_floating_ips_client."},{"line_number":820,"context_line":"                       create_floating_ip(**kwargs)[\u0027floating_ip\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_1f84b0b0","line":817,"range":{"start_line":817,"start_character":20,"end_line":817,"end_character":29},"updated":"2020-11-06 10:32:35.000000000","message":"it has to be \u0027pool\u0027 - this method accepts pool_name however the create_floating_ip we\u0027re calling below accepts pool ..","commit_id":"923782d1477e2aeb0dd207a032045ed284df9166"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"742c1462c2281e943ee603e8bd27bf56ff432951","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"                            \"Unable to get network by name: %s\" % network_name)"},{"line_number":1110,"context_line":"        return net[0]"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"    def create_floating_ip(self, server, external_network_id\u003dNone,"},{"line_number":1113,"context_line":"                           client\u003dNone, **kwargs):"},{"line_number":1114,"context_line":"        \"\"\"Create a floating IP and associates to a resource/port on Neutron\"\"\""},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        if not external_network_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_9f09e096","line":1113,"range":{"start_line":1112,"start_character":4,"end_line":1113,"end_character":50},"updated":"2020-11-06 10:32:35.000000000","message":"this method already has a patch:\nhttps://review.opendev.org/#/c/761191/1/tempest/scenario/manager.py","commit_id":"923782d1477e2aeb0dd207a032045ed284df9166"}]}