)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1eace0d320b492f611552d8f881494d628caa551","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-11-09 22:28:54 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding \u0027HARD\u0027 type reboot into \"test_minimum_basic_scenario\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2fc2aa14abe8a90a9d298378640440c1d4c975c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_1bd81f1c","line":8,"updated":"2020-11-10 12:45:49.000000000","message":"More description would be helpful to understand the objective of this patch.\nI\u0027d like to clarify the reason why we should add \u0027HARD\u0027 though we have the test in the api. \n\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/api/compute/servers/test_server_actions.py#L154-L161","commit_id":"228bce53258b29ba894d558f535146e55b25d45e"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d05a0ccadd984c12d039664ee96c914da71db4a0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-11-09 22:28:54 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding \u0027HARD\u0027 type reboot into \"test_minimum_basic_scenario\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2fc2aa14abe8a90a9d298378640440c1d4c975c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_9b9c2f0f","line":8,"in_reply_to":"1f621f24_1bd81f1c","updated":"2020-11-10 12:58:56.000000000","message":"\u003e My patch is about test coverage improvement for already \n\u003e existing test only.\nAh, I see. Should we test it in both api and scenario? If so, adding the reason here would be helpful.","commit_id":"228bce53258b29ba894d558f535146e55b25d45e"}],"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"33090c1115b77ca5d43afb9cf5f75fbd38d06880","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027],"},{"line_number":160,"context_line":"                server\u003dserver)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.check_disks()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if floating_ip:"},{"line_number":165,"context_line":"            # delete the floating IP, this should refresh the server addresses"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_0d6109d4","line":162,"updated":"2020-11-10 10:39:54.000000000","message":"shouldn\u0027t this be checked after each reboot also?","commit_id":"228bce53258b29ba894d558f535146e55b25d45e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d112c83fa97b0af523980635b47b39dd8ea574a5","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027],"},{"line_number":160,"context_line":"                server\u003dserver)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.check_disks()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if floating_ip:"},{"line_number":165,"context_line":"            # delete the floating IP, this should refresh the server addresses"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_6d851dcf","line":162,"in_reply_to":"1f621f24_0d6109d4","updated":"2020-11-10 11:09:48.000000000","message":"There is nothing about \"disc check\" in the provided test docstring (line 155 and 156 in original file), does it make sense to check disks after reboot?\nIf yes I\u0027ll include \"self.check_disks()\" into the loop block and will also change the docstring on my next patch.","commit_id":"228bce53258b29ba894d558f535146e55b25d45e"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1eace0d320b492f611552d8f881494d628caa551","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027],"},{"line_number":160,"context_line":"                server\u003dserver)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.check_disks()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if floating_ip:"},{"line_number":165,"context_line":"            # delete the floating IP, this should refresh the server addresses"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_9be42fe2","line":162,"in_reply_to":"1f621f24_6d851dcf","updated":"2020-11-10 12:45:49.000000000","message":"I think it would be better to check with self.check_disk() in the loop because it should be accessible after every rebooting.","commit_id":"228bce53258b29ba894d558f535146e55b25d45e"}]}