)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc004aadb2f416cb4d2169aac6cc2784a4f74798","unresolved":false,"context_lines":[{"line_number":64,"context_line":"def create_test_server(clients, validatable\u003dFalse, validation_resources\u003dNone,"},{"line_number":65,"context_line":"                       tenant_network\u003dNone, wait_until\u003dNone,"},{"line_number":66,"context_line":"                       volume_backed\u003dFalse, name\u003dNone, flavor\u003dNone,"},{"line_number":67,"context_line":"                       image_id\u003dNone, wait_for_guest_os\u003dTrue, **kwargs):"},{"line_number":68,"context_line":"    \"\"\"Common wrapper utility returning a test server."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    This method is a common wrapper returning a test server that can be"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_b454a722","line":67,"range":{"start_line":67,"start_character":38,"end_line":67,"end_character":55},"updated":"2020-11-09 21:40:50.000000000","message":"name is not so clear as it can be confused with wait_until, can we rename this to something like wait_for_sshable","commit_id":"b43d43293e304c89afd2a90e84fa115b5d3db9e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc004aadb2f416cb4d2169aac6cc2784a4f74798","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    :param flavor: Flavor of the server to be provisioned. If not defined,"},{"line_number":100,"context_line":"        CONF.compute.flavor_ref will be used instead."},{"line_number":101,"context_line":"    :param image_id: ID of the image to be used to provision the server. If not"},{"line_number":102,"context_line":"        defined, CONF.compute.image_ref will be used instead."},{"line_number":103,"context_line":"    :returns: a tuple"},{"line_number":104,"context_line":"    \"\"\""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_370c193a","line":102,"range":{"start_line":102,"start_character":60,"end_line":102,"end_character":61},"updated":"2020-11-09 21:40:50.000000000","message":"please add param doc also.","commit_id":"b43d43293e304c89afd2a90e84fa115b5d3db9e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc004aadb2f416cb4d2169aac6cc2784a4f74798","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                            LOG.exception(\u0027Server %s failed to delete in time\u0027,"},{"line_number":271,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    if CONF.compute_feature_enabled.console_output and wait_for_guest_os:"},{"line_number":274,"context_line":"        waiters.wait_for_guest_os_boot(clients.servers_client, server[\u0027id\u0027])"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    return body, servers"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_d405e315","line":273,"range":{"start_line":273,"start_character":72,"end_line":273,"end_character":73},"updated":"2020-11-09 21:40:50.000000000","message":"let\u0027s check \u0027validatable\u0027 param value also. if \u0027validatable\u0027 is true that means test creating sshable server so wait in those cases only.\n\nif CONF.compute_feature_enabled.console_output and wait_for_guest_os and validatable:","commit_id":"b43d43293e304c89afd2a90e84fa115b5d3db9e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc004aadb2f416cb4d2169aac6cc2784a4f74798","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                        except Exception:"},{"line_number":270,"context_line":"                            LOG.exception(\u0027Server %s failed to delete in time\u0027,"},{"line_number":271,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    if CONF.compute_feature_enabled.console_output and wait_for_guest_os:"},{"line_number":274,"context_line":"        waiters.wait_for_guest_os_boot(clients.servers_client, server[\u0027id\u0027])"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    return body, servers"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_d71a056d","line":274,"range":{"start_line":272,"start_character":0,"end_line":274,"end_character":76},"updated":"2020-11-09 21:40:50.000000000","message":"this common create server is used only in API tests, for scenario tests which does a lot of ssh you can add the same thing in scenario manager class - https://github.com/openstack/tempest/blob/96b43661cbe4bcb84cda9266c2617723ad06c04c/tempest/scenario/manager.py#L179","commit_id":"b43d43293e304c89afd2a90e84fa115b5d3db9e0"}],"tempest/common/waiters.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"344194c719130d80eda8cc5fc999d4a19063ef98","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            if \u0027login:\u0027 in line.lower():"},{"line_number":448,"context_line":"                return"},{"line_number":449,"context_line":"        if int(time.time()) - start_time \u003e\u003d client.build_timeout:"},{"line_number":450,"context_line":"            LOG.info(\"Guest OS on server %s probably isn\u0027t ready or its \""},{"line_number":451,"context_line":"                     \"console log can\u0027t be parsed properly. If guest OS \""},{"line_number":452,"context_line":"                     \"isn\u0027t ready, that may cause problems with SSH to \""},{"line_number":453,"context_line":"                     \"the server.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_986eb0fd","line":450,"range":{"start_line":450,"start_character":16,"end_line":450,"end_character":20},"updated":"2020-11-16 15:15:41.000000000","message":"Yeah, maybe \"info\" is enough. If this happens, probably we\u0027ll have an exception when connecting to the VM.","commit_id":"e3405ba808f97eae57f3a60991000afaa34cbe89"}]}
