)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"9f8c05924a1482438120ce4a09b5b103f1f743e1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] run_validation for scenario tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactor test_minimum_basic"},{"line_number":10,"context_line":"refactor test_server_basic_ops"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cf17f6dcc3141d05c9e26cbb2e6f945e68557e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c7657f4c_daa588e3","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"updated":"2021-01-27 03:44:45.000000000","message":"Maybe, adding more details in the commit message is better. That helps us to review this patch.\nWhat are the objectives/issues and how are you trying to resolve them?","commit_id":"d8ddd4ffe8931013b93ad78f48939ec00b7ccfc7"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"a40a8a4b68c61010413f396b7a818c9aee972e75","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] run_validation for scenario tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactor test_minimum_basic"},{"line_number":10,"context_line":"refactor test_server_basic_ops"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cf17f6dcc3141d05c9e26cbb2e6f945e68557e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"523c572a_9e3e1b7a","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"in_reply_to":"c7657f4c_daa588e3","updated":"2021-02-03 18:18:24.000000000","message":"Yes I will add a better commit message","commit_id":"d8ddd4ffe8931013b93ad78f48939ec00b7ccfc7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8cb8df6ca3f5de727897459ccf5ad6fa07149b67","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[WIP] run_validation for scenario tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactor test_minimum_basic"},{"line_number":10,"context_line":"refactor test_server_basic_ops"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cf17f6dcc3141d05c9e26cbb2e6f945e68557e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6bc5c1bd_fed80727","line":10,"updated":"2021-05-20 07:57:14.000000000","message":"could you mention why this is good and what we wanna achieve by this? \nI know this is just a WIP but it would help me and others who might come across this to understand the context","commit_id":"31332dca825f95e960627d0641a750456787b0eb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eb9480ea32c1a24aad970f5b833b82fb24e75068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51b52b2a_a737d6c8","updated":"2022-08-01 20:22:47.000000000","message":"Greetings! Looks like this change can likely be abandoned.","commit_id":"31332dca825f95e960627d0641a750456787b0eb"}],"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8cb8df6ca3f5de727897459ccf5ad6fa07149b67","unresolved":true,"context_lines":[{"line_number":270,"context_line":"                    LOG.debug(\"No key provided.\")"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"            if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:"},{"line_number":273,"context_line":"                if wait_until is None:"},{"line_number":274,"context_line":"                    wait_until \u003d \u0027ACTIVE\u0027"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"            if \u0027user_data\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"6670256a_c5faeb4b","line":273,"range":{"start_line":273,"start_character":19,"end_line":273,"end_character":29},"updated":"2021-05-20 07:57:14.000000000","message":"can this be ever None?","commit_id":"31332dca825f95e960627d0641a750456787b0eb"}],"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"9f8c05924a1482438120ce4a09b5b103f1f743e1","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":107,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":108,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":109,"context_line":"        validation_resources \u003d self.get_validation_resources()"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        server \u003d self.create_server("},{"line_number":112,"context_line":"            validatable\u003dTrue, validation_resources\u003dvalidation_resources)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0ec26962_498e8145","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":62},"updated":"2021-01-27 03:44:45.000000000","message":"Where do the \u0027image\u0027 and \u0027keypair\u0027 come from? I miss something?","commit_id":"d8ddd4ffe8931013b93ad78f48939ec00b7ccfc7"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"a40a8a4b68c61010413f396b7a818c9aee972e75","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":107,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":108,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":109,"context_line":"        validation_resources \u003d self.get_validation_resources()"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        server \u003d self.create_server("},{"line_number":112,"context_line":"            validatable\u003dTrue, validation_resources\u003dvalidation_resources)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a57ca906_f5673495","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":62},"in_reply_to":"0ec26962_498e8145","updated":"2021-02-03 18:18:24.000000000","message":"This is what being generated as part of validation resources:\n\n{\u0027keypair\u0027: {\u0027name\u0027: \u0027tempest-keypair-1649925978\u0027, \u0027public_key\u0027: \u0027ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC+/QgXh/770sFChE84QvrVxI7vTvoCDhBiyvS8rH7Li+3koTXM/f+vH7LBghrHyBpgrglLuPdU8Ax5J5USKUEho7CuHPY5cwPe3v14eU0jNQ6Qit/64LYT2ySayXVQbgCMSNEqtA3CxiPrCBZYAYn3VTq+dmrkS9Ed0C+PKz5OzQ6Q0uS+rO2iXxhYRju1AG//yDwNq4fA55qIGRrCXZhqbKkipGV/eM5wQkCUpKRykcm3Q5syxk8HJymrYT4Befthb34VwFVUJ2NFRE9RIH48WhDbLgG7hzpEY8RDUhBU6m2vdgjgXA53jGQedI5Nabiw1bg0UfHaa325CsWKCgIN Generated-by-Nova\u0027, \u0027fingerprint\u0027: \u0027ac:88:57:21:b0:80:2b:9a:48:cf:d6:2d:7b:f0:83:ab\u0027, \u0027user_id\u0027: \u0027576b51ded0ba457bb29a8f8ce3046d58\u0027, \u0027private_key\u0027: \u0027-----BEGIN RSA PRIVATE KEY-----\\nMIIEpAIBAAKCAQEAvv0IF4f++9LBQoRPOEL61cSO7076Ag4QYsr0vKx+y4vt5KE1\\nzP3/rx+ywYIax8gaYK4JS7j3VPAMeSeVEilBIaOwrhz2OXMD3t79eHlNIzUOkIrf\\n+uC2E9skmsl1UG4AjEjRKrQNwsYj6wgWWAGJ91U6vnZq5EvRHdAvjys+Ts0OkNLk\\nvqztol8YWEY7tQBv/8g8DauHwOeaiBkawl2YamypIqRlf3jOcEJAlKSkcpHJt0Ob\\nMsZPBycpq2E+AXn7YW9+FcBVVCdjRURPUSB+PFoQ2y4Bu4c6RGPEQ1IQVOptr3YI\\n4FwOd4xkHnSOTWm4sNW4NFHx2mt9uQrFigoCDQIDAQABAoIBACxYcjWMhT8Re4An\\nWoGUw8s43XthWhl6DIHz4Ami/7nhXrZUXDqhy2ltMcNOo0s6Ai3qmwvzAbK+HhdP\\ngoR6Ab5+1HpJDT7fnslz+2SqvadsHVqgdEs7O+u2WXR7THsFX6kzCyYgMoXEHfjn\\notCCYveD2aT5t+4UUJTcjv5uKwR+n7ERSAltu5pjlklZATGHvY7z07CClI+B0i0T\\n/4VRMQh1PcGMZJ9ffVNQCjEl5vWIapw2fEnUPpKu5gfsbPl+27TQRKQXONjiXUIo\\nX4ic3kW3IXCt2BdP5jQoWUAu0648jS0Nln+vT27PhYplC49i5toX+/6yANG6aHKn\\nGuPvWuECgYEA3Wjn5GrEFQqXR458Tdiw+x2on/WcQ4n4FjdVBoP39P1s2xdGH3Z1\\nAKfzIw+zS0I1m2aWlDqUng6EX49kg1BqR+OHTJm1wpfyi0P6+JqvICCZJyJKzp28\\nhaZPnTFB05kFGKkSbBGBKgsV5VfqAwwzoO4FV5MhNjn6NKLuRcNPjFkCgYEA3NNy\\n3UosOQnsYMelt2C19Zp7wcXBbIWPrg5HATHIzkfU/Gm19CS0QGchrxaL+C2yGFVV\\nlpFcd1X6+2NCg5RynmJVhSyjPt6KCNWRpoF58w1P+cINKSvSlkRvWEUNswApLGuR\\nf0dQIb4XGevcufuJzS708yYpY6mKQ97A3s90nNUCgYBQFNmK7HLviV0eLJMZNP8O\\nVLPg510VsJlir7C5IpJUsjTlKY3bY2T+T8DJNayL0+6/vmNIScfnQyjtx1d7h2Jp\\njgop0o7DS2IWrQfhU1F0NVYvqV+VS8gcLwMsv9wnRHlrafuXyt0E7+2DfkDNyWQD\\nGRQlkLm6e03cK/IymWn0QQKBgQC8Cnbyh1nXDGM0Gm48FGd+CBnAbOSDw8wQ3GmM\\nU9d6COMOOfpONv8jJG8jiGCSal8Qp4HlYEzL9fRuIx0drMhZpMTMTbGJNLl4Qlzv\\n26t70+c5eAv69i0x9n6WPN8ogUeOYt8X8iMDSLqlQRrJaK/0gDrn3qQ6EMIDf2jf\\nkurrLQKBgQCslCrJbYo8YrvJKbrZFW4E8cv++vj8P46NGAojByAGSO2jRPBo/05J\\nHsrz/zYqp71Cl75SwgYx7lmMRqRqjYnnm40JXlur0UcLea9ldOk3nqHE8EaQLv7R\\nNoP6ozc0dQ9hs33qAZLLa1Mf6+5MT9g9qu+l7B7pUGRjGaaUnM7Q6A\u003d\u003d\\n-----END RSA PRIVATE KEY-----\\n\u0027}, \u0027security_group\u0027: {\u0027id\u0027: \u00278513ff09-e19b-4693-864d-e6243c798162\u0027, \u0027name\u0027: \u0027tempest-securitygroup--1729573925\u0027, \u0027tenant_id\u0027: \u00276f548a027741444a86cd706baca88069\u0027, \u0027description\u0027: \u0027tempest-description--709148105\u0027, \u0027security_group_rules\u0027: [{\u0027id\u0027: \u0027595918f7-a090-4a7e-ad9d-79e10a55ea8c\u0027, \u0027tenant_id\u0027: \u00276f548a027741444a86cd706baca88069\u0027, \u0027security_group_id\u0027: \u00278513ff09-e19b-4693-864d-e6243c798162\u0027, \u0027ethertype\u0027: \u0027IPv6\u0027, \u0027direction\u0027: \u0027egress\u0027, \u0027protocol\u0027: None, \u0027port_range_min\u0027: None, \u0027port_range_max\u0027: None, \u0027remote_ip_prefix\u0027: None, \u0027remote_group_id\u0027: None, \u0027description\u0027: None, \u0027tags\u0027: [], \u0027created_at\u0027: \u00272020-11-30T03:04:39Z\u0027, \u0027updated_at\u0027: \u00272020-11-30T03:04:39Z\u0027, \u0027revision_number\u0027: 0, \u0027project_id\u0027: \u00276f548a027741444a86cd706baca88069\u0027}, {\u0027id\u0027: \u00276da37e8a-cf69-4737-8852-24c6d0f82c86\u0027, \u0027tenant_id\u0027: \u00276f548a027741444a86cd706baca88069\u0027, \u0027security_group_id\u0027: \u00278513ff09-e19b-4693-864d-e6243c798162\u0027, \u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027egress\u0027, \u0027protocol\u0027: None, \u0027port_range_min\u0027: None, \u0027port_range_max\u0027: None, \u0027remote_ip_prefix\u0027: None, \u0027remote_group_id\u0027: None, \u0027description\u0027: None, \u0027tags\u0027: [], \u0027created_at\u0027: \u00272020-11-30T03:04:39Z\u0027, \u0027updated_at\u0027: \u00272020-11-30T03:04:39Z\u0027, \u0027revision_number\u0027: 0, \u0027project_id\u0027: \u00276f548a027741444a86cd706baca88069\u0027}], \u0027tags\u0027: [], \u0027created_at\u0027: \u00272020-11-30T03:04:38Z\u0027, \u0027updated_at\u0027: \u00272020-11-30T03:04:39Z\u0027, \u0027revision_number\u0027: 1, \u0027project_id\u0027: \u00276f548a027741444a86cd706baca88069\u0027}, \u0027floating_ip\u0027: {\u0027id\u0027: \u0027eb6a8cbc-a39e-4a44-bfaa-5d89793585a3\u0027, \u0027tenant_id\u0027: \u00276f548a027741444a86cd706baca88069\u0027, \u0027floating_ip_address\u0027: \u002710.0.0.217\u0027, \u0027floating_network_id\u0027: \u002751a95e4b-cf76-41e3-bcf8-1debfc0d432a\u0027, \u0027router_id\u0027: None, \u0027port_id\u0027: None, \u0027fixed_ip_address\u0027: None, \u0027status\u0027: \u0027DOWN\u0027, \u0027project_id\u0027: \u00276f548a027741444a86cd706baca88069\u0027, \u0027description\u0027: \u0027\u0027, \u0027dns_domain\u0027: \u0027\u0027, \u0027dns_name\u0027: \u0027\u0027, \u0027tags\u0027: [], \u0027created_at\u0027: \u00272020-11-30T03:04:40Z\u0027, \u0027updated_at\u0027: \u00272020-11-30T03:04:40Z\u0027, \u0027revision_number\u0027: 0, \u0027ip\u0027: \u002710.0.0.217\u0027}}\n\nSo the idea here is like to use this for accessing the ssh rather than each scenario test creating it\u0027s own ways of generating these parameters.\n\nDoes that make sense??","commit_id":"d8ddd4ffe8931013b93ad78f48939ec00b7ccfc7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8cb8df6ca3f5de727897459ccf5ad6fa07149b67","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":107,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":108,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":109,"context_line":"        image \u003d self.image_create()"},{"line_number":110,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        server \u003d self.create_server(image_id\u003dimage, key_name\u003dkeypair[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"170364e8_c8249dab","side":"PARENT","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":35},"updated":"2021-05-20 07:57:14.000000000","message":"get_validation_resources basically returns only values from the CONF:\nhttps://opendev.org/openstack/tempest/src/commit/393e94a604f29940025c2c2d8f406419e7733e5c/tempest/test.py#L723-L730\n\nSo I don\u0027t think we can replace image_create by just get_validation_resources because it won\u0027t create the image","commit_id":"ccf56b5ca278fd083946137a5c36cdd8ba2f230d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8cb8df6ca3f5de727897459ccf5ad6fa07149b67","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":108,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":109,"context_line":"        image \u003d self.image_create()"},{"line_number":110,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        server \u003d self.create_server(image_id\u003dimage, key_name\u003dkeypair[\u0027name\u0027])"},{"line_number":113,"context_line":"        servers \u003d self.servers_client.list_servers()[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"91e59a51_a67c8f88","side":"PARENT","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":39},"updated":"2021-05-20 07:57:14.000000000","message":"the same for keypair","commit_id":"ccf56b5ca278fd083946137a5c36cdd8ba2f230d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8cb8df6ca3f5de727897459ccf5ad6fa07149b67","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            ssh_ip \u003d self.get_server_ip(server)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        self.create_and_add_security_group_to_server(server)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # check that we can SSH to the server before reboot"},{"line_number":149,"context_line":"        self.linux_client \u003d self.get_remote_client("}],"source_content_type":"text/x-python","patch_set":4,"id":"edfe6505_6c173b34","side":"PARENT","line":146,"range":{"start_line":146,"start_character":8,"end_line":146,"end_character":60},"updated":"2021-05-20 07:57:14.000000000","message":"this is not needed? I feel like if we remove this we will change the nature of the test .. isn\u0027t the purpose of the changes just to add validation?","commit_id":"ccf56b5ca278fd083946137a5c36cdd8ba2f230d"}],"tempest/scenario/test_server_basic_ops.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8cb8df6ca3f5de727897459ccf5ad6fa07149b67","unresolved":true,"context_lines":[{"line_number":135,"context_line":"            security_groups\u003d[{\u0027name\u0027: security_group[\u0027name\u0027]}],"},{"line_number":136,"context_line":"            config_drive\u003dCONF.compute_feature_enabled.config_drive,"},{"line_number":137,"context_line":"            metadata\u003dself.md)"},{"line_number":138,"context_line":"        self.verify_ssh(keypair)"},{"line_number":139,"context_line":"        self.verify_metadata()"},{"line_number":140,"context_line":"        self.verify_metadata_on_config_drive()"},{"line_number":141,"context_line":"        self.verify_networkdata_on_config_drive()"}],"source_content_type":"text/x-python","patch_set":4,"id":"d9e359c5_c81e3e83","side":"PARENT","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":32},"updated":"2021-05-20 07:57:14.000000000","message":"is this logically replaced by something else? I don\u0027t see how we can remove this without totally changing the test itself.","commit_id":"ccf56b5ca278fd083946137a5c36cdd8ba2f230d"}]}