)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"69a42a92258a3303ade3724985a6fca312a6df9d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Soniya Vyas \u003csvyas@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-10 19:27:02 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementation of create_subnet() varies among plugins and scenario_manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is need of stable implementation of create_subnet()."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"04e73288_95ba1430","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":75},"updated":"2020-12-17 19:52:18.000000000","message":"\u0027from manila-tempest-plugin\u0027\n\nIf I read the notes [1] correctly and we have not forgotten anything, create_subnet() implementation is different only in manila-tempest-plugin\n\n[1] https://etherpad.opendev.org/p/tempest-scenario-manager","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"78b7e1ab8b81e4408c19f7724e82ebc055770492","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Soniya Vyas \u003csvyas@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-10 19:27:02 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementation of create_subnet() varies among plugins and scenario_manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is need of stable implementation of create_subnet()."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"93e92fbd_fbc91f60","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":75},"in_reply_to":"04e73288_95ba1430","updated":"2021-01-05 06:31:52.000000000","message":"Done","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"69a42a92258a3303ade3724985a6fca312a6df9d","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is need of stable implementation of create_subnet()."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"For the stable implementation of create_subnet() following parameters are"},{"line_number":12,"context_line":"been added:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. Condition to check empty str_cidr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"57bb28a1_ea44d126","line":11,"range":{"start_line":11,"start_character":70,"end_line":11,"end_character":73},"updated":"2020-12-17 19:52:18.000000000","message":"have","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"78b7e1ab8b81e4408c19f7724e82ebc055770492","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is need of stable implementation of create_subnet()."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"For the stable implementation of create_subnet() following parameters are"},{"line_number":12,"context_line":"been added:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. Condition to check empty str_cidr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fe930aad_12d04dd4","line":11,"range":{"start_line":11,"start_character":70,"end_line":11,"end_character":73},"in_reply_to":"57bb28a1_ea44d126","updated":"2021-01-05 06:31:52.000000000","message":"Done","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"69a42a92258a3303ade3724985a6fca312a6df9d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"1. Condition to check empty str_cidr"},{"line_number":15,"context_line":"2. More attributes in case of ipv6"},{"line_number":16,"context_line":"3. Usage of default_subnet_pool"},{"line_number":17,"context_line":"4. Addition of argument routers_client"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Implements: blueprint tempest-scenario-manager-stable"},{"line_number":20,"context_line":"Signed-off by: Soniya Vyas\u003csvyas@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e9b25e6f_b5c7ada8","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":1},"updated":"2020-12-17 19:52:18.000000000","message":"this won\u0027t be needed, see other comments","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"78b7e1ab8b81e4408c19f7724e82ebc055770492","unresolved":false,"context_lines":[{"line_number":14,"context_line":"1. Condition to check empty str_cidr"},{"line_number":15,"context_line":"2. More attributes in case of ipv6"},{"line_number":16,"context_line":"3. Usage of default_subnet_pool"},{"line_number":17,"context_line":"4. Addition of argument routers_client"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Implements: blueprint tempest-scenario-manager-stable"},{"line_number":20,"context_line":"Signed-off by: Soniya Vyas\u003csvyas@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"007548be_339c5b07","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":1},"in_reply_to":"e9b25e6f_b5c7ada8","updated":"2021-01-05 06:31:52.000000000","message":"Done","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"}],"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"69a42a92258a3303ade3724985a6fca312a6df9d","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"        return network"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"    def create_subnet(self, network, subnets_client\u003dNone,"},{"line_number":1050,"context_line":"                      routers_client\u003dNone, namestart\u003d\u0027subnet-smoke\u0027,"},{"line_number":1051,"context_line":"                      **kwargs):"},{"line_number":1052,"context_line":"        \"\"\"Create a subnet for the given network"},{"line_number":1053,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"aa6fe89b_8be24d00","line":1050,"range":{"start_line":1050,"start_character":22,"end_line":1050,"end_character":42},"updated":"2020-12-17 19:52:18.000000000","message":"this is not needed, the routers_client is not used within the method","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"78b7e1ab8b81e4408c19f7724e82ebc055770492","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"        return network"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"    def create_subnet(self, network, subnets_client\u003dNone,"},{"line_number":1050,"context_line":"                      routers_client\u003dNone, namestart\u003d\u0027subnet-smoke\u0027,"},{"line_number":1051,"context_line":"                      **kwargs):"},{"line_number":1052,"context_line":"        \"\"\"Create a subnet for the given network"},{"line_number":1053,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e65bcb1c_b69dad38","line":1050,"range":{"start_line":1050,"start_character":22,"end_line":1050,"end_character":42},"in_reply_to":"aa6fe89b_8be24d00","updated":"2021-01-05 06:31:52.000000000","message":"Done","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"69a42a92258a3303ade3724985a6fca312a6df9d","unresolved":true,"context_lines":[{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        if not subnets_client:"},{"line_number":1066,"context_line":"            subnets_client \u003d self.subnets_client"},{"line_number":1067,"context_line":""},{"line_number":1068,"context_line":"        if not routers_client:"},{"line_number":1069,"context_line":"            routers_client \u003d self.routers_client"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"        def cidr_in_use(cidr, project_id):"},{"line_number":1072,"context_line":"            \"\"\"Check cidr existence"}],"source_content_type":"text/x-python","patch_set":1,"id":"281bb62b_25245760","line":1069,"range":{"start_line":1067,"start_character":0,"end_line":1069,"end_character":48},"updated":"2020-12-17 19:52:18.000000000","message":"routers_client is unused var in the context of create_subnet method","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"78b7e1ab8b81e4408c19f7724e82ebc055770492","unresolved":false,"context_lines":[{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        if not subnets_client:"},{"line_number":1066,"context_line":"            subnets_client \u003d self.subnets_client"},{"line_number":1067,"context_line":""},{"line_number":1068,"context_line":"        if not routers_client:"},{"line_number":1069,"context_line":"            routers_client \u003d self.routers_client"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"        def cidr_in_use(cidr, project_id):"},{"line_number":1072,"context_line":"            \"\"\"Check cidr existence"}],"source_content_type":"text/x-python","patch_set":1,"id":"2781a4a7_91efa8d7","line":1069,"range":{"start_line":1067,"start_character":0,"end_line":1069,"end_character":48},"in_reply_to":"281bb62b_25245760","updated":"2021-01-05 06:31:52.000000000","message":"Done","commit_id":"c8b38bed3e41a8f5427bc2e2b49616a96b0d7149"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"700a0f125a8ebb83edfef4628cb129d44899ad7f","unresolved":true,"context_lines":[{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"    def create_subnet(self, network, subnets_client\u003dNone,"},{"line_number":1050,"context_line":"                      namestart\u003d\u0027subnet-smoke\u0027,"},{"line_number":1051,"context_line":"                      **kwargs):"},{"line_number":1052,"context_line":"        \"\"\"Create a subnet for the given network"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        This utility creates subnet for the given network"}],"source_content_type":"text/x-python","patch_set":2,"id":"927788d5_f64fcf65","line":1051,"range":{"start_line":1051,"start_character":0,"end_line":1051,"end_character":21},"updated":"2021-01-07 11:06:31.000000000","message":"an unnecessary change","commit_id":"f63b0d911a48ca948297a2aa12a798eb0fb76b79"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"700a0f125a8ebb83edfef4628cb129d44899ad7f","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"                name\u003ddata_utils.rand_name(namestart),"},{"line_number":1103,"context_line":"                network_id\u003dnetwork[\u0027id\u0027],"},{"line_number":1104,"context_line":"                project_id\u003dnetwork[\u0027project_id\u0027],"},{"line_number":1105,"context_line":"                cidr\u003dstr_cidr,"},{"line_number":1106,"context_line":"                ip_version\u003dip_version,"},{"line_number":1107,"context_line":"                **kwargs"},{"line_number":1108,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"25eb74e0_0347e86e","line":1105,"range":{"start_line":1105,"start_character":16,"end_line":1105,"end_character":30},"updated":"2021-01-07 11:06:31.000000000","message":"I have this and manila-tempest-plugin\u0027s implementation side by side and it seems the plugin doesn\u0027t use cidr in subnets_client.create_subnet call when use_default_subnetpool is true, see https://opendev.org/openstack/manila-tempest-plugin/src/commit/3a44bf7401d85b5dea97aa63145bf1f8b1a6e0a9/manila_tempest_tests/tests/scenario/manager.py#L667-L669 in comparison to https://opendev.org/openstack/manila-tempest-plugin/src/commit/3a44bf7401d85b5dea97aa63145bf1f8b1a6e0a9/manila_tempest_tests/tests/scenario/manager.py#L656-L665","commit_id":"f63b0d911a48ca948297a2aa12a798eb0fb76b79"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2cbfad75870bdfb83e7dab625bbe13183f5e0b22","unresolved":true,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        # Repeatedly attempt subnet creation with sequential cidr"},{"line_number":1099,"context_line":"        # blocks until an unallocated block is found."},{"line_number":1100,"context_line":"        for subnet_cidr in tenant_cidr.subnet(num_bits):"},{"line_number":1101,"context_line":"            str_cidr \u003d str(subnet_cidr)"},{"line_number":1102,"context_line":"            if cidr_in_use(str_cidr, project_id\u003dnetwork[\u0027project_id\u0027]):"},{"line_number":1103,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"206704ee_6cf75813","line":1100,"range":{"start_line":1100,"start_character":27,"end_line":1100,"end_character":38},"updated":"2021-01-21 00:16:32.000000000","message":"this is undefined when use_default_subnetpool is True, the for cycle should be under \"if not use_default_subnetpool\" condition","commit_id":"9e862c663a7a706eacb27d14b248856fcac216de"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2cbfad75870bdfb83e7dab625bbe13183f5e0b22","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"            if cidr_in_use(str_cidr, project_id\u003dnetwork[\u0027project_id\u0027]):"},{"line_number":1103,"context_line":"                continue"},{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"            subnet \u003d dict("},{"line_number":1106,"context_line":"                name\u003ddata_utils.rand_name(namestart),"},{"line_number":1107,"context_line":"                network_id\u003dnetwork[\u0027id\u0027],"},{"line_number":1108,"context_line":"                project_id\u003dnetwork[\u0027project_id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"399b0674_60c0121b","line":1105,"range":{"start_line":1105,"start_character":12,"end_line":1105,"end_character":26},"updated":"2021-01-21 00:16:32.000000000","message":"lines 1105 - 1123 are practically _make_create_subnet_request in manila-tempest-plugin -\u003e https://opendev.org/openstack/manila-tempest-plugin/src/commit/ada5b69c78fd5d7a78bc4cf38d9e47d8274e0e3e/manila_tempest_tests/tests/scenario/manager.py#L615-L634\n\nNotice that _make_create_subnet_request is called twice, once when use_default_subnetpool is False (passing str_cidr and using the for loop over subnets) and once when it\u0027s True (not passing str_cidr and in no for loop)\n\nSeems like the code here needs to be edited analogically to manila-tempest-plugin\u0027s one - creating _make_create_subnet_request submethod and etc","commit_id":"9e862c663a7a706eacb27d14b248856fcac216de"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ea60f68b119a930cb1192dd8eaa4d3e72f60ee91","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import subprocess"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"from oslo_serialization import jsonutils as json"}],"source_content_type":"text/x-python","patch_set":7,"id":"d494f3fa_0c535841","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":10},"updated":"2021-02-11 21:16:39.000000000","message":"we do not need to add more six things. we can add python3 only code","commit_id":"ca350d6c953e55423e9378aeb816cbfd5653dc5a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ea60f68b119a930cb1192dd8eaa4d3e72f60ee91","unresolved":true,"context_lines":[{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"        :Keyword Arguments:"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"            * *ip_version \u003d ip version of the given network,"},{"line_number":1073,"context_line":"        \"\"\""},{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":"        if not subnets_client:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5109f935_5edf0024","line":1072,"range":{"start_line":1072,"start_character":59,"end_line":1072,"end_character":60},"updated":"2021-02-11 21:16:39.000000000","message":"please add use_default_subnetpool in kwargs param now","commit_id":"ca350d6c953e55423e9378aeb816cbfd5653dc5a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"43ba4bcc863ce459184c66afaa7e1a962d2f8901","unresolved":true,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"            try:"},{"line_number":1112,"context_line":"                return subnets_client.create_subnet(**subnet)"},{"line_number":1113,"context_line":"            except lib_exc.Conflict:"},{"line_number":1114,"context_line":"                if \u0027overlaps with another subnet\u0027:"},{"line_number":1115,"context_line":"                    raise"},{"line_number":1116,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a597ffe_e8f71248","line":1113,"range":{"start_line":1113,"start_character":35,"end_line":1113,"end_character":36},"updated":"2021-02-14 18:13:23.000000000","message":"\u0027as e\u0027 - this was correct before","commit_id":"9c8d0dfc111b8cb27156a5c2e5960bcd9c80d23f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"43ba4bcc863ce459184c66afaa7e1a962d2f8901","unresolved":true,"context_lines":[{"line_number":1111,"context_line":"            try:"},{"line_number":1112,"context_line":"                return subnets_client.create_subnet(**subnet)"},{"line_number":1113,"context_line":"            except lib_exc.Conflict:"},{"line_number":1114,"context_line":"                if \u0027overlaps with another subnet\u0027:"},{"line_number":1115,"context_line":"                    raise"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        result \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"0821e1b4_74a0efc1","line":1114,"range":{"start_line":1114,"start_character":16,"end_line":1114,"end_character":50},"updated":"2021-02-14 18:13:23.000000000","message":"this is always true .. it should be as before just without six:\nif \u0027...\u0027 not in e:","commit_id":"9c8d0dfc111b8cb27156a5c2e5960bcd9c80d23f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"11c2c6c158c4bfa25e0940f97454e6acbd881483","unresolved":true,"context_lines":[{"line_number":1111,"context_line":"            try:"},{"line_number":1112,"context_line":"                return subnets_client.create_subnet(**subnet)"},{"line_number":1113,"context_line":"            except lib_exc.Conflict as e:"},{"line_number":1114,"context_line":"                if \u0027overlaps with another subnet\u0027 not in e:"},{"line_number":1115,"context_line":"                    raise"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        result \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"b3bfba21_cb7aa930","line":1114,"range":{"start_line":1114,"start_character":57,"end_line":1114,"end_character":58},"updated":"2021-02-24 16:21:57.000000000","message":"str(e)","commit_id":"643c2b80889659fde60faed97878369008031ec6"}]}