)]}'
{"tempest/api/compute/v3/admin/test_quotas.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"551b62d4a708653e5dc51e42c5752549e685abff","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                                  description\u003dtenant_desc)"},{"line_number":122,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":123,"context_line":"        self.addCleanup(identity_client.delete_tenant,"},{"line_number":124,"context_line":"                        tenant_id)"},{"line_number":125,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":126,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FwVo%3D","line":124,"updated":"2014-03-04 09:20:45.000000000","message":"nit: This line can be merged to single line.","commit_id":"4a540ab4ca2521467617ab65ef191367aeed0e1f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"348e1f9fe718ae482994778508a0b0f69e8556c9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                                  description\u003dtenant_desc)"},{"line_number":122,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":123,"context_line":"        self.addCleanup(identity_client.delete_tenant,"},{"line_number":124,"context_line":"                        tenant_id)"},{"line_number":125,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":126,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2Fvcs%3D","line":124,"in_reply_to":"AAAAVn%2F%2FwVo%3D","updated":"2014-03-04 11:23:08.000000000","message":"You\u0027re right, I\u0027ll do so.","commit_id":"4a540ab4ca2521467617ab65ef191367aeed0e1f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"551b62d4a708653e5dc51e42c5752549e685abff","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        self.adm_client.update_quota_set(tenant_id,"},{"line_number":129,"context_line":"                                         ram\u003d\u00275120\u0027)"},{"line_number":130,"context_line":"        self.adm_client.delete_quota_set(tenant_id)"},{"line_number":131,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FwVc%3D","line":129,"updated":"2014-03-04 09:20:45.000000000","message":"ditto\n\nalso better to add the checks of resp.code for detecting some issues faster.","commit_id":"4a540ab4ca2521467617ab65ef191367aeed0e1f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"348e1f9fe718ae482994778508a0b0f69e8556c9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        self.adm_client.update_quota_set(tenant_id,"},{"line_number":129,"context_line":"                                         ram\u003d\u00275120\u0027)"},{"line_number":130,"context_line":"        self.adm_client.delete_quota_set(tenant_id)"},{"line_number":131,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FvYY%3D","line":129,"in_reply_to":"AAAAVn%2F%2FwVc%3D","updated":"2014-03-04 11:23:08.000000000","message":"\u003e also better to add the checks of resp.code for detecting some issues faster.\n?? I\u0027m sorry if I\u0027m mistaken, In test_get_updated_quotas function(Line 97-112) resp.code of update_quota_set is checked already, so I think it\u0027s necessary...  Is it all right?","commit_id":"4a540ab4ca2521467617ab65ef191367aeed0e1f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"551b62d4a708653e5dc51e42c5752549e685abff","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.adm_client.update_quota_set(tenant_id,"},{"line_number":129,"context_line":"                                         ram\u003d\u00275120\u0027)"},{"line_number":130,"context_line":"        self.adm_client.delete_quota_set(tenant_id)"},{"line_number":131,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":134,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FwUQ%3D","line":131,"updated":"2014-03-04 09:20:45.000000000","message":"This assertEqual should work for delete_quota_set because of this test purpose, but this works for get_quota_set now.","commit_id":"4a540ab4ca2521467617ab65ef191367aeed0e1f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"348e1f9fe718ae482994778508a0b0f69e8556c9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.adm_client.update_quota_set(tenant_id,"},{"line_number":129,"context_line":"                                         ram\u003d\u00275120\u0027)"},{"line_number":130,"context_line":"        self.adm_client.delete_quota_set(tenant_id)"},{"line_number":131,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":134,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FvX4%3D","line":131,"in_reply_to":"AAAAVn%2F%2FwUQ%3D","updated":"2014-03-04 11:23:08.000000000","message":"!That\u0027s true! I\u0027ll modify it.","commit_id":"4a540ab4ca2521467617ab65ef191367aeed0e1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e2267cbc0f8397a2e4923a4b0ad6df7d2ff88f8b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":123,"context_line":"        self.addCleanup(identity_client.delete_tenant, tenant_id)"},{"line_number":124,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":125,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.adm_client.update_quota_set(tenant_id, ram\u003d\u00275120\u0027)"},{"line_number":128,"context_line":"        resp, _ \u003d self.adm_client.delete_quota_set(tenant_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FZvw%3D","line":125,"updated":"2014-03-06 10:11:23.000000000","message":"Please check the response code.","commit_id":"4bda517d33910eee9efc7fe2c4e74898a9e623ba"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"b98eb2803e79d1aed74643533d90f4c2f8b0a2a0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":123,"context_line":"        self.addCleanup(identity_client.delete_tenant, tenant_id)"},{"line_number":124,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":125,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.adm_client.update_quota_set(tenant_id, ram\u003d\u00275120\u0027)"},{"line_number":128,"context_line":"        resp, _ \u003d self.adm_client.delete_quota_set(tenant_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FQx4%3D","line":125,"in_reply_to":"AAAAVn%2F%2FZvw%3D","updated":"2014-03-07 07:26:21.000000000","message":"Yes, I\u0027ll do it in the next patch.","commit_id":"4bda517d33910eee9efc7fe2c4e74898a9e623ba"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f5c34b3c13756e6bfd982c76521808869a11e21b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":123,"context_line":"        self.addCleanup(identity_client.delete_tenant, tenant_id)"},{"line_number":124,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":125,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.adm_client.update_quota_set(tenant_id, ram\u003d\u00275120\u0027)"},{"line_number":128,"context_line":"        resp, _ \u003d self.adm_client.delete_quota_set(tenant_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2B9uc%3D","line":125,"in_reply_to":"AAAAVn%2F%2FZvw%3D","updated":"2014-03-11 01:00:39.000000000","message":"good point, we need to check it.","commit_id":"4bda517d33910eee9efc7fe2c4e74898a9e623ba"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e2267cbc0f8397a2e4923a4b0ad6df7d2ff88f8b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":125,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.adm_client.update_quota_set(tenant_id, ram\u003d\u00275120\u0027)"},{"line_number":128,"context_line":"        resp, _ \u003d self.adm_client.delete_quota_set(tenant_id)"},{"line_number":129,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FZvM%3D","line":127,"updated":"2014-03-06 10:11:23.000000000","message":"Same as above","commit_id":"4bda517d33910eee9efc7fe2c4e74898a9e623ba"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"b98eb2803e79d1aed74643533d90f4c2f8b0a2a0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":125,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.adm_client.update_quota_set(tenant_id, ram\u003d\u00275120\u0027)"},{"line_number":128,"context_line":"        resp, _ \u003d self.adm_client.delete_quota_set(tenant_id)"},{"line_number":129,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FQx0%3D","line":127,"in_reply_to":"AAAAVn%2F%2FZvM%3D","updated":"2014-03-07 07:26:21.000000000","message":"Done","commit_id":"4bda517d33910eee9efc7fe2c4e74898a9e623ba"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e2267cbc0f8397a2e4923a4b0ad6df7d2ff88f8b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":132,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FZtI%3D","line":132,"updated":"2014-03-06 10:11:23.000000000","message":"I think we can check the response error code to confirm whether quota is deleted or not.","commit_id":"4bda517d33910eee9efc7fe2c4e74898a9e623ba"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"b98eb2803e79d1aed74643533d90f4c2f8b0a2a0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":132,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FQxw%3D","line":132,"in_reply_to":"AAAAVn%2F%2FZtI%3D","updated":"2014-03-07 07:26:21.000000000","message":"Done","commit_id":"4bda517d33910eee9efc7fe2c4e74898a9e623ba"}]}