)]}'
{"tempest/api/compute/admin/test_quotas.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3baa9c9985d0e4640a05e2cab7812af5163006bb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.adm_client.update_quota_set(tenant_id,"},{"line_number":111,"context_line":"                                         ram\u003d\u00275120\u0027)"},{"line_number":112,"context_line":"        self.adm_client.delete_quota_set(tenant_id)"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":116,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FN0o%3D","line":113,"updated":"2014-03-07 15:20:24.000000000","message":"You are testing the response code of a call made 4 lines above. You are not testing the response code of the DELETE api call. Is it normal ?","commit_id":"31db25a34cbc24368bc025b3e8faea00d0ec5d9d"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"961517f1cb12545a8d99e22e2cadb2a16a70fe04","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.adm_client.update_quota_set(tenant_id,"},{"line_number":111,"context_line":"                                         ram\u003d\u00275120\u0027)"},{"line_number":112,"context_line":"        self.adm_client.delete_quota_set(tenant_id)"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":116,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2By0k%3D","line":113,"in_reply_to":"AAAAVn%2F%2B5Iw%3D","updated":"2014-03-12 05:10:19.000000000","message":"That\u0027s right. I\u0027ll update in the next patch.","commit_id":"31db25a34cbc24368bc025b3e8faea00d0ec5d9d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ce7ff3c4a162b1342b3419ff3a19e54c78de2346","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.adm_client.update_quota_set(tenant_id,"},{"line_number":111,"context_line":"                                         ram\u003d\u00275120\u0027)"},{"line_number":112,"context_line":"        self.adm_client.delete_quota_set(tenant_id)"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":116,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B5Iw%3D","line":113,"in_reply_to":"AAAAVn%2F%2FN0o%3D","updated":"2014-03-11 14:03:22.000000000","message":"Agreed, here should check resp.status of DELETE quota_set.\n\nWe need to check resp.status of UPDATE also.\n\nso here should be\n\n resp, body \u003d adm_client.update_quota_set(tenant_id, ram\u003d\u00275120\u0027)\n self.assertEqual(2XX, resp.status)\n resp, body \u003d self.adm_client.delete_quota_set(tenant_id)\n self.assertEqual(2XX, resp.status)","commit_id":"31db25a34cbc24368bc025b3e8faea00d0ec5d9d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ce7ff3c4a162b1342b3419ff3a19e54c78de2346","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":116,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class QuotasAdminTestXML(QuotasAdminTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B5Ig%3D","line":116,"updated":"2014-03-11 14:03:22.000000000","message":"self.assertEqual(200, resp.status) is necessary.","commit_id":"31db25a34cbc24368bc025b3e8faea00d0ec5d9d"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"961517f1cb12545a8d99e22e2cadb2a16a70fe04","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, quota_set_new \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":116,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class QuotasAdminTestXML(QuotasAdminTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2By0s%3D","line":116,"in_reply_to":"AAAAVn%2F%2B5Ig%3D","updated":"2014-03-12 05:10:19.000000000","message":"Done","commit_id":"31db25a34cbc24368bc025b3e8faea00d0ec5d9d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a21a19afe796939023757f9037632fcee076d242","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":97,"context_line":"    def test_delete_quota(self):"},{"line_number":98,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":99,"context_line":"        tenant_name \u003d data_utils.rand_name(\u0027cpu_quota_tenant_\u0027)"},{"line_number":100,"context_line":"        tenant_desc \u003d tenant_name + \u0027-desc\u0027"},{"line_number":101,"context_line":"        identity_client \u003d self.os_adm.identity_client"},{"line_number":102,"context_line":"        _, tenant \u003d identity_client.create_tenant(name\u003dtenant_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FvHI%3D","line":99,"updated":"2014-03-14 05:47:21.000000000","message":"nit: s/cpu_quota/ram_quota/ because of the following quota set.","commit_id":"9fe7039608e1ddb5ace82d0918815a3293c36f8f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"b73d366994546899c3675622ca82b1b8c80049c6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":97,"context_line":"    def test_delete_quota(self):"},{"line_number":98,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":99,"context_line":"        tenant_name \u003d data_utils.rand_name(\u0027cpu_quota_tenant_\u0027)"},{"line_number":100,"context_line":"        tenant_desc \u003d tenant_name + \u0027-desc\u0027"},{"line_number":101,"context_line":"        identity_client \u003d self.os_adm.identity_client"},{"line_number":102,"context_line":"        _, tenant \u003d identity_client.create_tenant(name\u003dtenant_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FvC8%3D","line":99,"in_reply_to":"AAAAWH%2F%2FvHI%3D","updated":"2014-03-14 06:05:20.000000000","message":"Done","commit_id":"9fe7039608e1ddb5ace82d0918815a3293c36f8f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a21a19afe796939023757f9037632fcee076d242","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                  description\u003dtenant_desc)"},{"line_number":104,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":105,"context_line":"        self.addCleanup(identity_client.delete_tenant,"},{"line_number":106,"context_line":"                        tenant_id)"},{"line_number":107,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":108,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2ByU0%3D","line":106,"updated":"2014-03-14 05:47:21.000000000","message":"nit: line 105-106 can be merged into one line.","commit_id":"9fe7039608e1ddb5ace82d0918815a3293c36f8f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"b73d366994546899c3675622ca82b1b8c80049c6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                  description\u003dtenant_desc)"},{"line_number":104,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":105,"context_line":"        self.addCleanup(identity_client.delete_tenant,"},{"line_number":106,"context_line":"                        tenant_id)"},{"line_number":107,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":108,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FvC4%3D","line":106,"in_reply_to":"AAAAVn%2F%2ByU0%3D","updated":"2014-03-14 06:05:20.000000000","message":"Done. L90-91 can be mergied into one line, too. Should I modify it? Or out of scope? I want you hear your opinion.","commit_id":"9fe7039608e1ddb5ace82d0918815a3293c36f8f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"05f18a93cb4c495d40e562d1fe41c9ad6bb130e6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                  description\u003dtenant_desc)"},{"line_number":104,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":105,"context_line":"        self.addCleanup(identity_client.delete_tenant,"},{"line_number":106,"context_line":"                        tenant_id)"},{"line_number":107,"context_line":"        resp, quota_set_default \u003d self.adm_client.get_quota_set(tenant_id)"},{"line_number":108,"context_line":"        ram_default \u003d quota_set_default[\u0027ram\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fu3I%3D","line":106,"in_reply_to":"AAAAWH%2F%2FvC4%3D","updated":"2014-03-14 06:08:35.000000000","message":"line90-91 would be out of scope for this patch, I think.","commit_id":"9fe7039608e1ddb5ace82d0918815a3293c36f8f"}]}