)]}'
{"doc/source/data/tempest-excluded-plugins-registry.header":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Excluded Plugins"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"List of Tempest plugin projects that are stale or unmaintained for a long"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"be3e0413_57c549d1","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":9},"updated":"2021-01-15 00:18:05.000000000","message":"let\u0027s say \u0027Non Active Plugins\u0027 which is more clear than \u0027Excluded\u0027 same for file name.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Excluded Plugins"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"List of Tempest plugin projects that are stale or unmaintained for a long"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"8f197d94_960c0fdc","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":9},"in_reply_to":"be3e0413_57c549d1","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"List of Tempest plugin projects that are stale or unmaintained for a long"},{"line_number":5,"context_line":"time (6 months or more). They can be moved out of excludelist state once one"},{"line_number":6,"context_line":"of the relevant patches gets merged:"},{"line_number":7,"context_line":"https://review.opendev.org/#/q/topic:tempest-sanity-gate+%28status:open%29"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"a01b893c_1a859628","line":5,"range":{"start_line":5,"start_character":50,"end_line":5,"end_character":62},"updated":"2021-01-15 00:18:05.000000000","message":"nonactivelist","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"List of Tempest plugin projects that are stale or unmaintained for a long"},{"line_number":5,"context_line":"time (6 months or more). They can be moved out of excludelist state once one"},{"line_number":6,"context_line":"of the relevant patches gets merged:"},{"line_number":7,"context_line":"https://review.opendev.org/#/q/topic:tempest-sanity-gate+%28status:open%29"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fc5fbf5b_d504a906","line":5,"range":{"start_line":5,"start_character":50,"end_line":5,"end_character":62},"in_reply_to":"a01b893c_1a859628","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"}],"doc/source/overview.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":113,"context_line":"   There is also the option to use `stestr`_ directly. For example, from"},{"line_number":114,"context_line":"   the workspace dir run::"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    $ stestr run --exclude-list \u0027\\[.*\\bslow\\b.*\\]\u0027 \u0027^tempest\\.(api|scenario)\u0027"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"   will run the same set of tests as the default gate jobs. Or you can"},{"line_number":119,"context_line":"   use `unittest`_ compatible test runners such as `stestr`_, `pytest`_ etc."}],"source_content_type":"text/x-rst","patch_set":3,"id":"6d9e4799_06f08802","line":116,"range":{"start_line":116,"start_character":17,"end_line":116,"end_character":31},"updated":"2021-01-15 00:18:05.000000000","message":"--exclusion-regex as --exclude-list is different arg","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"   There is also the option to use `stestr`_ directly. For example, from"},{"line_number":114,"context_line":"   the workspace dir run::"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    $ stestr run --exclude-list \u0027\\[.*\\bslow\\b.*\\]\u0027 \u0027^tempest\\.(api|scenario)\u0027"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"   will run the same set of tests as the default gate jobs. Or you can"},{"line_number":119,"context_line":"   use `unittest`_ compatible test runners such as `stestr`_, `pytest`_ etc."}],"source_content_type":"text/x-rst","patch_set":3,"id":"0822bcb1_ad5bde74","line":116,"range":{"start_line":116,"start_character":17,"end_line":116,"end_character":31},"in_reply_to":"6d9e4799_06f08802","updated":"2021-01-15 13:49:44.000000000","message":"oh, yeah, thanks","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"}],"etc/allow-list.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7ebe77e9_67203619","updated":"2021-01-15 00:18:05.000000000","message":"we should rename it to include-list.yaml","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f6e20a88_6beb2f71","in_reply_to":"7ebe77e9_67203619","updated":"2021-01-15 13:49:44.000000000","message":"I begun with that first, however then I noticed the context in which the file is used (tools/check_logs.py) and it made more sense to name it allow-list than include-list .. I have no problem renaming it, I just thought this way it\u0027s more clear what it does resp. what it contains.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3a780116aad255909d08107fab4e71a86d53fb0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7bbae377_9dad6cd7","in_reply_to":"f6e20a88_6beb2f71","updated":"2021-01-15 20:50:11.000000000","message":"i see, i thought this is we use for whitelist in stestr or so. allow-list lgtm","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"}],"roles/run-tempest/tasks/main.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Run Tempest"},{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"83dedb7d_678d8614","line":82,"range":{"start_line":82,"start_character":11,"end_line":82,"end_character":80},"updated":"2021-01-15 00:18:05.000000000","message":"will this work if both are set by jobs?\n\nwe need to use either of one with first priority to exclude_list_option if both set","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d83ebd3d6cb6a4c9cc9f02cebba10f7bdddceb24","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Run Tempest"},{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4cbb51c6_6320ef2e","line":82,"range":{"start_line":82,"start_character":11,"end_line":82,"end_character":80},"in_reply_to":"0f740ba9_542f3278","updated":"2021-01-18 17:41:32.000000000","message":"that\u0027s correct, when both are set by mistake then we could just ignore old one but this way it might be silent ignore which can be false run and do not tell user that your old var setting is not used. raising error from tox env is right thing.\n\nI am good here now.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3a780116aad255909d08107fab4e71a86d53fb0","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Run Tempest"},{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"92b63f1f_cc078354","line":82,"range":{"start_line":82,"start_character":11,"end_line":82,"end_character":80},"in_reply_to":"4e43a3f2_60ea1b4d","updated":"2021-01-15 20:50:11.000000000","message":"with correct use case yes nobody is supposed to use both but we never know and this is much possible with job inheritance where base job using old and other new one. it is better if add logic to fallback to newer one if both are set. something similar to tempest_exclude_regex","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Run Tempest"},{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4e43a3f2_60ea1b4d","line":82,"range":{"start_line":82,"start_character":11,"end_line":82,"end_character":80},"in_reply_to":"83dedb7d_678d8614","updated":"2021-01-15 13:49:44.000000000","message":"only one of them is supposed to be set .. the consumers who haven\u0027t done the diversity change yet will set the old one and if they have already done the change, they will set the new one ... there shouldn\u0027t be a case when both of the vars are set if I\u0027m not mistaken.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9c68d0f0ad5e8c1342785b7edeee479b79253874","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Run Tempest"},{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0f740ba9_542f3278","line":82,"range":{"start_line":82,"start_character":11,"end_line":82,"end_character":80},"in_reply_to":"92b63f1f_cc078354","updated":"2021-01-18 09:27:00.000000000","message":"exclude_list_option contains --exclude-list param while blacklist_option contains the old one (--blacklist-file) .. my thinking here was that in cases this role is used with tempest which doesn\u0027t support the new params yet the role users would use the old role vars (tempest_test_blacklist and thus blacklist_option) and they would switch to the new ones when they run newer tempest","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"},{"line_number":86,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":87,"context_line":"  register: tempest_run_result"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"525e71ac_02a582ea","line":84,"range":{"start_line":84,"start_character":14,"end_line":84,"end_character":25},"updated":"2021-01-15 00:18:05.000000000","message":"you can change this to new param","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9ad4aec67cfe510e2c1ded2f06504abaedbbc16b","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"},{"line_number":86,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":87,"context_line":"  register: tempest_run_result"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5e923a48_6b583539","line":84,"range":{"start_line":84,"start_character":14,"end_line":84,"end_character":25},"in_reply_to":"077ad5c7_be6c8bfd","updated":"2021-01-19 19:53:17.000000000","message":"in the next patch set I\u0027m gonna write it the way that if a user uses old role var -\u003e old param (--black-regex) will be used, if new role var -\u003e new param (--exclude-regex) will be used. This way consumers will control param usage (new/old) by role var usage (new/old) which should be intuitive when making changes on all consumers sides.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"},{"line_number":86,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":87,"context_line":"  register: tempest_run_result"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"db9734e0_c86581c2","line":84,"range":{"start_line":84,"start_character":14,"end_line":84,"end_character":25},"in_reply_to":"525e71ac_02a582ea","updated":"2021-01-15 13:49:44.000000000","message":"true","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9c68d0f0ad5e8c1342785b7edeee479b79253874","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"},{"line_number":86,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":87,"context_line":"  register: tempest_run_result"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dd2fa1bf_87313bb6","line":84,"range":{"start_line":84,"start_character":14,"end_line":84,"end_character":25},"in_reply_to":"db9734e0_c86581c2","updated":"2021-01-18 09:27:00.000000000","message":"hm, can we really change this to the new param? My concern is usage of this role with older tempest tags where the new param is not defined.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d83ebd3d6cb6a4c9cc9f02cebba10f7bdddceb24","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  command: tox -e {{tox_envlist}} {{tox_extra_args}} -- {{tempest_test_regex|quote}} \\"},{"line_number":82,"context_line":"           {{blacklist_option|default(\u0027\u0027)}}  {{exclude_list_option|default(\u0027\u0027)}} \\"},{"line_number":83,"context_line":"            --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}} \\"},{"line_number":84,"context_line":"            --black-regex\u003d{{tempest_exclude_regex|quote}}"},{"line_number":85,"context_line":"  args:"},{"line_number":86,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":87,"context_line":"  register: tempest_run_result"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"077ad5c7_be6c8bfd","line":84,"range":{"start_line":84,"start_character":14,"end_line":84,"end_character":25},"in_reply_to":"dd2fa1bf_87313bb6","updated":"2021-01-18 17:41:32.000000000","message":"yeah with the way how zuul use the playbook and checkout the repo, this can be issue. But at some point we have to move to new var and same issue can happen.\n\nhow about doing this also like blacklist_option and exclude_list_option way? so that we pass the right one what job use and that can work with new or old tempest. But this is something we should test with old new tempest.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"}],"tempest/cmd/run.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":22,"context_line":"* ``--regex/-r``: This is a selection regex like what stestr uses. It will run"},{"line_number":23,"context_line":"  any tests that match on re.match() with the regex"},{"line_number":24,"context_line":"* ``--smoke/-s``: Run all the tests tagged as smoke"},{"line_number":25,"context_line":"* ``--exclude-list``: It allows to do simple test exclusion via passing a"},{"line_number":26,"context_line":"  rejection/exclude regexp"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"There are also the ``--exclude-list`` and ``--include-list`` options that"}],"source_content_type":"text/x-python","patch_set":3,"id":"20248cc0_b11f060e","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":18},"updated":"2021-01-15 00:18:05.000000000","message":"exclude-regex as exclude-list is different arg.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"* ``--regex/-r``: This is a selection regex like what stestr uses. It will run"},{"line_number":23,"context_line":"  any tests that match on re.match() with the regex"},{"line_number":24,"context_line":"* ``--smoke/-s``: Run all the tests tagged as smoke"},{"line_number":25,"context_line":"* ``--exclude-list``: It allows to do simple test exclusion via passing a"},{"line_number":26,"context_line":"  rejection/exclude regexp"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"There are also the ``--exclude-list`` and ``--include-list`` options that"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a31c80e_9d3c3d5a","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":18},"in_reply_to":"20248cc0_b11f060e","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":262,"context_line":"                return_code \u003d commands.run_command("},{"line_number":263,"context_line":"                    **params, exclude_list\u003dex_list,"},{"line_number":264,"context_line":"                    include_list\u003din_list, exclude_regex\u003dex_regex)"},{"line_number":265,"context_line":"            except Exception:"},{"line_number":266,"context_line":"                # exclude_list, include_list and exclude_regex are defined only"},{"line_number":267,"context_line":"                # in stestr \u003e\u003d 3.1.0, this except block catches the case when"},{"line_number":268,"context_line":"                # tempest is executed with an older stestr"}],"source_content_type":"text/x-python","patch_set":3,"id":"31745b71_a0e6989a","line":265,"range":{"start_line":265,"start_character":28,"end_line":265,"end_character":29},"updated":"2021-01-15 00:18:05.000000000","message":"I think we should catch only arg error here instead of catching any exception and try again","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                return_code \u003d commands.run_command("},{"line_number":263,"context_line":"                    **params, exclude_list\u003dex_list,"},{"line_number":264,"context_line":"                    include_list\u003din_list, exclude_regex\u003dex_regex)"},{"line_number":265,"context_line":"            except Exception:"},{"line_number":266,"context_line":"                # exclude_list, include_list and exclude_regex are defined only"},{"line_number":267,"context_line":"                # in stestr \u003e\u003d 3.1.0, this except block catches the case when"},{"line_number":268,"context_line":"                # tempest is executed with an older stestr"}],"source_content_type":"text/x-python","patch_set":3,"id":"1e6f1ed0_0c6ce2a5","line":265,"range":{"start_line":265,"start_character":28,"end_line":265,"end_character":29},"in_reply_to":"31745b71_a0e6989a","updated":"2021-01-15 13:49:44.000000000","message":"it throws a TypeError, e.g.\nTypeError: run_command() got an unexpected keyword argument \u0027exclude_list\u0027    \n\nI\u0027ll make the except more specific","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":322,"context_line":"                           help\u003d\u0027A normal stestr selection regex used to \u0027"},{"line_number":323,"context_line":"                                \u0027specify a subset of tests to run\u0027)"},{"line_number":324,"context_line":"        parser.add_argument(\u0027--black-regex\u0027, dest\u003d\u0027black_regex\u0027,"},{"line_number":325,"context_line":"                            help\u003d\u0027DEPRECATED: This option will soon be \u0027"},{"line_number":326,"context_line":"                                 \u0027replaced by --exclude-regex which is \u0027"},{"line_number":327,"context_line":"                                 \u0027functionally equivalent. If this is \u0027"},{"line_number":328,"context_line":"                                 \u0027specified at the same time as \u0027"},{"line_number":329,"context_line":"                                 \u0027--exclude-regex, this flag will be ignored \u0027"},{"line_number":330,"context_line":"                                 \u0027and --exclude-regex will be used\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2a7eee90_bd8d6047","line":327,"range":{"start_line":325,"start_character":46,"end_line":327,"end_character":58},"updated":"2021-01-15 00:18:05.000000000","message":"this already replace in this change may be we can say.\n\nThis option is deprecated and will be removed soon, use\n--exclude-regex instead.....","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                           help\u003d\u0027A normal stestr selection regex used to \u0027"},{"line_number":323,"context_line":"                                \u0027specify a subset of tests to run\u0027)"},{"line_number":324,"context_line":"        parser.add_argument(\u0027--black-regex\u0027, dest\u003d\u0027black_regex\u0027,"},{"line_number":325,"context_line":"                            help\u003d\u0027DEPRECATED: This option will soon be \u0027"},{"line_number":326,"context_line":"                                 \u0027replaced by --exclude-regex which is \u0027"},{"line_number":327,"context_line":"                                 \u0027functionally equivalent. If this is \u0027"},{"line_number":328,"context_line":"                                 \u0027specified at the same time as \u0027"},{"line_number":329,"context_line":"                                 \u0027--exclude-regex, this flag will be ignored \u0027"},{"line_number":330,"context_line":"                                 \u0027and --exclude-regex will be used\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f47dd833_8573e227","line":327,"range":{"start_line":325,"start_character":46,"end_line":327,"end_character":58},"in_reply_to":"2a7eee90_bd8d6047","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":331,"context_line":"        parser.add_argument(\u0027--exclude-regex\u0027, dest\u003d\u0027exclude_regex\u0027,"},{"line_number":332,"context_line":"                            help\u003d\u0027A regex to exclude tests that match it\u0027)"},{"line_number":333,"context_line":"        parser.add_argument(\u0027--whitelist-file\u0027, \u0027--whitelist_file\u0027,"},{"line_number":334,"context_line":"                            help\u003d\u0027DEPRECATED: This option will soon be \u0027"},{"line_number":335,"context_line":"                                 \u0027replaced by --include-list which is \u0027"},{"line_number":336,"context_line":"                                 \u0027functionally equivalent. If this is \u0027"},{"line_number":337,"context_line":"                                 \u0027specified at the same time as \u0027"},{"line_number":338,"context_line":"                                 \u0027--include-list, this flag will be ignored \u0027"},{"line_number":339,"context_line":"                                 \u0027and --include-list will be used\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"87dd97e2_3ca4f16b","line":336,"range":{"start_line":334,"start_character":46,"end_line":336,"end_character":58},"updated":"2021-01-15 00:18:05.000000000","message":"ditto","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        parser.add_argument(\u0027--exclude-regex\u0027, dest\u003d\u0027exclude_regex\u0027,"},{"line_number":332,"context_line":"                            help\u003d\u0027A regex to exclude tests that match it\u0027)"},{"line_number":333,"context_line":"        parser.add_argument(\u0027--whitelist-file\u0027, \u0027--whitelist_file\u0027,"},{"line_number":334,"context_line":"                            help\u003d\u0027DEPRECATED: This option will soon be \u0027"},{"line_number":335,"context_line":"                                 \u0027replaced by --include-list which is \u0027"},{"line_number":336,"context_line":"                                 \u0027functionally equivalent. If this is \u0027"},{"line_number":337,"context_line":"                                 \u0027specified at the same time as \u0027"},{"line_number":338,"context_line":"                                 \u0027--include-list, this flag will be ignored \u0027"},{"line_number":339,"context_line":"                                 \u0027and --include-list will be used\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5cc16ad9_dd7ea6d9","line":336,"range":{"start_line":334,"start_character":46,"end_line":336,"end_character":58},"in_reply_to":"87dd97e2_3ca4f16b","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":338,"context_line":"                                 \u0027--include-list, this flag will be ignored \u0027"},{"line_number":339,"context_line":"                                 \u0027and --include-list will be used\u0027)"},{"line_number":340,"context_line":"        parser.add_argument(\u0027--include-list\u0027, \u0027--include_list\u0027,"},{"line_number":341,"context_line":"                            help\u003d\"Path to an include file, this file \""},{"line_number":342,"context_line":"                            \"contains a separate regex on each \""},{"line_number":343,"context_line":"                            \"newline.\")"},{"line_number":344,"context_line":"        parser.add_argument(\u0027--blacklist-file\u0027, \u0027--blacklist_file\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf31f407_4788a089","line":341,"range":{"start_line":341,"start_character":57,"end_line":341,"end_character":58},"updated":"2021-01-15 00:18:05.000000000","message":"this is not so clear now,\n\n\u0027Path to an include file which contains the regex for test to be included in tempest run, this file contains a separate regex on each newline.\")","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                                 \u0027--include-list, this flag will be ignored \u0027"},{"line_number":339,"context_line":"                                 \u0027and --include-list will be used\u0027)"},{"line_number":340,"context_line":"        parser.add_argument(\u0027--include-list\u0027, \u0027--include_list\u0027,"},{"line_number":341,"context_line":"                            help\u003d\"Path to an include file, this file \""},{"line_number":342,"context_line":"                            \"contains a separate regex on each \""},{"line_number":343,"context_line":"                            \"newline.\")"},{"line_number":344,"context_line":"        parser.add_argument(\u0027--blacklist-file\u0027, \u0027--blacklist_file\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f47c81b0_27d0a821","line":341,"range":{"start_line":341,"start_character":57,"end_line":341,"end_character":58},"in_reply_to":"bf31f407_4788a089","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":342,"context_line":"                            \"contains a separate regex on each \""},{"line_number":343,"context_line":"                            \"newline.\")"},{"line_number":344,"context_line":"        parser.add_argument(\u0027--blacklist-file\u0027, \u0027--blacklist_file\u0027,"},{"line_number":345,"context_line":"                            help\u003d\u0027DEPRECATED: This option will soon be  \u0027"},{"line_number":346,"context_line":"                                 \u0027replaced by --exclude-list which is \u0027"},{"line_number":347,"context_line":"                                 \u0027functionally equivalent. If this is \u0027"},{"line_number":348,"context_line":"                                 \u0027specified at the same time as \u0027"},{"line_number":349,"context_line":"                                 \u0027--exclude-list, this flag will be ignored \u0027"},{"line_number":350,"context_line":"                                 \u0027and --exclude-list will be used\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"8939f1e5_34b685ab","line":347,"range":{"start_line":345,"start_character":47,"end_line":347,"end_character":58},"updated":"2021-01-15 00:18:05.000000000","message":"ditto","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                            \"contains a separate regex on each \""},{"line_number":343,"context_line":"                            \"newline.\")"},{"line_number":344,"context_line":"        parser.add_argument(\u0027--blacklist-file\u0027, \u0027--blacklist_file\u0027,"},{"line_number":345,"context_line":"                            help\u003d\u0027DEPRECATED: This option will soon be  \u0027"},{"line_number":346,"context_line":"                                 \u0027replaced by --exclude-list which is \u0027"},{"line_number":347,"context_line":"                                 \u0027functionally equivalent. If this is \u0027"},{"line_number":348,"context_line":"                                 \u0027specified at the same time as \u0027"},{"line_number":349,"context_line":"                                 \u0027--exclude-list, this flag will be ignored \u0027"},{"line_number":350,"context_line":"                                 \u0027and --exclude-list will be used\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ae5d47ae_488c548a","line":347,"range":{"start_line":345,"start_character":47,"end_line":347,"end_character":58},"in_reply_to":"8939f1e5_34b685ab","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":349,"context_line":"                                 \u0027--exclude-list, this flag will be ignored \u0027"},{"line_number":350,"context_line":"                                 \u0027and --exclude-list will be used\u0027)"},{"line_number":351,"context_line":"        parser.add_argument(\u0027--exclude-list\u0027, \u0027--exclude_list\u0027,"},{"line_number":352,"context_line":"                            help\u003d\u0027Path to a blacklist file, this file \u0027"},{"line_number":353,"context_line":"                                 \u0027contains a separate regex exclude on \u0027"},{"line_number":354,"context_line":"                                 \u0027each newline\u0027)"},{"line_number":355,"context_line":"        parser.add_argument(\u0027--load-list\u0027, \u0027--load_list\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2080e3f8_88ef5c97","line":352,"range":{"start_line":352,"start_character":44,"end_line":352,"end_character":54},"updated":"2021-01-15 00:18:05.000000000","message":"s/blacklist/exclude.\n\n\u0027Path to an exclude file which contains the regex for test to be excluded in tempest run, this file contains a separate regex on each newline.\")","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                                 \u0027--exclude-list, this flag will be ignored \u0027"},{"line_number":350,"context_line":"                                 \u0027and --exclude-list will be used\u0027)"},{"line_number":351,"context_line":"        parser.add_argument(\u0027--exclude-list\u0027, \u0027--exclude_list\u0027,"},{"line_number":352,"context_line":"                            help\u003d\u0027Path to a blacklist file, this file \u0027"},{"line_number":353,"context_line":"                                 \u0027contains a separate regex exclude on \u0027"},{"line_number":354,"context_line":"                                 \u0027each newline\u0027)"},{"line_number":355,"context_line":"        parser.add_argument(\u0027--load-list\u0027, \u0027--load_list\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"92dd9e72_00da8800","line":352,"range":{"start_line":352,"start_character":44,"end_line":352,"end_character":54},"in_reply_to":"2080e3f8_88ef5c97","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":32330,"name":"Arun Nagarajan","email":"arun.nagarajan@ericsson.com","username":"arun-n2k20"},"change_message_id":"9c33cce6ad458cfae0c69bd0244be2d370432ac5","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                return_code \u003d commands.list_command("},{"line_number":242,"context_line":"                    filters\u003dregex, include_list\u003din_list,"},{"line_number":243,"context_line":"                    exclude_list\u003dex_list, exclude_regex\u003dex_regex)"},{"line_number":244,"context_line":"            except TypeError as e:"},{"line_number":245,"context_line":"                if \"got an unexpected keyword argument\" not in str(e):"},{"line_number":246,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"1dff288a_9a6babf7","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":65},"updated":"2021-01-15 14:51:09.000000000","message":"For this \u0027try\u0027 to have any chance, shouldn\u0027t tempest use stestr\u003e\u003d3.1.0? Currently stestr is pinned at \u0027stestr\u003e\u003d1.0.0\u0027 in requirements.txt - shouldn\u0027t this be changed to \u00273.1.0\u0027 also? This should be ok, since stestr 3.1.0 supports both the options for now and the old options are planned to be discarded only in 4.x release...","commit_id":"b4409614fd42028f22e66ccce29ad733b9d2c871"},{"author":{"_account_id":32330,"name":"Arun Nagarajan","email":"arun.nagarajan@ericsson.com","username":"arun-n2k20"},"change_message_id":"46533e1b2a08ef0f202e6a5decbf5a2e809c4adf","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                return_code \u003d commands.list_command("},{"line_number":242,"context_line":"                    filters\u003dregex, include_list\u003din_list,"},{"line_number":243,"context_line":"                    exclude_list\u003dex_list, exclude_regex\u003dex_regex)"},{"line_number":244,"context_line":"            except TypeError as e:"},{"line_number":245,"context_line":"                if \"got an unexpected keyword argument\" not in str(e):"},{"line_number":246,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"8bb0989e_324a040f","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":65},"in_reply_to":"12652830_5101f2de","updated":"2021-01-15 16:21:25.000000000","message":"Understood! I\u0027m good with this😊","commit_id":"b4409614fd42028f22e66ccce29ad733b9d2c871"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c3cf477a515da58114fa30e8dcc76bfa0e4c4986","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                return_code \u003d commands.list_command("},{"line_number":242,"context_line":"                    filters\u003dregex, include_list\u003din_list,"},{"line_number":243,"context_line":"                    exclude_list\u003dex_list, exclude_regex\u003dex_regex)"},{"line_number":244,"context_line":"            except TypeError as e:"},{"line_number":245,"context_line":"                if \"got an unexpected keyword argument\" not in str(e):"},{"line_number":246,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"12652830_5101f2de","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":65},"in_reply_to":"1dff288a_9a6babf7","updated":"2021-01-15 15:49:45.000000000","message":"yes, this try block will be successfully executed only when stestr\u003e\u003d3.1.0, however, if stestr\u003c3.1.0 then it will throw an exception and the execution will fall to the except block below where where the old options are passed to stestr.","commit_id":"b4409614fd42028f22e66ccce29ad733b9d2c871"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3a780116aad255909d08107fab4e71a86d53fb0","unresolved":true,"context_lines":[{"line_number":265,"context_line":"                    **params, exclude_list\u003dex_list,"},{"line_number":266,"context_line":"                    include_list\u003din_list, exclude_regex\u003dex_regex)"},{"line_number":267,"context_line":"            except TypeError as e:"},{"line_number":268,"context_line":"                if \"got an unexpected keyword argument\" not in str(e):"},{"line_number":269,"context_line":"                    raise"},{"line_number":270,"context_line":"                # exclude_list, include_list and exclude_regex are defined only"},{"line_number":271,"context_line":"                # in stestr \u003e\u003d 3.1.0, this except block catches the case when"}],"source_content_type":"text/x-python","patch_set":4,"id":"61409a18_763d27af","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":70},"updated":"2021-01-15 20:50:11.000000000","message":"honestly saying I do not trust on error messages :) as they are not stable interface contract and something any modification even format/spell etc can break its usage. catching TypeError is enough here","commit_id":"b4409614fd42028f22e66ccce29ad733b9d2c871"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9c68d0f0ad5e8c1342785b7edeee479b79253874","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                    **params, exclude_list\u003dex_list,"},{"line_number":266,"context_line":"                    include_list\u003din_list, exclude_regex\u003dex_regex)"},{"line_number":267,"context_line":"            except TypeError as e:"},{"line_number":268,"context_line":"                if \"got an unexpected keyword argument\" not in str(e):"},{"line_number":269,"context_line":"                    raise"},{"line_number":270,"context_line":"                # exclude_list, include_list and exclude_regex are defined only"},{"line_number":271,"context_line":"                # in stestr \u003e\u003d 3.1.0, this except block catches the case when"}],"source_content_type":"text/x-python","patch_set":4,"id":"a671d820_9d4d2b8b","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":70},"in_reply_to":"61409a18_763d27af","updated":"2021-01-18 09:27:00.000000000","message":"sure, I\u0027ll edit in the next patch set","commit_id":"b4409614fd42028f22e66ccce29ad733b9d2c871"}],"tempest/tests/cmd/test_run.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        self.assertRunExit([\u0027tempest\u0027, \u0027run\u0027, \u0027--regex\u0027, \u0027failing\u0027], 1)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_tempest_run_blackregex_failing(self):"},{"line_number":119,"context_line":"        self.assertRunExit([\u0027tempest\u0027, \u0027run\u0027, \u0027--black-regex\u0027, \u0027failing\u0027], 0)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_tempest_run_blackregex_failing_with_stestr_repository(self):"},{"line_number":122,"context_line":"        subprocess.call([\u0027stestr\u0027, \u0027init\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf849d1c_08875646","side":"PARENT","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":77},"updated":"2021-01-15 00:18:05.000000000","message":"we need to keep these tests for old deprecated arg but still supported and remove once we actually remove them.\n\nfor new arg we can add new test class but by reusing code.\n\nmay be we can go like below:\n- rename test to test_tempest_run_exclude_regex_failing (with new arg name)\n- toggle the old and new arg with two test class level arg\n\nsomething like\n\nTestOldArgRunReturnCode\n    exclude_regex \u003d \u0027--black-regex\u0027\n\n    def test_tempest_run_exclude_regex_failing_with_stestr_repository(self):\n        subprocess.call([\u0027stestr\u0027, \u0027init\u0027])\n        self.assertRunExit([\u0027tempest\u0027, \u0027run\u0027, self.exclude_regex , \u0027failing\u0027], 0)\n\n\nTestRunReturnCode(TestOldArgRunReturnCode)\n    exclude_regex  \u003d \u0027--exclude-regex\u0027","commit_id":"009827766b10d4ac9801b2c1e4043dead4e30714"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.assertRunExit([\u0027tempest\u0027, \u0027run\u0027, \u0027--regex\u0027, \u0027failing\u0027], 1)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_tempest_run_blackregex_failing(self):"},{"line_number":119,"context_line":"        self.assertRunExit([\u0027tempest\u0027, \u0027run\u0027, \u0027--black-regex\u0027, \u0027failing\u0027], 0)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_tempest_run_blackregex_failing_with_stestr_repository(self):"},{"line_number":122,"context_line":"        subprocess.call([\u0027stestr\u0027, \u0027init\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"85f6cc18_d113c86e","side":"PARENT","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":77},"in_reply_to":"bf849d1c_08875646","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"009827766b10d4ac9801b2c1e4043dead4e30714"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":238,"context_line":"        self.addCleanup(exclude_list.close)"},{"line_number":239,"context_line":"        exclude_list.write(\u0027passing\u0027.encode(\u0027utf-8\u0027))"},{"line_number":240,"context_line":"        self.assertRunExit([\u0027tempest\u0027, \u0027run\u0027, \u0027--exclude-list\u003d%s\u0027 % path,"},{"line_number":241,"context_line":"                            \u0027--regex\u0027, \u0027fail\u0027], 1)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"class TestConfigPathCheck(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"344fceb3_b0512830","line":241,"range":{"start_line":241,"start_character":49,"end_line":241,"end_character":50},"updated":"2021-01-15 00:18:05.000000000","message":"also please add few test when both arg are present and new one is passed to stestr","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.addCleanup(exclude_list.close)"},{"line_number":239,"context_line":"        exclude_list.write(\u0027passing\u0027.encode(\u0027utf-8\u0027))"},{"line_number":240,"context_line":"        self.assertRunExit([\u0027tempest\u0027, \u0027run\u0027, \u0027--exclude-list\u003d%s\u0027 % path,"},{"line_number":241,"context_line":"                            \u0027--regex\u0027, \u0027fail\u0027], 1)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"class TestConfigPathCheck(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"60124c78_141e60e7","line":241,"range":{"start_line":241,"start_character":49,"end_line":241,"end_character":50},"in_reply_to":"344fceb3_b0512830","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"}],"tools/generate-tempest-plugins-list.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":34,"context_line":"# (6 months or more)"},{"line_number":35,"context_line":"# TODO(masayukig): Some of these can be removed from EXCLUDE_LIST in the future"},{"line_number":36,"context_line":"# when the patches are merged."},{"line_number":37,"context_line":"EXCLUDE_LIST \u003d ["},{"line_number":38,"context_line":"    \u0027x/gce-api\u0027,  # It looks gce-api doesn\u0027t support python3 yet."},{"line_number":39,"context_line":"    \u0027x/glare\u0027,  # To avoid sanity-job failure"},{"line_number":40,"context_line":"    \u0027x/group-based-policy\u0027,  # It looks this doesn\u0027t support python3 yet."}],"source_content_type":"text/x-python","patch_set":3,"id":"c622711d_4666dfdd","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":7},"updated":"2021-01-15 00:18:05.000000000","message":"NON_ACTIVE_LIST","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# (6 months or more)"},{"line_number":35,"context_line":"# TODO(masayukig): Some of these can be removed from EXCLUDE_LIST in the future"},{"line_number":36,"context_line":"# when the patches are merged."},{"line_number":37,"context_line":"EXCLUDE_LIST \u003d ["},{"line_number":38,"context_line":"    \u0027x/gce-api\u0027,  # It looks gce-api doesn\u0027t support python3 yet."},{"line_number":39,"context_line":"    \u0027x/glare\u0027,  # To avoid sanity-job failure"},{"line_number":40,"context_line":"    \u0027x/group-based-policy\u0027,  # It looks this doesn\u0027t support python3 yet."}],"source_content_type":"text/x-python","patch_set":3,"id":"48d6b756_6dd8a685","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":7},"in_reply_to":"c622711d_4666dfdd","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"}],"tools/tempest-integrated-gate-compute-exclude-list.txt":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"80506aaf_f35bd054","updated":"2021-01-15 00:18:05.000000000","message":"we need to make sure noone using these file name in tempest run in their script or code","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e64160fa_d6621930","in_reply_to":"80506aaf_f35bd054","updated":"2021-01-15 13:49:44.000000000","message":"yay, tools/tempest-integrated-gate-storage-blacklist.txt is used in cinder-tempest-plugin and in devstack-plugin-open-cas:\nhttps://codesearch.opendev.org/?q\u003dtools%2Ftempest-integrated-gate-storage-blacklist.txt\u0026i\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nThe rest of the files are used only in tempest based on the codesearch.\nLet me create a symlink for *-storage-blacklist-txt to give the 2 plugins time for the change.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3a780116aad255909d08107fab4e71a86d53fb0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"886e312c_4a90c0ea","in_reply_to":"e64160fa_d6621930","updated":"2021-01-15 20:50:11.000000000","message":"perfect, thanks for checks.","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"}],"tools/tempest-plugin-sanity.sh":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e89b9ec8c6fb2b5c5fa1cc73335b5f9780eac14","unresolved":true,"context_lines":[{"line_number":44,"context_line":"# retrieve a list of projects having tempest plugins"},{"line_number":45,"context_line":"PROJECT_LIST\u003d\"$(python tools/generate-tempest-plugins-list.py)\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"EXCLUDE_LIST\u003d\"$(python tools/generate-tempest-plugins-list.py excludelist)\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Function to clone project using zuul-cloner or from git"},{"line_number":50,"context_line":"function clone_project {"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7d176e33_822fab2d","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":12},"updated":"2021-01-15 00:18:05.000000000","message":"ditto","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60f6d4e6f8ec93783fab1de5fddcf6ee5b96c1f0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# retrieve a list of projects having tempest plugins"},{"line_number":45,"context_line":"PROJECT_LIST\u003d\"$(python tools/generate-tempest-plugins-list.py)\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"EXCLUDE_LIST\u003d\"$(python tools/generate-tempest-plugins-list.py excludelist)\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Function to clone project using zuul-cloner or from git"},{"line_number":50,"context_line":"function clone_project {"}],"source_content_type":"text/x-sh","patch_set":3,"id":"659cb71f_6df4348c","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":12},"in_reply_to":"7d176e33_822fab2d","updated":"2021-01-15 13:49:44.000000000","message":"Done","commit_id":"d30b0300a40b2455fc3340cc3441766db4946b99"}]}