)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"dd0aba934f8720bdf6066816eda722170e138875","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"These options map directly to the corresponding options in the stestr"},{"line_number":18,"context_line":"tool. Further, this is inline with similar changes done in stestr, and"},{"line_number":19,"context_line":"made available as part of version 3.1.0."},{"line_number":20,"context_line":"Issue Ref: https://github.com/mtreinish/stestr/issues/296"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I4b3773b4fe7e2aad12552e7e48958fd9f5a2c459"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfea1697_6c542f51","line":19,"updated":"2021-01-12 17:18:27.000000000","message":"Could you add a summary of how you are going to address removal.  I would suggest a tag TODO through out the code.","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":32330,"name":"Arun Nagarajan","email":"arun.nagarajan@ericsson.com","username":"arun-n2k20"},"change_message_id":"215fedb1648ca35945b50f0bba4228ba4847a964","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"These options map directly to the corresponding options in the stestr"},{"line_number":18,"context_line":"tool. Further, this is inline with similar changes done in stestr, and"},{"line_number":19,"context_line":"made available as part of version 3.1.0."},{"line_number":20,"context_line":"Issue Ref: https://github.com/mtreinish/stestr/issues/296"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I4b3773b4fe7e2aad12552e7e48958fd9f5a2c459"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da80a0c3_a230f16c","line":19,"in_reply_to":"dfea1697_6c542f51","updated":"2021-01-12 18:47:50.000000000","message":"I don\u0027t think adding TODO throughout the code for this will be a good idea. But yes, it would be helpful to outline how we would be approaching the removal of old options.","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"}],"tempest/api/compute/security_groups/test_security_groups_negative.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"dd0aba934f8720bdf6066816eda722170e138875","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Test creating security group with invalid group name should fail"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        Negative test: Security group should not be created with group name"},{"line_number":55,"context_line":"        as an empty string, or group name with blank spaces, or group name"},{"line_number":56,"context_line":"        with chars more than 255."},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        s_description \u003d data_utils.rand_name(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d82f47ec_6d0b5059","line":55,"range":{"start_line":55,"start_character":47,"end_line":55,"end_character":59},"updated":"2021-01-12 17:18:27.000000000","message":"I am on the fence for this.  Whitespace may be a better phrase.  I am wondering what other think.","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":32330,"name":"Arun Nagarajan","email":"arun.nagarajan@ericsson.com","username":"arun-n2k20"},"change_message_id":"215fedb1648ca35945b50f0bba4228ba4847a964","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Test creating security group with invalid group name should fail"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        Negative test: Security group should not be created with group name"},{"line_number":55,"context_line":"        as an empty string, or group name with blank spaces, or group name"},{"line_number":56,"context_line":"        with chars more than 255."},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        s_description \u003d data_utils.rand_name(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b5bf027_6ba9b776","line":55,"range":{"start_line":55,"start_character":47,"end_line":55,"end_character":59},"in_reply_to":"d82f47ec_6d0b5059","updated":"2021-01-12 18:47:50.000000000","message":"Yes, I agree - this is not really contributing to the problem and can be left as it is.","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"}],"tempest/cmd/run.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"dd0aba934f8720bdf6066816eda722170e138875","unresolved":true,"context_lines":[{"line_number":24,"context_line":"* ``--smoke/-s``: Run all the tests tagged as smoke"},{"line_number":25,"context_line":"* ``--black-regex``: It allows to do simple test exclusion via passing a"},{"line_number":26,"context_line":"  rejection/black regexp (please consider using the equivalent --exclude-regex"},{"line_number":27,"context_line":"  option instead, since this option will soon be deprecated!)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"There are also the ``--blacklist-file`` and ``--whitelist-file`` options that"},{"line_number":30,"context_line":"let you pass a filepath to tempest run with the file format being a line"}],"source_content_type":"text/x-python","patch_set":1,"id":"a08ed89d_e615ed9e","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":59},"updated":"2021-01-12 17:18:27.000000000","message":"deprecated in stestr and we need to deprecated in tempest in order to use those future versions.","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":32330,"name":"Arun Nagarajan","email":"arun.nagarajan@ericsson.com","username":"arun-n2k20"},"change_message_id":"215fedb1648ca35945b50f0bba4228ba4847a964","unresolved":false,"context_lines":[{"line_number":24,"context_line":"* ``--smoke/-s``: Run all the tests tagged as smoke"},{"line_number":25,"context_line":"* ``--black-regex``: It allows to do simple test exclusion via passing a"},{"line_number":26,"context_line":"  rejection/black regexp (please consider using the equivalent --exclude-regex"},{"line_number":27,"context_line":"  option instead, since this option will soon be deprecated!)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"There are also the ``--blacklist-file`` and ``--whitelist-file`` options that"},{"line_number":30,"context_line":"let you pass a filepath to tempest run with the file format being a line"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2dd5b75_4e7dd228","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":59},"in_reply_to":"a08ed89d_e615ed9e","updated":"2021-01-12 18:47:50.000000000","message":"Ack","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"dd0aba934f8720bdf6066816eda722170e138875","unresolved":true,"context_lines":[{"line_number":30,"context_line":"let you pass a filepath to tempest run with the file format being a line"},{"line_number":31,"context_line":"separated regex, with \u0027#\u0027 used to signify the start of a comment on a line."},{"line_number":32,"context_line":"Please consider using the equivalent ``--exclude-list`` and ``--include-list``"},{"line_number":33,"context_line":"options instead, since the above options will soon be deprecated!"},{"line_number":34,"context_line":"For example::"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # Regex file"}],"source_content_type":"text/x-python","patch_set":1,"id":"e0165cc5_e6aee1f2","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":64},"updated":"2021-01-12 17:18:27.000000000","message":"ditto","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":32330,"name":"Arun Nagarajan","email":"arun.nagarajan@ericsson.com","username":"arun-n2k20"},"change_message_id":"215fedb1648ca35945b50f0bba4228ba4847a964","unresolved":false,"context_lines":[{"line_number":30,"context_line":"let you pass a filepath to tempest run with the file format being a line"},{"line_number":31,"context_line":"separated regex, with \u0027#\u0027 used to signify the start of a comment on a line."},{"line_number":32,"context_line":"Please consider using the equivalent ``--exclude-list`` and ``--include-list``"},{"line_number":33,"context_line":"options instead, since the above options will soon be deprecated!"},{"line_number":34,"context_line":"For example::"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # Regex file"}],"source_content_type":"text/x-python","patch_set":1,"id":"ac9efe46_56397eba","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":64},"in_reply_to":"e0165cc5_e6aee1f2","updated":"2021-01-12 18:47:50.000000000","message":"Ack","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"dd0aba934f8720bdf6066816eda722170e138875","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        return_code \u003d 0"},{"line_number":208,"context_line":"        if parsed_args.list_tests:"},{"line_number":209,"context_line":"            return_code \u003d commands.list_command("},{"line_number":210,"context_line":"                filters\u003dregex, whitelist_file\u003dparsed_args.whitelist_file,"},{"line_number":211,"context_line":"                include_list\u003dparsed_args.include_list,"},{"line_number":212,"context_line":"                blacklist_file\u003dparsed_args.blacklist_file,"},{"line_number":213,"context_line":"                exclude_list\u003dparsed_args.exclude_list,"}],"source_content_type":"text/x-python","patch_set":1,"id":"03d2ad4c_e87b6f48","line":210,"updated":"2021-01-12 17:18:27.000000000","message":"should we have a TODO here about cleaning up the old code?","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":32330,"name":"Arun Nagarajan","email":"arun.nagarajan@ericsson.com","username":"arun-n2k20"},"change_message_id":"215fedb1648ca35945b50f0bba4228ba4847a964","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        return_code \u003d 0"},{"line_number":208,"context_line":"        if parsed_args.list_tests:"},{"line_number":209,"context_line":"            return_code \u003d commands.list_command("},{"line_number":210,"context_line":"                filters\u003dregex, whitelist_file\u003dparsed_args.whitelist_file,"},{"line_number":211,"context_line":"                include_list\u003dparsed_args.include_list,"},{"line_number":212,"context_line":"                blacklist_file\u003dparsed_args.blacklist_file,"},{"line_number":213,"context_line":"                exclude_list\u003dparsed_args.exclude_list,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca7aa03f_269c88c7","line":210,"in_reply_to":"03d2ad4c_e87b6f48","updated":"2021-01-12 18:47:50.000000000","message":"IMO more than the usefulness in future code cleanup, it would add clutter to the code. The deprecation note with the help strings provide enough context to aid in cleanup.","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"dd0aba934f8720bdf6066816eda722170e138875","unresolved":true,"context_lines":[{"line_number":280,"context_line":"                           help\u003d\u0027A normal stestr selection regex used to \u0027"},{"line_number":281,"context_line":"                                \u0027specify a subset of tests to run\u0027)"},{"line_number":282,"context_line":"        parser.add_argument(\u0027--black-regex\u0027, dest\u003d\u0027black_regex\u0027,"},{"line_number":283,"context_line":"                            help\u003d\u0027DEPRECATED: This option will soon be \u0027"},{"line_number":284,"context_line":"                                 \u0027replaced by --exclude-regex which is \u0027"},{"line_number":285,"context_line":"                                 \u0027functionally equivalent.\u0027)"},{"line_number":286,"context_line":"        parser.add_argument(\u0027--exclude-regex\u0027, dest\u003d\u0027exclude_regex\u0027,"},{"line_number":287,"context_line":"                            help\u003d\u0027A regex to exclude tests that match it\u0027)"},{"line_number":288,"context_line":"        parser.add_argument(\u0027--whitelist-file\u0027, \u0027--whitelist_file\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"87220b7c_02adfa7c","line":285,"range":{"start_line":283,"start_character":35,"end_line":285,"end_character":58},"updated":"2021-01-12 17:18:27.000000000","message":"maybe something like \nThis option is replaced by --exclude-regex which is functionally equivalent and this argument will be removed in the near future.","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"},{"author":{"_account_id":32330,"name":"Arun Nagarajan","email":"arun.nagarajan@ericsson.com","username":"arun-n2k20"},"change_message_id":"215fedb1648ca35945b50f0bba4228ba4847a964","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                           help\u003d\u0027A normal stestr selection regex used to \u0027"},{"line_number":281,"context_line":"                                \u0027specify a subset of tests to run\u0027)"},{"line_number":282,"context_line":"        parser.add_argument(\u0027--black-regex\u0027, dest\u003d\u0027black_regex\u0027,"},{"line_number":283,"context_line":"                            help\u003d\u0027DEPRECATED: This option will soon be \u0027"},{"line_number":284,"context_line":"                                 \u0027replaced by --exclude-regex which is \u0027"},{"line_number":285,"context_line":"                                 \u0027functionally equivalent.\u0027)"},{"line_number":286,"context_line":"        parser.add_argument(\u0027--exclude-regex\u0027, dest\u003d\u0027exclude_regex\u0027,"},{"line_number":287,"context_line":"                            help\u003d\u0027A regex to exclude tests that match it\u0027)"},{"line_number":288,"context_line":"        parser.add_argument(\u0027--whitelist-file\u0027, \u0027--whitelist_file\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ae02b33_1c0e3b02","line":285,"range":{"start_line":283,"start_character":35,"end_line":285,"end_character":58},"in_reply_to":"87220b7c_02adfa7c","updated":"2021-01-12 18:47:50.000000000","message":"Ack","commit_id":"8b62d01e74f38831eebad12dc8794e74a552ce0d"}]}