)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2fc5ff6b6e071e5f50adf091fb75864656e0d699","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is added to test get_images_schema and get_image_schema"},{"line_number":10,"context_line":"image metadata APIs."},{"line_number":11,"context_line":"In addition to this patch ammends the client function written for"},{"line_number":12,"context_line":"these APIs."},{"line_number":13,"context_line":"A single method is written to merge all the schema client methods,"},{"line_number":14,"context_line":"thus giving better way to code utilization."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAVX%2F%2Fv2Q%3D","line":11,"updated":"2014-02-28 15:40:41.000000000","message":"s/to this patch ammends/this patch changes/","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"}],"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5948d4453ef155264663dbcfb5a0634321ae6d51","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    def test_get_images_schema(self):"},{"line_number":218,"context_line":"        # Test to get images schema"},{"line_number":219,"context_line":"        resp, body \u003d self.client.get_images_schema()"},{"line_number":220,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027200\u0027)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":223,"context_line":"    def test_get_image_schema(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fytg%3D","line":220,"updated":"2014-02-28 08:37:19.000000000","message":"Check some response body parameter like \"direct_url\", \"id\" etc for non blank.","commit_id":"eaf6f1d0f9874b65a09eb7bd2209d6acba3c3194"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"49fa44f3f1a824d27195ea3fb55a6cd03620accb","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    def test_get_images_schema(self):"},{"line_number":218,"context_line":"        # Test to get images schema"},{"line_number":219,"context_line":"        resp, body \u003d self.client.get_images_schema()"},{"line_number":220,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027200\u0027)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":223,"context_line":"    def test_get_image_schema(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FyMs%3D","line":220,"in_reply_to":"AAAAVX%2F%2Fytg%3D","updated":"2014-02-28 10:03:34.000000000","message":"Done","commit_id":"eaf6f1d0f9874b65a09eb7bd2209d6acba3c3194"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5948d4453ef155264663dbcfb5a0634321ae6d51","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    def test_get_image_schema(self):"},{"line_number":224,"context_line":"        # Test to get image schema"},{"line_number":225,"context_line":"        resp, body \u003d self.client.get_image_schema()"},{"line_number":226,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027200\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fytc%3D","line":226,"updated":"2014-02-28 08:37:19.000000000","message":"same as above","commit_id":"eaf6f1d0f9874b65a09eb7bd2209d6acba3c3194"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"49fa44f3f1a824d27195ea3fb55a6cd03620accb","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    def test_get_image_schema(self):"},{"line_number":224,"context_line":"        # Test to get image schema"},{"line_number":225,"context_line":"        resp, body \u003d self.client.get_image_schema()"},{"line_number":226,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027200\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FyMo%3D","line":226,"in_reply_to":"AAAAVX%2F%2Fytc%3D","updated":"2014-02-28 10:03:34.000000000","message":"Done","commit_id":"eaf6f1d0f9874b65a09eb7bd2209d6acba3c3194"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8ca74f7aca13b22362418f85dc9a35e142e49be5","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        schema \u003d \"image\""},{"line_number":220,"context_line":"        resp, body \u003d self.client.get_schema(schema)"},{"line_number":221,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":222,"context_line":"        self.assertEqual(body[\u0027name\u0027], \"image\")"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":225,"context_line":"    def test_get_images_schema(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2Fpw4%3D","line":222,"updated":"2014-03-01 22:41:38.000000000","message":"here should be \"expected, actual\" because of https://bugs.launchpad.net/ceilometer/+bug/1277104","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6fa434b4fae9a2f7f5f8dd5a36947b4ef517d555","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        schema \u003d \"image\""},{"line_number":220,"context_line":"        resp, body \u003d self.client.get_schema(schema)"},{"line_number":221,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":222,"context_line":"        self.assertEqual(body[\u0027name\u0027], \"image\")"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":225,"context_line":"    def test_get_images_schema(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2F%2BxE%3D","line":222,"in_reply_to":"AAAAVX%2F%2Fpw4%3D","updated":"2014-03-03 01:07:21.000000000","message":"The above URL is wrong :)\n\nThe correct link is bug 1277104\n?","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9f828033aadc3b8b687f6a18dc896ce5b6051456","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        schema \u003d \"image\""},{"line_number":220,"context_line":"        resp, body \u003d self.client.get_schema(schema)"},{"line_number":221,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":222,"context_line":"        self.assertEqual(body[\u0027name\u0027], \"image\")"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":225,"context_line":"    def test_get_images_schema(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2F%2Be0%3D","line":222,"in_reply_to":"AAAAVn%2F%2F%2BxE%3D","updated":"2014-03-03 02:18:54.000000000","message":"Thanks, right.","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8ca74f7aca13b22362418f85dc9a35e142e49be5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        schema \u003d \"images\""},{"line_number":228,"context_line":"        resp, body \u003d self.client.get_schema(schema)"},{"line_number":229,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":230,"context_line":"        self.assertEqual(body[\u0027name\u0027], \"images\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2Fpw0%3D","line":230,"updated":"2014-03-01 22:41:38.000000000","message":"ditto","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"}],"tempest/services/image/v2/json/image_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ca520a34bec273d8ffc9e7cd946552e2379287f9","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _validate_schema(self, body, type\u003d\u0027image\u0027):"},{"line_number":43,"context_line":"        if type \u003d\u003d \u0027image\u0027:"},{"line_number":44,"context_line":"            resp, schema \u003d self.get_schema(type)"},{"line_number":45,"context_line":"        elif type \u003d\u003d \u0027images\u0027:"},{"line_number":46,"context_line":"            resp, schema \u003d self.get_schema(type)"},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2Frqg%3D","line":44,"updated":"2014-03-01 04:33:45.000000000","message":"no need to if condition now. remove those.","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3d2372f8d6844f8363ed4245d43e29a471552ff5","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _validate_schema(self, body, type\u003d\u0027image\u0027):"},{"line_number":43,"context_line":"        if type \u003d\u003d \u0027image\u0027:"},{"line_number":44,"context_line":"            resp, schema \u003d self.get_schema(type)"},{"line_number":45,"context_line":"        elif type \u003d\u003d \u0027images\u0027:"},{"line_number":46,"context_line":"            resp, schema \u003d self.get_schema(type)"},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2FrCQ%3D","line":44,"in_reply_to":"AAAAVX%2F%2Frqg%3D","updated":"2014-03-01 09:06:25.000000000","message":"I had too noticed it will amend in next patch","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ea83920866e8582690c869abf397cccaf09b4aeb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        elif type \u003d\u003d \u0027images\u0027:"},{"line_number":46,"context_line":"            resp, schema \u003d self.get_schema(type)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            raise ValueError(\"%s is not a valid schema type\" % type)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        jsonschema.validate(body, schema)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2FrqM%3D","line":48,"updated":"2014-03-01 04:36:01.000000000","message":"instead, have check here if input type is ther than \"image\" or \"images.\"","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3d2372f8d6844f8363ed4245d43e29a471552ff5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        elif type \u003d\u003d \u0027images\u0027:"},{"line_number":46,"context_line":"            resp, schema \u003d self.get_schema(type)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            raise ValueError(\"%s is not a valid schema type\" % type)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        jsonschema.validate(body, schema)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2FrCI%3D","line":48,"in_reply_to":"AAAAVX%2F%2FrqM%3D","updated":"2014-03-01 09:06:25.000000000","message":"ditto","commit_id":"ea0f2c2fbb8aa342a35019543dcd58e32400bda5"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"1e205b3a1462671c407ff147cf21c8141a80c6f9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                      insecure\u003ddscv)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _validate_schema(self, body, type\u003d\u0027image\u0027):"},{"line_number":43,"context_line":"        if type in [\u0027image\u0027, \u0027images\u0027]:"},{"line_number":44,"context_line":"            resp, schema \u003d self.get_schema(type)"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            raise ValueError(\"%s is not a valid schema type\" % type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FvuM%3D","line":43,"updated":"2014-03-04 10:39:38.000000000","message":"Off topic: This should be validated in the calling method,","commit_id":"a1ce3546d459eb25c4f48bf61e2c8f7b2315dd01"}]}