)]}'
{"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"08ad72eaa50566e225638db1951d1c0600e57bc6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":48,"context_line":"        self.addCleanup(self.backups_adm_client.delete_backup,"},{"line_number":49,"context_line":"                        backup[\u0027id\u0027])"},{"line_number":50,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":51,"context_line":"        self.volumes_adm_client.wait_for_volume_status(self.volume[\u0027id\u0027],"},{"line_number":52,"context_line":"                                                       \u0027available\u0027)"},{"line_number":53,"context_line":"        self.backups_adm_client.wait_for_backup_status(backup[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2Fvcc%3D","line":50,"updated":"2014-03-04 11:08:11.000000000","message":"what is the reason for this?","commit_id":"aa22672dbc34100e125a2e95958c9bc91ff14ca7"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"6147a5700babf6c8c8bbf5039acaddeccde77436","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":48,"context_line":"        self.addCleanup(self.backups_adm_client.delete_backup,"},{"line_number":49,"context_line":"                        backup[\u0027id\u0027])"},{"line_number":50,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":51,"context_line":"        self.volumes_adm_client.wait_for_volume_status(self.volume[\u0027id\u0027],"},{"line_number":52,"context_line":"                                                       \u0027available\u0027)"},{"line_number":53,"context_line":"        self.backups_adm_client.wait_for_backup_status(backup[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FvU8%3D","line":50,"in_reply_to":"AAAAVn%2F%2Fvcc%3D","updated":"2014-03-04 11:24:11.000000000","message":"Done","commit_id":"aa22672dbc34100e125a2e95958c9bc91ff14ca7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"08ad72eaa50566e225638db1951d1c0600e57bc6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # Get a given backup"},{"line_number":57,"context_line":"        resp, backup \u003d self.backups_adm_client.get_backup(backup[\u0027id\u0027])"},{"line_number":58,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":59,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Get all backups with detail"},{"line_number":62,"context_line":"        resp, backup \u003d self.backups_adm_client.get_backup_detailed()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FvcA%3D","line":59,"updated":"2014-03-04 11:08:11.000000000","message":"see line 50","commit_id":"aa22672dbc34100e125a2e95958c9bc91ff14ca7"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"6147a5700babf6c8c8bbf5039acaddeccde77436","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # Get a given backup"},{"line_number":57,"context_line":"        resp, backup \u003d self.backups_adm_client.get_backup(backup[\u0027id\u0027])"},{"line_number":58,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":59,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Get all backups with detail"},{"line_number":62,"context_line":"        resp, backup \u003d self.backups_adm_client.get_backup_detailed()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FvU4%3D","line":59,"in_reply_to":"AAAAVn%2F%2FvcA%3D","updated":"2014-03-04 11:24:11.000000000","message":"Done","commit_id":"aa22672dbc34100e125a2e95958c9bc91ff14ca7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8cf15bfed3b28b781808fcd99965999a79e62337","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":41,"context_line":"    def test_volume_backup_create_get_detailed_get_restore_delete(self):"},{"line_number":42,"context_line":"        # Create backup"},{"line_number":43,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":44,"context_line":"        create_backup \u003d self.backups_adm_client.create_backup"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2Fkx4%3D","line":41,"updated":"2014-03-05 09:30:14.000000000","message":"detailed_list","commit_id":"40a3fa14a7728fb2345c16608c3ada2e6346cf68"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"1cfa3551f6ff1f113bc9de2f02791f51955a3805","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":41,"context_line":"    def test_volume_backup_create_get_detailed_get_restore_delete(self):"},{"line_number":42,"context_line":"        # Create backup"},{"line_number":43,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":44,"context_line":"        create_backup \u003d self.backups_adm_client.create_backup"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FjdE%3D","line":41,"in_reply_to":"AAAAVn%2F%2Fkx4%3D","updated":"2014-03-05 12:58:55.000000000","message":"Done","commit_id":"40a3fa14a7728fb2345c16608c3ada2e6346cf68"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"30e7891d6b8fd6ca2a01a0dd622498ef74554b05","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(backup[\u0027name\u0027], backup_name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Get all backups with detail"},{"line_number":62,"context_line":"        resp, backups \u003d self.backups_adm_client.list_backup_detailed()"},{"line_number":63,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Restore backup"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FkvQ%3D","line":62,"updated":"2014-03-05 09:35:32.000000000","message":"maybe add some assertion here to ensure the backup is actually in the list","commit_id":"40a3fa14a7728fb2345c16608c3ada2e6346cf68"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"1cfa3551f6ff1f113bc9de2f02791f51955a3805","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(backup[\u0027name\u0027], backup_name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Get all backups with detail"},{"line_number":62,"context_line":"        resp, backups \u003d self.backups_adm_client.list_backup_detailed()"},{"line_number":63,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Restore backup"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FjcM%3D","line":62,"in_reply_to":"AAAAVn%2F%2FkvQ%3D","updated":"2014-03-05 12:58:55.000000000","message":"returned body in https://review.openstack.org/#/c/77134/8/tempest/services/volume/json/backups_client.py #L77 shows that returned body is a list. So it is not needed to check it again here.","commit_id":"40a3fa14a7728fb2345c16608c3ada2e6346cf68"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"98162e7d6e98a9ea9a395c369fb6adfaa8a07865","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        # Get all backups with detail"},{"line_number":62,"context_line":"        resp, backups \u003d self.backups_adm_client.list_backups_with_detail()"},{"line_number":63,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":64,"context_line":"        self.assertIn(backup[\u0027name\u0027], [m[\u0027name\u0027] for m in backups])"},{"line_number":65,"context_line":"        self.assertIn(backup[\u0027volume_id\u0027], [m[\u0027volume_id\u0027] for m in backups])"},{"line_number":66,"context_line":"        self.assertIn(backup[\u0027status\u0027], [m[\u0027status\u0027] for m in backups])"},{"line_number":67,"context_line":"        self.assertIn(backup[\u0027id\u0027], [m[\u0027id\u0027] for m in backups])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2FiEc%3D","line":64,"updated":"2014-03-05 15:20:02.000000000","message":"lines from 64 to 67 can cause false positives, we\u0027d need to check the tuple with something like:\n\nassertIn((backup[name], backup[id]), [(m[name), m[id]) for m in backups])","commit_id":"ad2eb28c62709b89876671827544bc6831291420"},{"author":{"_account_id":8171,"name":"Mh Raies","email":"mh.raies@nechclst.in","username":"mh.raies"},"change_message_id":"82ea36048e70ce15ce9132534828f5daaea5cdb1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        # Get all backups with detail"},{"line_number":62,"context_line":"        resp, backups \u003d self.backups_adm_client.list_backups_with_detail()"},{"line_number":63,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":64,"context_line":"        self.assertIn(backup[\u0027name\u0027], [m[\u0027name\u0027] for m in backups])"},{"line_number":65,"context_line":"        self.assertIn(backup[\u0027volume_id\u0027], [m[\u0027volume_id\u0027] for m in backups])"},{"line_number":66,"context_line":"        self.assertIn(backup[\u0027status\u0027], [m[\u0027status\u0027] for m in backups])"},{"line_number":67,"context_line":"        self.assertIn(backup[\u0027id\u0027], [m[\u0027id\u0027] for m in backups])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2FhgQ%3D","line":64,"in_reply_to":"AAAAVn%2F%2FiEc%3D","updated":"2014-03-05 16:07:09.000000000","message":"Right.\nWill change in next patch.","commit_id":"ad2eb28c62709b89876671827544bc6831291420"}],"tempest/services/volume/json/backups_client.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"08ad72eaa50566e225638db1951d1c0600e57bc6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        body \u003d json.loads(body)"},{"line_number":70,"context_line":"        return resp, body[\u0027backup\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_backup_detailed(self):"},{"line_number":73,"context_line":"        \"\"\"Returns detailed information for backups.\"\"\""},{"line_number":74,"context_line":"        url \u003d \"backups/detail\""},{"line_number":75,"context_line":"        resp, body \u003d self.get(url)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2Fvbs%3D","line":72,"updated":"2014-03-04 11:08:11.000000000","message":"I\u0027d rename this into \"list_backups_details\" to keep naming vaguely consistent with API reference","commit_id":"aa22672dbc34100e125a2e95958c9bc91ff14ca7"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"6147a5700babf6c8c8bbf5039acaddeccde77436","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        body \u003d json.loads(body)"},{"line_number":70,"context_line":"        return resp, body[\u0027backup\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_backup_detailed(self):"},{"line_number":73,"context_line":"        \"\"\"Returns detailed information for backups.\"\"\""},{"line_number":74,"context_line":"        url \u003d \"backups/detail\""},{"line_number":75,"context_line":"        resp, body \u003d self.get(url)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FvUs%3D","line":72,"in_reply_to":"AAAAVn%2F%2Fvbs%3D","updated":"2014-03-04 11:24:11.000000000","message":"Done","commit_id":"aa22672dbc34100e125a2e95958c9bc91ff14ca7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"08ad72eaa50566e225638db1951d1c0600e57bc6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return resp, body[\u0027backup\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_backup_detailed(self):"},{"line_number":73,"context_line":"        \"\"\"Returns detailed information for backups.\"\"\""},{"line_number":74,"context_line":"        url \u003d \"backups/detail\""},{"line_number":75,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":76,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2Fvbc%3D","line":73,"updated":"2014-03-04 11:08:11.000000000","message":"please use \"informations for all the tenant\u0027s backups\" as initially I thought this was missing the backup_id","commit_id":"aa22672dbc34100e125a2e95958c9bc91ff14ca7"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"6147a5700babf6c8c8bbf5039acaddeccde77436","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return resp, body[\u0027backup\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_backup_detailed(self):"},{"line_number":73,"context_line":"        \"\"\"Returns detailed information for backups.\"\"\""},{"line_number":74,"context_line":"        url \u003d \"backups/detail\""},{"line_number":75,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":76,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FvUk%3D","line":73,"in_reply_to":"AAAAVn%2F%2Fvbc%3D","updated":"2014-03-04 11:24:11.000000000","message":"Done","commit_id":"aa22672dbc34100e125a2e95958c9bc91ff14ca7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8cf15bfed3b28b781808fcd99965999a79e62337","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        body \u003d json.loads(body)"},{"line_number":70,"context_line":"        return resp, body[\u0027backup\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def list_backup_detailed(self):"},{"line_number":73,"context_line":"        \"\"\"Information for all the tenant\u0027s backups.\"\"\""},{"line_number":74,"context_line":"        url \u003d \"backups/detail\""},{"line_number":75,"context_line":"        resp, body \u003d self.get(url)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FkyU%3D","line":72,"updated":"2014-03-05 09:30:14.000000000","message":"it\u0027s a minor thing but for consistency, volume and snapshot clients call this: list_volumes_with_detail and list_snapshot_with_detail , could you please rename it into list_backups_with_detail ?","commit_id":"40a3fa14a7728fb2345c16608c3ada2e6346cf68"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"1cfa3551f6ff1f113bc9de2f02791f51955a3805","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        body \u003d json.loads(body)"},{"line_number":70,"context_line":"        return resp, body[\u0027backup\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def list_backup_detailed(self):"},{"line_number":73,"context_line":"        \"\"\"Information for all the tenant\u0027s backups.\"\"\""},{"line_number":74,"context_line":"        url \u003d \"backups/detail\""},{"line_number":75,"context_line":"        resp, body \u003d self.get(url)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FjdI%3D","line":72,"in_reply_to":"AAAAVn%2F%2FkyU%3D","updated":"2014-03-05 12:58:55.000000000","message":"Done","commit_id":"40a3fa14a7728fb2345c16608c3ada2e6346cf68"}]}