)]}'
{"tempest/lib/common/dynamic_creds.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"15887acd6b170c1e8de3c4cb8a77af8ef934e058","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                    if credential_type in [[\u0027alt_member\u0027], [\u0027alt_reader\u0027]]:"},{"line_number":388,"context_line":"                        cred_type \u003d credential_type[0][4:]"},{"line_number":389,"context_line":"                    credentials \u003d self._create_creds("},{"line_number":390,"context_line":"                        roles\u003d[cred_type], scope\u003dscope)"},{"line_number":391,"context_line":"            elif credential_type in [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]:"},{"line_number":392,"context_line":"                is_admin \u003d (credential_type \u003d\u003d \u0027admin\u0027)"},{"line_number":393,"context_line":"                credentials \u003d self._create_creds(admin\u003dis_admin)"}],"source_content_type":"text/x-python","patch_set":8,"id":"42a943dc_986687a7","line":390,"range":{"start_line":390,"start_character":30,"end_line":390,"end_character":41},"updated":"2021-03-04 16:36:00.000000000","message":"I think this is what\u0027s breaking usage in things like glance-tempest-plugin:\n\n\nhttps://review.opendev.org/c/openstack/glance-tempest-plugin/+/775742/13\n\nWe\u0027re changing what roles should be from a string to a list and I\u0027m not sure _create_creds knows how to deal with that?","commit_id":"420586c8b4aeac438ed80cdfed14c43468c0d70a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5ebd89d36404f510b52bec67fdcbc284ea9bc9a","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                    if credential_type in [[\u0027alt_member\u0027], [\u0027alt_reader\u0027]]:"},{"line_number":388,"context_line":"                        cred_type \u003d credential_type[0][4:]"},{"line_number":389,"context_line":"                    credentials \u003d self._create_creds("},{"line_number":390,"context_line":"                        roles\u003d[cred_type], scope\u003dscope)"},{"line_number":391,"context_line":"            elif credential_type in [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]:"},{"line_number":392,"context_line":"                is_admin \u003d (credential_type \u003d\u003d \u0027admin\u0027)"},{"line_number":393,"context_line":"                credentials \u003d self._create_creds(admin\u003dis_admin)"}],"source_content_type":"text/x-python","patch_set":8,"id":"59e00457_e5629ceb","line":390,"range":{"start_line":390,"start_character":30,"end_line":390,"end_character":41},"in_reply_to":"42a943dc_986687a7","updated":"2021-03-05 12:51:56.000000000","message":"yeah, my bad here. it was already a list for scope one other than alt. thanks","commit_id":"420586c8b4aeac438ed80cdfed14c43468c0d70a"}],"tempest/lib/common/preprov_creds.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b7e861a0a4bac69a42fa4521c82c8079482cccc1","unresolved":true,"context_lines":[{"line_number":375,"context_line":"        return project_admin"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_project_alt_admin_creds(self):"},{"line_number":378,"context_line":"        # TODO(gmann): Implement alt admin hash."},{"line_number":379,"context_line":"        return"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def get_project_member_creds(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"62346626_b2bb9061","line":378,"range":{"start_line":378,"start_character":8,"end_line":378,"end_character":48},"updated":"2021-03-01 08:49:08.000000000","message":"is implementing this a requirement for this patch to work or the TODO is a refererence that this can be implemented in the future?","commit_id":"420586c8b4aeac438ed80cdfed14c43468c0d70a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6f4f1ee0731c013a0392ef25267cc6427421795e","unresolved":true,"context_lines":[{"line_number":375,"context_line":"        return project_admin"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_project_alt_admin_creds(self):"},{"line_number":378,"context_line":"        # TODO(gmann): Implement alt admin hash."},{"line_number":379,"context_line":"        return"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def get_project_member_creds(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"65ae4cba_0375794f","line":378,"range":{"start_line":378,"start_character":8,"end_line":378,"end_character":48},"in_reply_to":"62346626_b2bb9061","updated":"2021-03-01 14:37:00.000000000","message":"for future. this TODO is for pre provisioned credentials. and this patch implement it for dynamic creds which is default creds used for Tempest.","commit_id":"420586c8b4aeac438ed80cdfed14c43468c0d70a"}]}
