)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"26e2759fe35d401a3ad75559b8fa9c6f6531a038","unresolved":true,"context_lines":[{"line_number":665,"context_line":"        hosts \u003d []"},{"line_number":666,"context_line":"        for svc in svcs:"},{"line_number":667,"context_line":"            if svc[\u0027state\u0027] \u003d\u003d \u0027up\u0027 and svc[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027:"},{"line_number":668,"context_line":"                if CONF.compute.compute_volume_common_az and \\"},{"line_number":669,"context_line":"                        CONF.compute.compute_az:"},{"line_number":670,"context_line":"                    if svc[\u0027zone\u0027] \u003d\u003d CONF.compute.compute_az:"},{"line_number":671,"context_line":"                        hosts.append(svc[\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"6e90763a_af469fc4","line":668,"range":{"start_line":668,"start_character":57,"end_line":668,"end_character":60},"updated":"2021-02-09 09:57:29.000000000","message":"do both need to be set?\nshouldn\u0027t this be like:\n```\nif common_az:\n  zone \u003d common_az\nelif compute_az:\n  zone \u003d compute_az\n```\ncommon_az needs to be set with precedence, check the reason in my other comment.","commit_id":"dacd6bd1f9bff151bd458a03ad6a8ada98abaa84"}],"tempest/common/compute.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"26e2759fe35d401a3ad75559b8fa9c6f6531a038","unresolved":true,"context_lines":[{"line_number":195,"context_line":"    if CONF.compute.compute_volume_common_az or CONF.compute.compute_az:"},{"line_number":196,"context_line":"        if CONF.compute.compute_az:"},{"line_number":197,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":198,"context_line":"                              CONF.compute.compute_az)"},{"line_number":199,"context_line":"        else:"},{"line_number":200,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":201,"context_line":"                              CONF.compute.compute_volume_common_az)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7547b8cb_6f6f8b96","line":198,"range":{"start_line":198,"start_character":30,"end_line":198,"end_character":54},"updated":"2021-02-09 09:57:29.000000000","message":"compute_volume_common_az is used when the cloud has nova.conf: cinder.cross_az_attach set to false - which means volumes attached to an instance must be in the same availability zone in Cinder as the instance availability zone in Nova.\n\nIf compute_az will be used with precedence then it will be a problem if both of the options are set at the same time (and are not set to the same value) because volume will be created in common_az, see lines 166-169 and the server in compute_az - that will fail due to cross_az_attach is false.","commit_id":"dacd6bd1f9bff151bd458a03ad6a8ada98abaa84"}],"tempest/config.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"26e2759fe35d401a3ad75559b8fa9c6f6531a038","unresolved":true,"context_lines":[{"line_number":400,"context_line":"               default\u003dNone,"},{"line_number":401,"context_line":"               help\u003d\u0027Availability zone to be used for Nova. Set this \u0027"},{"line_number":402,"context_line":"                    \u0027parameter to an appropriate Nova availability zone name. \u0027"},{"line_number":403,"context_line":"                    \u0027It can be used with or without the \u0027"},{"line_number":404,"context_line":"                    \u0027compute_volume_common_az parameter. In the case when \u0027"},{"line_number":405,"context_line":"                    \u0027compute_volume_common_az is set, this parameter will \u0027"},{"line_number":406,"context_line":"                    \u0027overwrite AZ configuration for server and will be used \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"460f06b6_90cb1c6e","line":403,"range":{"start_line":403,"start_character":30,"end_line":403,"end_character":43},"updated":"2021-02-09 09:57:29.000000000","message":"it can be used just without","commit_id":"dacd6bd1f9bff151bd458a03ad6a8ada98abaa84"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"26e2759fe35d401a3ad75559b8fa9c6f6531a038","unresolved":true,"context_lines":[{"line_number":403,"context_line":"                    \u0027It can be used with or without the \u0027"},{"line_number":404,"context_line":"                    \u0027compute_volume_common_az parameter. In the case when \u0027"},{"line_number":405,"context_line":"                    \u0027compute_volume_common_az is set, this parameter will \u0027"},{"line_number":406,"context_line":"                    \u0027overwrite AZ configuration for server and will be used \u0027"},{"line_number":407,"context_line":"                    \u0027to boot an instance.\u0027),"},{"line_number":408,"context_line":"]"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fda930b1_cdb15ab9","line":406,"range":{"start_line":406,"start_character":21,"end_line":406,"end_character":47},"updated":"2021-02-09 09:57:29.000000000","message":"this cannot overwrite compute_volume_common_az","commit_id":"dacd6bd1f9bff151bd458a03ad6a8ada98abaa84"}]}