)]}'
{"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b61c538a10fe9d5bbd40139f61b218eebeb176a8","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        waiters.wait_for_image_imported_to_stores(self.client, image[\u0027id\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not self.versions_client.has_version(\u00272.12\u0027):"},{"line_number":96,"context_line":"            # API is not new enough to support image/tasks API"},{"line_number":97,"context_line":"            return"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Make sure we can access the task and that some of the key"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe7ab8ed_849fe368","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":62},"updated":"2021-03-06 20:47:48.000000000","message":"Let\u0027s log this Info so that we know task validation part is skipped.","commit_id":"de19ed7aca2933081b93db17ffe3ee7aae962865"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96518276beec171113c58a59680d7225a87edc96","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        waiters.wait_for_image_imported_to_stores(self.client, image[\u0027id\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not self.versions_client.has_version(\u00272.12\u0027):"},{"line_number":96,"context_line":"            # API is not new enough to support image/tasks API"},{"line_number":97,"context_line":"            return"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Make sure we can access the task and that some of the key"}],"source_content_type":"text/x-python","patch_set":2,"id":"62d6226e_2f8067a0","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":62},"in_reply_to":"fe7ab8ed_849fe368","updated":"2021-03-06 21:54:43.000000000","message":"Ack","commit_id":"de19ed7aca2933081b93db17ffe3ee7aae962865"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9eddbeaa451e85961e10c886cdf960d39ab10e3b","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        if not self.versions_client.has_version(\u00272.12\u0027):"},{"line_number":96,"context_line":"            # API is not new enough to support image/tasks API"},{"line_number":97,"context_line":"            LOG.info(\u0027Glance does not support v2.12, so I am unable to \u0027"},{"line_number":98,"context_line":"                     \u0027validate the image/tasks API.\u0027)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Make sure we can access the task and that some of the key"}],"source_content_type":"text/x-python","patch_set":3,"id":"7cb1f280_3ad8e6a7","line":98,"updated":"2021-03-07 16:04:36.000000000","message":"You said \"log this info\" so I used LOG.info, is that the right level?","commit_id":"a99c474ce12c497467888b613571e4535ee61ecc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd08179536cec4c728e417eb22d740796dff4e9f","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        if not self.versions_client.has_version(\u00272.12\u0027):"},{"line_number":96,"context_line":"            # API is not new enough to support image/tasks API"},{"line_number":97,"context_line":"            LOG.info(\u0027Glance does not support v2.12, so I am unable to \u0027"},{"line_number":98,"context_line":"                     \u0027validate the image/tasks API.\u0027)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Make sure we can access the task and that some of the key"}],"source_content_type":"text/x-python","patch_set":3,"id":"a1e1c055_c1d4faf6","line":98,"in_reply_to":"7cb1f280_3ad8e6a7","updated":"2021-03-07 23:33:54.000000000","message":"yes, that\u0027s right.","commit_id":"a99c474ce12c497467888b613571e4535ee61ecc"}],"tempest/lib/services/image/v2/images_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b61c538a10fe9d5bbd40139f61b218eebeb176a8","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":129,"context_line":"        body \u003d json.loads(body)"},{"line_number":130,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            self.show_image(id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"98ac3fd2_452269f7","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":0},"updated":"2021-03-06 20:47:48.000000000","message":"please add unit tests for this new method\n\nhttps://github.com/openstack/tempest/blob/master/tempest/tests/lib/services/image/v2/test_images_client.py","commit_id":"de19ed7aca2933081b93db17ffe3ee7aae962865"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96518276beec171113c58a59680d7225a87edc96","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":129,"context_line":"        body \u003d json.loads(body)"},{"line_number":130,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            self.show_image(id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c359899_cae166ee","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":0},"in_reply_to":"98ac3fd2_452269f7","updated":"2021-03-06 21:54:43.000000000","message":"Ack","commit_id":"de19ed7aca2933081b93db17ffe3ee7aae962865"}],"tempest/lib/services/image/v2/versions_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b61c538a10fe9d5bbd40139f61b218eebeb176a8","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        body \u003d json.loads(body)"},{"line_number":32,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def has_version(self, version):"},{"line_number":35,"context_line":"        \"\"\"Return True if a version is supported.\"\"\""},{"line_number":36,"context_line":"        version \u003d \u0027v%s\u0027 % version"},{"line_number":37,"context_line":"        supported \u003d [\u0027SUPPORTED\u0027, \u0027CURRENT\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7b7a1dda_83279ba3","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":35},"updated":"2021-03-06 20:47:48.000000000","message":"ditto, unit test needed in https://github.com/openstack/tempest/blob/master/tempest/tests/lib/services/image/v2/test_versions_client.py","commit_id":"de19ed7aca2933081b93db17ffe3ee7aae962865"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96518276beec171113c58a59680d7225a87edc96","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        body \u003d json.loads(body)"},{"line_number":32,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def has_version(self, version):"},{"line_number":35,"context_line":"        \"\"\"Return True if a version is supported.\"\"\""},{"line_number":36,"context_line":"        version \u003d \u0027v%s\u0027 % version"},{"line_number":37,"context_line":"        supported \u003d [\u0027SUPPORTED\u0027, \u0027CURRENT\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"10e6c30e_c07983d2","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":35},"in_reply_to":"7b7a1dda_83279ba3","updated":"2021-03-06 21:54:43.000000000","message":"Ack","commit_id":"de19ed7aca2933081b93db17ffe3ee7aae962865"}],"tempest/tests/lib/services/image/v2/test_images_client.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9eddbeaa451e85961e10c886cdf960d39ab10e3b","unresolved":true,"context_lines":[{"line_number":274,"context_line":"            self.client.show_image_tasks,"},{"line_number":275,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,"},{"line_number":276,"context_line":"            self.FAKE_SHOW_IMAGE_TASKS,"},{"line_number":277,"context_line":"            True,"},{"line_number":278,"context_line":"            image_id\u003d\"e485aab9-0907-4973-921c-bb6da8a8fcf8\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9439cd45_57e216bb","line":277,"range":{"start_line":277,"start_character":12,"end_line":277,"end_character":16},"updated":"2021-03-07 16:04:36.000000000","message":"Looks like tempest only supports py3 at this point, so I didn\u0027t write a bytes/str variant of this. Let me know if that\u0027s wrong.","commit_id":"a99c474ce12c497467888b613571e4535ee61ecc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd08179536cec4c728e417eb22d740796dff4e9f","unresolved":true,"context_lines":[{"line_number":274,"context_line":"            self.client.show_image_tasks,"},{"line_number":275,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,"},{"line_number":276,"context_line":"            self.FAKE_SHOW_IMAGE_TASKS,"},{"line_number":277,"context_line":"            True,"},{"line_number":278,"context_line":"            image_id\u003d\"e485aab9-0907-4973-921c-bb6da8a8fcf8\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd2e9331_afd8c16f","line":277,"range":{"start_line":277,"start_character":12,"end_line":277,"end_character":16},"in_reply_to":"9439cd45_57e216bb","updated":"2021-03-07 23:33:54.000000000","message":"+1","commit_id":"a99c474ce12c497467888b613571e4535ee61ecc"}],"tempest/tests/lib/services/image/v2/test_versions_client.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9eddbeaa451e85961e10c886cdf960d39ab10e3b","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                                        300, None)"},{"line_number":101,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":102,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.raw_request\u0027,"},{"line_number":103,"context_line":"            return_value\u003dmocked_r))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertTrue(self.client.has_version(\u00272.1\u0027))"},{"line_number":106,"context_line":"        self.assertFalse(self.client.has_version(\u00279.9\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"03c7b4dd_782f1a55","line":103,"updated":"2021-03-07 16:04:36.000000000","message":"Maybe I\u0027m wrong, but the check_service_client_function() seems to just be usable for basic CRUD type things, so I just used a fixture here. Hope that\u0027s right :)","commit_id":"a99c474ce12c497467888b613571e4535ee61ecc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd08179536cec4c728e417eb22d740796dff4e9f","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                                        300, None)"},{"line_number":101,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":102,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.raw_request\u0027,"},{"line_number":103,"context_line":"            return_value\u003dmocked_r))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertTrue(self.client.has_version(\u00272.1\u0027))"},{"line_number":106,"context_line":"        self.assertFalse(self.client.has_version(\u00279.9\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"609bf259_c953bfe7","line":103,"in_reply_to":"03c7b4dd_782f1a55","updated":"2021-03-07 23:33:54.000000000","message":"true for this type of assert on response, this way is fine.","commit_id":"a99c474ce12c497467888b613571e4535ee61ecc"}]}