)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"27d9a4e275c9cdff8ed9be67cbac6fd60e0ef420","unresolved":true,"context_lines":[{"line_number":134,"context_line":"            # add a volume type and"},{"line_number":135,"context_line":"            # if volume_type has already been added by child class then"},{"line_number":136,"context_line":"            # no need to override."},{"line_number":137,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d CONF.volume.volume_type"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":140,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"abc162c2_a254a56a","line":137,"range":{"start_line":137,"start_character":11,"end_line":137,"end_character":59},"updated":"2021-02-18 16:28:29.000000000","message":"should we check that the type exists and control the message?","commit_id":"46d540d33eea2656e8a9d47da5baeedaccf7e349"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e894306a217e85917c8b643ad871082c4d30f16b","unresolved":true,"context_lines":[{"line_number":134,"context_line":"            # add a volume type and"},{"line_number":135,"context_line":"            # if volume_type has already been added by child class then"},{"line_number":136,"context_line":"            # no need to override."},{"line_number":137,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d CONF.volume.volume_type"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":140,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0269f5b6_93921130","line":137,"range":{"start_line":137,"start_character":11,"end_line":137,"end_character":59},"in_reply_to":"35717b19_ceef1ce9","updated":"2021-02-23 19:01:31.000000000","message":"yeah, we can just return error what API return, no need to check existence explicitly","commit_id":"46d540d33eea2656e8a9d47da5baeedaccf7e349"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"00ae4f156d231d8ec5b6bec6fe6a8edf1efcb2db","unresolved":true,"context_lines":[{"line_number":134,"context_line":"            # add a volume type and"},{"line_number":135,"context_line":"            # if volume_type has already been added by child class then"},{"line_number":136,"context_line":"            # no need to override."},{"line_number":137,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d CONF.volume.volume_type"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":140,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"35717b19_ceef1ce9","line":137,"range":{"start_line":137,"start_character":11,"end_line":137,"end_character":59},"in_reply_to":"abc162c2_a254a56a","updated":"2021-02-18 19:00:56.000000000","message":"Ansuman ran a test and it raise invalid volume type. if the CONF volume type value is not found","commit_id":"46d540d33eea2656e8a9d47da5baeedaccf7e349"}],"tempest/config.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"27d9a4e275c9cdff8ed9be67cbac6fd60e0ef420","unresolved":true,"context_lines":[{"line_number":967,"context_line":"                     \u0027The backend name must be declared in cinder.conf\u0027),"},{"line_number":968,"context_line":"    cfg.StrOpt(\u0027volume_type\u0027,"},{"line_number":969,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":970,"context_line":"               help\u003d\u0027Volume type to be used while creating volume.\u0027),"},{"line_number":971,"context_line":"    cfg.StrOpt(\u0027storage_protocol\u0027,"},{"line_number":972,"context_line":"               default\u003d\u0027iSCSI\u0027,"},{"line_number":973,"context_line":"               help\u003d\u0027Backend protocol to target when creating volume types\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"38d6f637_86bfd4e9","line":970,"range":{"start_line":970,"start_character":21,"end_line":970,"end_character":65},"updated":"2021-02-18 16:28:29.000000000","message":"Should we state that this only works if you are using volume base BaseVolumeTest  _create_volume\u003e","commit_id":"46d540d33eea2656e8a9d47da5baeedaccf7e349"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"00ae4f156d231d8ec5b6bec6fe6a8edf1efcb2db","unresolved":true,"context_lines":[{"line_number":967,"context_line":"                     \u0027The backend name must be declared in cinder.conf\u0027),"},{"line_number":968,"context_line":"    cfg.StrOpt(\u0027volume_type\u0027,"},{"line_number":969,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":970,"context_line":"               help\u003d\u0027Volume type to be used while creating volume.\u0027),"},{"line_number":971,"context_line":"    cfg.StrOpt(\u0027storage_protocol\u0027,"},{"line_number":972,"context_line":"               default\u003d\u0027iSCSI\u0027,"},{"line_number":973,"context_line":"               help\u003d\u0027Backend protocol to target when creating volume types\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"b17b7aee_1b36e642","line":970,"range":{"start_line":970,"start_character":21,"end_line":970,"end_character":65},"in_reply_to":"38d6f637_86bfd4e9","updated":"2021-02-18 19:00:56.000000000","message":"After review other conf this is the standard way othe CONF are doing help.","commit_id":"46d540d33eea2656e8a9d47da5baeedaccf7e349"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e894306a217e85917c8b643ad871082c4d30f16b","unresolved":true,"context_lines":[{"line_number":967,"context_line":"                     \u0027The backend name must be declared in cinder.conf\u0027),"},{"line_number":968,"context_line":"    cfg.StrOpt(\u0027volume_type\u0027,"},{"line_number":969,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":970,"context_line":"               help\u003d\u0027Volume type to be used while creating volume.\u0027),"},{"line_number":971,"context_line":"    cfg.StrOpt(\u0027storage_protocol\u0027,"},{"line_number":972,"context_line":"               default\u003d\u0027iSCSI\u0027,"},{"line_number":973,"context_line":"               help\u003d\u0027Backend protocol to target when creating volume types\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"a022b3d8_a79f12a6","line":970,"range":{"start_line":970,"start_character":21,"end_line":970,"end_character":65},"in_reply_to":"b17b7aee_1b36e642","updated":"2021-02-23 19:01:31.000000000","message":"yeah, we can consume it in other test also which will be change from code side and from user side having this option is helpful.","commit_id":"46d540d33eea2656e8a9d47da5baeedaccf7e349"}]}