)]}'
{"tempest/api/identity/admin/v3/test_groups.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"869e750ca8103644ad192163ef9a27c47d285f8e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        # create a user"},{"line_number":83,"context_line":"        resp, user \u003d self.client.create_user("},{"line_number":84,"context_line":"            data_utils.rand_name(\u0027User-\u0027),"},{"line_number":85,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass-\u0027))"},{"line_number":86,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":87,"context_line":"        # create two groups, and add user into them"},{"line_number":88,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FREg%3D","line":85,"updated":"2014-03-07 06:30:59.000000000","message":"self.assertEqual(\u00272XX\u0027, resp[\u0027status\u0027]) would be necessary for detecting a creation failure earlier if it happens. That would make debugging easier.","commit_id":"9de9acba0d462fecf9a1f4e17f1f362909deda70"},{"author":{"_account_id":9698,"name":"wanglianmin","email":"wanglianmin@huawei.com","username":"wanglianmin"},"change_message_id":"3ddde4a59756973749a4bf72b1cf7bc703542abc","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        # create a user"},{"line_number":83,"context_line":"        resp, user \u003d self.client.create_user("},{"line_number":84,"context_line":"            data_utils.rand_name(\u0027User-\u0027),"},{"line_number":85,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass-\u0027))"},{"line_number":86,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":87,"context_line":"        # create two groups, and add user into them"},{"line_number":88,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FQRI%3D","line":85,"in_reply_to":"AAAAVn%2F%2FREg%3D","updated":"2014-03-07 08:37:34.000000000","message":"Done","commit_id":"9de9acba0d462fecf9a1f4e17f1f362909deda70"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"869e750ca8103644ad192163ef9a27c47d285f8e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        groups \u003d []"},{"line_number":89,"context_line":"        for i in range(2):"},{"line_number":90,"context_line":"            name \u003d data_utils.rand_name(\u0027Group-\u0027)"},{"line_number":91,"context_line":"            resp, group \u003d self.client.create_group(name)"},{"line_number":92,"context_line":"            groups.append(user)"},{"line_number":93,"context_line":"            self.addCleanup(self.client.delete_group, group[\u0027id\u0027])"},{"line_number":94,"context_line":"            self.client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FRDk%3D","line":91,"updated":"2014-03-07 06:30:59.000000000","message":"ditto","commit_id":"9de9acba0d462fecf9a1f4e17f1f362909deda70"},{"author":{"_account_id":9698,"name":"wanglianmin","email":"wanglianmin@huawei.com","username":"wanglianmin"},"change_message_id":"3ddde4a59756973749a4bf72b1cf7bc703542abc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        groups \u003d []"},{"line_number":89,"context_line":"        for i in range(2):"},{"line_number":90,"context_line":"            name \u003d data_utils.rand_name(\u0027Group-\u0027)"},{"line_number":91,"context_line":"            resp, group \u003d self.client.create_group(name)"},{"line_number":92,"context_line":"            groups.append(user)"},{"line_number":93,"context_line":"            self.addCleanup(self.client.delete_group, group[\u0027id\u0027])"},{"line_number":94,"context_line":"            self.client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FQRE%3D","line":91,"in_reply_to":"AAAAVn%2F%2FRDk%3D","updated":"2014-03-07 08:37:34.000000000","message":"Done","commit_id":"9de9acba0d462fecf9a1f4e17f1f362909deda70"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"0d447ff7d1a045d437b8c131d6cdad816661a22a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            data_utils.rand_name(\u0027User-\u0027),"},{"line_number":85,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass-\u0027))"},{"line_number":86,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":87,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":88,"context_line":"        # create two groups, and add user into them"},{"line_number":89,"context_line":"        groups \u003d []"},{"line_number":90,"context_line":"        for i in range(2):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2By00%3D","line":87,"updated":"2014-03-12 05:12:12.000000000","message":"IMO, we don\u0027t need to check status code of create user in this tests as it has been checked in \u0027create user test\u0027. If you have the reason to check it, please exchange line 86 and 87 to make sure user creation is successful before using addCleanup.","commit_id":"6754c638c6b84e5f1d89f1f3e28ec3098f8575d8"},{"author":{"_account_id":9698,"name":"wanglianmin","email":"wanglianmin@huawei.com","username":"wanglianmin"},"change_message_id":"80ae8ce2dd0f6993db71e4f0a280bdd954c2e6b3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            data_utils.rand_name(\u0027User-\u0027),"},{"line_number":85,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass-\u0027))"},{"line_number":86,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":87,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":88,"context_line":"        # create two groups, and add user into them"},{"line_number":89,"context_line":"        groups \u003d []"},{"line_number":90,"context_line":"        for i in range(2):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2BxOw%3D","line":87,"in_reply_to":"AAAAVn%2F%2By00%3D","updated":"2014-03-12 09:31:14.000000000","message":"Done","commit_id":"6754c638c6b84e5f1d89f1f3e28ec3098f8575d8"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"0d447ff7d1a045d437b8c131d6cdad816661a22a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            resp, group \u003d self.client.create_group(name)"},{"line_number":93,"context_line":"            groups.append(user)"},{"line_number":94,"context_line":"            self.addCleanup(self.client.delete_group, group[\u0027id\u0027])"},{"line_number":95,"context_line":"            self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":96,"context_line":"            self.client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"},{"line_number":97,"context_line":"        # list groups which user belongs to"},{"line_number":98,"context_line":"        resp, user_groups \u003d self.client.list_user_groups(user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2By0o%3D","line":95,"updated":"2014-03-12 05:12:12.000000000","message":"ditto for line 94 and 95","commit_id":"6754c638c6b84e5f1d89f1f3e28ec3098f8575d8"},{"author":{"_account_id":9698,"name":"wanglianmin","email":"wanglianmin@huawei.com","username":"wanglianmin"},"change_message_id":"80ae8ce2dd0f6993db71e4f0a280bdd954c2e6b3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            resp, group \u003d self.client.create_group(name)"},{"line_number":93,"context_line":"            groups.append(user)"},{"line_number":94,"context_line":"            self.addCleanup(self.client.delete_group, group[\u0027id\u0027])"},{"line_number":95,"context_line":"            self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":96,"context_line":"            self.client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"},{"line_number":97,"context_line":"        # list groups which user belongs to"},{"line_number":98,"context_line":"        resp, user_groups \u003d self.client.list_user_groups(user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2BxOs%3D","line":95,"in_reply_to":"AAAAVn%2F%2By0o%3D","updated":"2014-03-12 09:31:14.000000000","message":"Done","commit_id":"6754c638c6b84e5f1d89f1f3e28ec3098f8575d8"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"3f40947bb4410f1fb838a838dde405c43a6922bb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # list users in group"},{"line_number":69,"context_line":"        resp, group_users \u003d self.client.list_group_users(group[\u0027id\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027200\u0027)"},{"line_number":71,"context_line":"        self.assertEqual(users.sort(), group_users.sort())"},{"line_number":72,"context_line":"        # delete user in group"},{"line_number":73,"context_line":"        for user in users:"},{"line_number":74,"context_line":"            resp, body \u003d self.client.delete_group_user(group[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Fv%2FY%3D","line":71,"updated":"2014-03-14 02:10:14.000000000","message":"could you help fix this? This is my fault!","commit_id":"4cdd97d6ce6bfb77b81af87232efd74cfc824f44"},{"author":{"_account_id":9698,"name":"wanglianmin","email":"wanglianmin@huawei.com","username":"wanglianmin"},"change_message_id":"a203f2af114b64eb7e62e4423167f1aa7b9aeb4e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # list users in group"},{"line_number":69,"context_line":"        resp, group_users \u003d self.client.list_group_users(group[\u0027id\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027200\u0027)"},{"line_number":71,"context_line":"        self.assertEqual(users.sort(), group_users.sort())"},{"line_number":72,"context_line":"        # delete user in group"},{"line_number":73,"context_line":"        for user in users:"},{"line_number":74,"context_line":"            resp, body \u003d self.client.delete_group_user(group[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Fv5M%3D","line":71,"in_reply_to":"AAAAWH%2F%2Fv%2FY%3D","updated":"2014-03-14 02:48:20.000000000","message":"Done","commit_id":"4cdd97d6ce6bfb77b81af87232efd74cfc824f44"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"a665ac6e173a712109494bd236adf9ba66c34e52","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        for i in range(2):"},{"line_number":90,"context_line":"            name \u003d data_utils.rand_name(\u0027Group-\u0027)"},{"line_number":91,"context_line":"            resp, group \u003d self.client.create_group(name)"},{"line_number":92,"context_line":"            groups.append(user)"},{"line_number":93,"context_line":"            self.addCleanup(self.client.delete_group, group[\u0027id\u0027])"},{"line_number":94,"context_line":"            self.client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"},{"line_number":95,"context_line":"        # list groups which user belongs to"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FwHw%3D","line":92,"updated":"2014-03-14 01:51:37.000000000","message":"groups.append(user) -\u003e groups.append(group) ?\n\nIt\u0027s weird that the test passed.","commit_id":"4cdd97d6ce6bfb77b81af87232efd74cfc824f44"},{"author":{"_account_id":9698,"name":"wanglianmin","email":"wanglianmin@huawei.com","username":"wanglianmin"},"change_message_id":"a203f2af114b64eb7e62e4423167f1aa7b9aeb4e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        for i in range(2):"},{"line_number":90,"context_line":"            name \u003d data_utils.rand_name(\u0027Group-\u0027)"},{"line_number":91,"context_line":"            resp, group \u003d self.client.create_group(name)"},{"line_number":92,"context_line":"            groups.append(user)"},{"line_number":93,"context_line":"            self.addCleanup(self.client.delete_group, group[\u0027id\u0027])"},{"line_number":94,"context_line":"            self.client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"},{"line_number":95,"context_line":"        # list groups which user belongs to"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Fv5E%3D","line":92,"in_reply_to":"AAAAWH%2F%2FwHw%3D","updated":"2014-03-14 02:48:20.000000000","message":"Done","commit_id":"4cdd97d6ce6bfb77b81af87232efd74cfc824f44"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"fb3c0c58a7fc337ba8ffcf6901730614ebd90045","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # list groups which user belongs to"},{"line_number":96,"context_line":"        resp, user_groups \u003d self.client.list_user_groups(user[\u0027id\u0027])"},{"line_number":97,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(groups.sort(), user_groups.sort())"},{"line_number":99,"context_line":"        self.assertEqual(2, len(user_groups))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FwCE%3D","line":98,"updated":"2014-03-14 02:05:14.000000000","message":"the reason is list.sort() doesn\u0027t return value.\n\nsorted() should be fine:\n\n self.assertEqual(sorted(groups), sorted(user_groups))","commit_id":"4cdd97d6ce6bfb77b81af87232efd74cfc824f44"},{"author":{"_account_id":9698,"name":"wanglianmin","email":"wanglianmin@huawei.com","username":"wanglianmin"},"change_message_id":"a203f2af114b64eb7e62e4423167f1aa7b9aeb4e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # list groups which user belongs to"},{"line_number":96,"context_line":"        resp, user_groups \u003d self.client.list_user_groups(user[\u0027id\u0027])"},{"line_number":97,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(groups.sort(), user_groups.sort())"},{"line_number":99,"context_line":"        self.assertEqual(2, len(user_groups))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Fv5A%3D","line":98,"in_reply_to":"AAAAWH%2F%2FwCE%3D","updated":"2014-03-14 02:48:20.000000000","message":"Done","commit_id":"4cdd97d6ce6bfb77b81af87232efd74cfc824f44"}]}